Skip to content

Commit fe95b48

Browse files
abhizipstackclaude
andcommitted
fix: rename status() to event_status() to avoid proto field shadowing
SeedCompleted has a proto field named 'status' which shadows the method. Renamed to event_status() across all UserLevel events and the base class to prevent runtime errors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 96ad05c commit fe95b48

3 files changed

Lines changed: 11 additions & 11 deletions

File tree

backend/visitran/events/base_types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ def subtitle(self) -> str:
108108
"""Contextual metadata shown below the title."""
109109
return ""
110110

111-
def status(self) -> str:
111+
def event_status(self) -> str:
112112
"""One of: running, success, error, warning, info."""
113113
return "success"
114114

backend/visitran/events/eventmgr.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ def write_line(self, msg: EventMsg) -> None:
131131
ts = datetime.utcnow().strftime("%H:%M:%S")
132132
title = getattr(msg.data, "title", lambda: msg.info.msg)()
133133
subtitle = getattr(msg.data, "subtitle", lambda: "")()
134-
event_status = getattr(msg.data, "status", lambda: "info")()
134+
event_status = getattr(msg.data, "event_status", lambda: "info")()
135135
event_code = getattr(msg.data, "code", lambda: "")()
136136
payload = {
137137
"level": msg.info.level,

backend/visitran/events/types.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -846,7 +846,7 @@ def subtitle(self) -> str:
846846
parts.append(f"{self.source_table}{self.destination_table}")
847847
return " · ".join(parts)
848848

849-
def status(self) -> str:
849+
def event_status(self) -> str:
850850
return "running"
851851

852852

@@ -881,7 +881,7 @@ def title(self) -> str:
881881
def subtitle(self) -> str:
882882
return (self.error[:150] + "…") if len(self.error) > 150 else self.error
883883

884-
def status(self) -> str:
884+
def event_status(self) -> str:
885885
return "error"
886886

887887
def level_tag(self) -> EventLevel:
@@ -945,7 +945,7 @@ def title(self) -> str:
945945
def subtitle(self) -> str:
946946
return f"Schema: {self.schema_name}"
947947

948-
def status(self) -> str:
948+
def event_status(self) -> str:
949949
return "success" if self.status == "Success" else "error"
950950

951951

@@ -987,7 +987,7 @@ def message(self) -> str:
987987
def title(self) -> str:
988988
return f'Job "{self.job_name}" deleted'
989989

990-
def status(self) -> str:
990+
def event_status(self) -> str:
991991
return "warning"
992992

993993

@@ -1007,7 +1007,7 @@ def subtitle(self) -> str:
10071007
scope_desc = "All models" if self.scope == "job" else f"Model: {self.scope}"
10081008
return f"{scope_desc} · Manual trigger"
10091009

1010-
def status(self) -> str:
1010+
def event_status(self) -> str:
10111011
return "running"
10121012

10131013

@@ -1036,7 +1036,7 @@ def message(self) -> str:
10361036
def title(self) -> str:
10371037
return f'Deleted: {self.file_names}'
10381038

1039-
def status(self) -> str:
1039+
def event_status(self) -> str:
10401040
return "warning"
10411041

10421042

@@ -1099,7 +1099,7 @@ def message(self) -> str:
10991099
def title(self) -> str:
11001100
return f'Connection "{self.connection_name}" deleted'
11011101

1102-
def status(self) -> str:
1102+
def event_status(self) -> str:
11031103
return "warning"
11041104

11051105

@@ -1121,7 +1121,7 @@ def title(self) -> str:
11211121
def subtitle(self) -> str:
11221122
return (self.reason[:150] + "…") if len(self.reason) > 150 else self.reason
11231123

1124-
def status(self) -> str:
1124+
def event_status(self) -> str:
11251125
return "error"
11261126

11271127

@@ -1148,5 +1148,5 @@ def message(self) -> str:
11481148
def title(self) -> str:
11491149
return f'Environment "{self.environment_name}" deleted'
11501150

1151-
def status(self) -> str:
1151+
def event_status(self) -> str:
11521152
return "warning"

0 commit comments

Comments
 (0)