From cbcb4871a517c8429abb57e8a4ee7281887249bd Mon Sep 17 00:00:00 2001 From: ZZ-Cat Date: Tue, 1 Jul 2025 20:39:25 +0000 Subject: [PATCH 01/13] chore(environment): Add Australian English dictionary to Code Spell Checker This is about as close to New Zealand English as I am going to get... until Streetside Software _actually_ adds New Zealand English to their add-ons to Code Spell Checker. --- .devcontainer/devcontainer.json | 1 + 1 file changed, 1 insertion(+) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index f2e4ca7b..762e7dd1 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -15,6 +15,7 @@ "ms-vscode.cpptools-themes", "platformio.platformio-ide", "streetsidesoftware.code-spell-checker", + "streetsidesoftware.code-spell-checker-australian-english", "vivaxy.vscode-conventional-commits", "xaver.clang-format" ] From 371bbbc82ca2c8c83bbac390c760870d071df0da Mon Sep 17 00:00:00 2001 From: ZZ-Cat Date: Tue, 1 Jul 2025 20:52:30 +0000 Subject: [PATCH 02/13] chore(platformio): Move all PlatformIO configuration files to src/build/scripts and src/build/targets This moves all of PlatformIO's files (including the main platformio.ini and all target-specific .ini files) to a new directory structure under src/build/scripts and src/build/targets. This change is made to simplify the build and check process, making it easier to manage and maintain the configuration files. **Breaking Changes:** - The paths to the PlatformIO configuration files have changed. - The main `platformio.ini` file is now located at `src/build/scripts/platformio.ini`. - Target-specific configuration files are now located in `src/build/targets/`. - The previous paths to these files will no longer work. --- platformio.ini => src/build/scripts/platformio.ini | 0 {targets => src/build/targets}/common.ini | 0 {targets => src/build/targets}/quality_control.ini | 0 {targets => src/build/targets}/unified_esp32.ini | 0 {targets => src/build/targets}/unified_rp2040.ini | 0 {targets => src/build/targets}/unified_samd21.ini | 0 {targets => src/build/targets}/unified_samd51.ini | 0 {targets => src/build/targets}/unified_stm32.ini | 0 {targets => src/build/targets}/unified_teensy3x.ini | 0 {targets => src/build/targets}/unified_teensy4x.ini | 0 10 files changed, 0 insertions(+), 0 deletions(-) rename platformio.ini => src/build/scripts/platformio.ini (100%) rename {targets => src/build/targets}/common.ini (100%) rename {targets => src/build/targets}/quality_control.ini (100%) rename {targets => src/build/targets}/unified_esp32.ini (100%) rename {targets => src/build/targets}/unified_rp2040.ini (100%) rename {targets => src/build/targets}/unified_samd21.ini (100%) rename {targets => src/build/targets}/unified_samd51.ini (100%) rename {targets => src/build/targets}/unified_stm32.ini (100%) rename {targets => src/build/targets}/unified_teensy3x.ini (100%) rename {targets => src/build/targets}/unified_teensy4x.ini (100%) diff --git a/platformio.ini b/src/build/scripts/platformio.ini similarity index 100% rename from platformio.ini rename to src/build/scripts/platformio.ini diff --git a/targets/common.ini b/src/build/targets/common.ini similarity index 100% rename from targets/common.ini rename to src/build/targets/common.ini diff --git a/targets/quality_control.ini b/src/build/targets/quality_control.ini similarity index 100% rename from targets/quality_control.ini rename to src/build/targets/quality_control.ini diff --git a/targets/unified_esp32.ini b/src/build/targets/unified_esp32.ini similarity index 100% rename from targets/unified_esp32.ini rename to src/build/targets/unified_esp32.ini diff --git a/targets/unified_rp2040.ini b/src/build/targets/unified_rp2040.ini similarity index 100% rename from targets/unified_rp2040.ini rename to src/build/targets/unified_rp2040.ini diff --git a/targets/unified_samd21.ini b/src/build/targets/unified_samd21.ini similarity index 100% rename from targets/unified_samd21.ini rename to src/build/targets/unified_samd21.ini diff --git a/targets/unified_samd51.ini b/src/build/targets/unified_samd51.ini similarity index 100% rename from targets/unified_samd51.ini rename to src/build/targets/unified_samd51.ini diff --git a/targets/unified_stm32.ini b/src/build/targets/unified_stm32.ini similarity index 100% rename from targets/unified_stm32.ini rename to src/build/targets/unified_stm32.ini diff --git a/targets/unified_teensy3x.ini b/src/build/targets/unified_teensy3x.ini similarity index 100% rename from targets/unified_teensy3x.ini rename to src/build/targets/unified_teensy3x.ini diff --git a/targets/unified_teensy4x.ini b/src/build/targets/unified_teensy4x.ini similarity index 100% rename from targets/unified_teensy4x.ini rename to src/build/targets/unified_teensy4x.ini From a03d9d1e1e2ef76ce938d93eff1df5a3cb34b4f3 Mon Sep 17 00:00:00 2001 From: ZZ-Cat Date: Tue, 1 Jul 2025 21:17:20 +0000 Subject: [PATCH 03/13] chore(platformio): :wrench: Update working directories to reflect recent directory changes --- src/build/scripts/platformio.ini | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/src/build/scripts/platformio.ini b/src/build/scripts/platformio.ini index a0883b29..ac63daeb 100644 --- a/src/build/scripts/platformio.ini +++ b/src/build/scripts/platformio.ini @@ -9,24 +9,25 @@ ; https://docs.platformio.org/page/projectconf.html [platformio] -core_dir = .pio/core +core_dir = /workspaces/CRSFforArduino/.pio/core +workspace_dir = /workspaces/CRSFforArduino/.pio default_envs = ; defect_detector development ; ${build.all} extra_configs = - targets/common.ini - targets/quality_control.ini - targets/unified_esp32.ini - targets/unified_rp2040.ini - targets/unified_samd21.ini - targets/unified_samd51.ini - targets/unified_stm32.ini - targets/unified_teensy3x.ini - targets/unified_teensy4x.ini -include_dir = src -lib_dir = src -src_dir = src + /workspaces/CRSFforArduino/src/build/targets/common.ini + /workspaces/CRSFforArduino/src/build/targets/quality_control.ini + /workspaces/CRSFforArduino/src/build/targets/unified_esp32.ini + /workspaces/CRSFforArduino/src/build/targets/unified_rp2040.ini + /workspaces/CRSFforArduino/src/build/targets/unified_samd21.ini + /workspaces/CRSFforArduino/src/build/targets/unified_samd51.ini + /workspaces/CRSFforArduino/src/build/targets/unified_stm32.ini + /workspaces/CRSFforArduino/src/build/targets/unified_teensy3x.ini + /workspaces/CRSFforArduino/src/build/targets/unified_teensy4x.ini +include_dir = /workspaces/CRSFforArduino/src +lib_dir = /workspaces/CRSFforArduino/src +src_dir = /workspaces/CRSFforArduino/src test_dir = [env:development] From 784954242d7deea4bb8b079620a10605bf743845 Mon Sep 17 00:00:00 2001 From: ZZ-Cat Date: Tue, 1 Jul 2025 21:35:35 +0000 Subject: [PATCH 04/13] chore(platformio): :wrench: Update working directories to reflect recent directory changes All working directories have been updated to reflect the recent changes in the directory structure. All builds and checks are now performed from the `src/build/scripts` directory. This resolves the prior broken changes introduced by 371bbbc82ca2c8c83bbac390c760870d071df0da. --- src/build/scripts/platformio.ini | 16 ++++++++++++---- src/build/targets/common.ini | 18 +++++++++++++----- src/build/targets/quality_control.ini | 16 ++++++++++++---- 3 files changed, 37 insertions(+), 13 deletions(-) diff --git a/src/build/scripts/platformio.ini b/src/build/scripts/platformio.ini index ac63daeb..acf5d0e1 100644 --- a/src/build/scripts/platformio.ini +++ b/src/build/scripts/platformio.ini @@ -32,9 +32,17 @@ test_dir = [env:development] board = adafruit_metro_m4 -build_src_filter = - +<../examples/platformio/main.cpp> - +<*/*/*.cpp> - +<*.cpp> +build_src_filter = + + + + + + + + + + + + + + + + + ; +<../examples/platformio/main.cpp> + ; +<*/*/*.cpp> + ; +<*.cpp> build_type = debug extends = env_common_samd51 diff --git a/src/build/targets/common.ini b/src/build/targets/common.ini index e8e98a17..2c3a2a3d 100644 --- a/src/build/targets/common.ini +++ b/src/build/targets/common.ini @@ -36,11 +36,19 @@ platform = teensy@4.18.0 [env] framework = arduino -build_src_filter = - -<../examples/platformio/cfa_code_test.cpp> - +<../examples/platformio/main.cpp> - +<*/*/*.cpp> - +<*.cpp> +build_src_filter = + + + + + + + + + + + + + + + + + ; -<../examples/platformio/cfa_code_test.cpp> + ; +<../examples/platformio/main.cpp> + ; +<*/*/*.cpp> + ; +<*.cpp> build_unflags = -Os build_flags = diff --git a/src/build/targets/quality_control.ini b/src/build/targets/quality_control.ini index a0e75e39..2db569a7 100644 --- a/src/build/targets/quality_control.ini +++ b/src/build/targets/quality_control.ini @@ -30,10 +30,18 @@ build_flags = -DCRSF_LINK_STATISTICS_ENABLED=1 -build_src_filter = - +<../examples/platformio/main.cpp> - +<*/*/*.cpp> - +<*.cpp> +build_src_filter = + + + + + + + + + + + + + + + + + ; +<../examples/platformio/main.cpp> + ; +<*/*/*.cpp> + ; +<*.cpp> build_type = debug check_flags = --disable=unusedFunction From fae8b9846aefadadbfd796ef241af45fed2ba798 Mon Sep 17 00:00:00 2001 From: ZZ-Cat Date: Tue, 1 Jul 2025 21:54:05 +0000 Subject: [PATCH 05/13] ci(quality control): :sparkles: Initial commit of build python script This introduces a new build script that simplifies the build and check process for CFA. --- src/build/scripts/build.py | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 src/build/scripts/build.py diff --git a/src/build/scripts/build.py b/src/build/scripts/build.py new file mode 100644 index 00000000..83bbb229 --- /dev/null +++ b/src/build/scripts/build.py @@ -0,0 +1,16 @@ +import subprocess +import sys + +if __name__ == "__main__": + # Run the PlatformIO build command + command = "pio run -e development" + try: + subprocess.run(command, shell=True, check=True, text=True, capture_output=True) + except subprocess.CalledProcessError as e: + print(f"{e.stdout.strip()}") + print(f"{e.stderr.strip()}") + print("Tests failed. Please resolve the issues before proceeding.") + exit(1) + + # Exit with code 0 if everything is fine. + exit(0) From 24b8e3760757cf68f5504474495d103f311592f2 Mon Sep 17 00:00:00 2001 From: ZZ-Cat Date: Wed, 2 Jul 2025 20:58:10 +0000 Subject: [PATCH 06/13] ci(quality control): :wastebasket: Comment out existing code --- src/build/scripts/build.py | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/build/scripts/build.py b/src/build/scripts/build.py index 83bbb229..3ea1c9c5 100644 --- a/src/build/scripts/build.py +++ b/src/build/scripts/build.py @@ -2,15 +2,15 @@ import sys if __name__ == "__main__": - # Run the PlatformIO build command - command = "pio run -e development" - try: - subprocess.run(command, shell=True, check=True, text=True, capture_output=True) - except subprocess.CalledProcessError as e: - print(f"{e.stdout.strip()}") - print(f"{e.stderr.strip()}") - print("Tests failed. Please resolve the issues before proceeding.") - exit(1) + # # Run the PlatformIO build command + # command = "pio run -e development" + # try: + # subprocess.run(command, shell=True, check=True, text=True, capture_output=True) + # except subprocess.CalledProcessError as e: + # print(f"{e.stdout.strip()}") + # print(f"{e.stderr.strip()}") + # print("Tests failed. Please resolve the issues before proceeding.") + # exit(1) - # Exit with code 0 if everything is fine. - exit(0) + # # Exit with code 0 if everything is fine. + # exit(0) From 4e78f604c47dabb3fbd9d5d292786bb371916011 Mon Sep 17 00:00:00 2001 From: ZZ-Cat Date: Wed, 2 Jul 2025 21:05:22 +0000 Subject: [PATCH 07/13] ci(quality control): :recycle: Pass `--deploy` as an argument to flash the `development` environment to its pre-configured development board If `--deploy` is not provided, the `development` environment is built but not flashed. --- src/build/scripts/build.py | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/src/build/scripts/build.py b/src/build/scripts/build.py index 3ea1c9c5..b9d722c8 100644 --- a/src/build/scripts/build.py +++ b/src/build/scripts/build.py @@ -2,6 +2,34 @@ import sys if __name__ == "__main__": + # Get the command line arguments. + args = sys.argv[1:] + # If --deploy was specified as a command line argument, deploy the code to the device. + if "--deploy" in args: + # Run the PlatformIO upload command. + command = "pio run -e development -t upload" + try: + subprocess.run(command, shell=True, check=True, text=True, capture_output=True) + except subprocess.CalledProcessError as e: + print(f"{e.stdout.strip()}") + print(f"{e.stderr.strip()}") + print("Deployment failed. Please resolve the issues before proceeding.") + exit(1) + # If no arguments were specified, run the build command. + else: + # Run the PlatformIO build command. + command = "pio run -e development" + try: + subprocess.run(command, shell=True, check=True, text=True, capture_output=True) + except subprocess.CalledProcessError as e: + print(f"{e.stdout.strip()}") + print(f"{e.stderr.strip()}") + print("Build failed. Please resolve the issues before proceeding.") + exit(1) + + # Exit with code 0 if everything is fine. + exit(0) + # # Run the PlatformIO build command # command = "pio run -e development" # try: From 217ab717574af8640bc659a37225c53cecdfc3fe Mon Sep 17 00:00:00 2001 From: ZZ-Cat Date: Wed, 2 Jul 2025 21:13:57 +0000 Subject: [PATCH 08/13] ci(quality control): :sparkles: Add `--deploy-and-monitor` argument Use this for monitoring data over the Serial Monitor --- src/build/scripts/build.py | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/src/build/scripts/build.py b/src/build/scripts/build.py index b9d722c8..017a9dca 100644 --- a/src/build/scripts/build.py +++ b/src/build/scripts/build.py @@ -15,6 +15,29 @@ print(f"{e.stderr.strip()}") print("Deployment failed. Please resolve the issues before proceeding.") exit(1) + + # If --deploy-and-monitor was specified as a command line argument, + # deploy the code to the device, wait for it to finish, and then start the serial monitor. + elif "--deploy-and-monitor" in args: + # Run the PlatformIO upload command. + command = "pio run -e development -t upload" + try: + subprocess.run(command, shell=True, check=True, text=True, capture_output=True) + except subprocess.CalledProcessError as e: + print(f"{e.stdout.strip()}") + print(f"{e.stderr.strip()}") + print("Deployment failed. Please resolve the issues before proceeding.") + exit(1) + # Start the serial monitor. + command = "pio device monitor" + try: + subprocess.run(command, shell=True, check=True, text=True) + except subprocess.CalledProcessError as e: + print(f"{e.stdout.strip()}") + print(f"{e.stderr.strip()}") + print("Failed to start the serial monitor. Please resolve the issues before proceeding.") + exit(1) + # If no arguments were specified, run the build command. else: # Run the PlatformIO build command. From 65c0a41d53ba0c54549437d2d9f0597294de5c72 Mon Sep 17 00:00:00 2001 From: ZZ-Cat Date: Wed, 2 Jul 2025 21:46:03 +0000 Subject: [PATCH 09/13] ci(quality control): :sparkles: Add defect detector to python script This runs first _before_ anything else. If something fails here, the entire process is halted. --- src/build/scripts/build.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/build/scripts/build.py b/src/build/scripts/build.py index 017a9dca..09ea9af3 100644 --- a/src/build/scripts/build.py +++ b/src/build/scripts/build.py @@ -2,6 +2,16 @@ import sys if __name__ == "__main__": + # Run the defect detector to check for any issues in the code. + command = "pio check -e defect_detector --fail-on-defect=low --fail-on-defect=medium --fail-on-defect=high" + try: + subprocess.run(command, shell=True, check=True, text=True, capture_output=True) + except subprocess.CalledProcessError as e: + print(f"{e.stdout.strip()}") + print(f"{e.stderr.strip()}") + print("There were issues detected in the code-base. Please resolve them before proceeding.") + exit(1) + # Get the command line arguments. args = sys.argv[1:] # If --deploy was specified as a command line argument, deploy the code to the device. From e508d4ca97025d7462b97fe8c5701615280a857d Mon Sep 17 00:00:00 2001 From: ZZ-Cat Date: Fri, 15 Aug 2025 20:58:40 +0000 Subject: [PATCH 10/13] chore(quality control): :wastebasket: Deprecate old static analysis and build code in `quality_control.yml` workflow These two separate workflows are being replaced with one python script. --- .github/workflows/quality_control.yml | 74 +++++++++++++-------------- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/.github/workflows/quality_control.yml b/.github/workflows/quality_control.yml index f19a00ec..4221d1a8 100644 --- a/.github/workflows/quality_control.yml +++ b/.github/workflows/quality_control.yml @@ -27,46 +27,46 @@ jobs: run: python3 ci/run-clang-format.py -e "ci/*" -e "bin/*" -r . # Static code analysis with cppcheck using PlatformIO - defect_detector: - runs-on: ubuntu-latest + # defect_detector: + # runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4.1.1 - - uses: actions/cache@v4 - with: - path: | - ~/.cache/pip - ~/.platformio/.cache - key: ${{ runner.os }}-pio - - uses: actions/setup-python@v5 - with: - python-version: '3.9' - - name: Install PlatformIO Core - run: pip install --upgrade platformio + # steps: + # - uses: actions/checkout@v4.1.1 + # - uses: actions/cache@v4 + # with: + # path: | + # ~/.cache/pip + # ~/.platformio/.cache + # key: ${{ runner.os }}-pio + # - uses: actions/setup-python@v5 + # with: + # python-version: '3.9' + # - name: Install PlatformIO Core + # run: pip install --upgrade platformio - - name: Build defect detector - run: pio run -e defect_detector + # - name: Build defect detector + # run: pio run -e defect_detector - - name: Run defect detector - run: pio check -e defect_detector --fail-on-defect=low --fail-on-defect=medium --fail-on-defect=high + # - name: Run defect detector + # run: pio check -e defect_detector --fail-on-defect=low --fail-on-defect=medium --fail-on-defect=high - # Build the project with PlatformIO - build_on_compatible_targets: - runs-on: ubuntu-latest + # # Build the project with PlatformIO + # build_on_compatible_targets: + # runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4.1.1 - - uses: actions/cache@v4 - with: - path: | - ~/.cache/pip - ~/.platformio/.cache - key: ${{ runner.os }}-pio - - uses: actions/setup-python@v5 - with: - python-version: '3.9' - - name: Install PlatformIO Core - run: pip install --upgrade platformio + # steps: + # - uses: actions/checkout@v4.1.1 + # - uses: actions/cache@v4 + # with: + # path: | + # ~/.cache/pip + # ~/.platformio/.cache + # key: ${{ runner.os }}-pio + # - uses: actions/setup-python@v5 + # with: + # python-version: '3.9' + # - name: Install PlatformIO Core + # run: pip install --upgrade platformio - - name: Build CRSF for Arduino on compatible targets - run: pio run + # - name: Build CRSF for Arduino on compatible targets + # run: pio run From ccb67b019d2e8024c5da6a8c6ae7bc301fbc15a9 Mon Sep 17 00:00:00 2001 From: ZZ-Cat Date: Fri, 15 Aug 2025 21:22:03 +0000 Subject: [PATCH 11/13] ci(quality control): :recycle: Replace old quality control workflow code with new quality control python script --- .github/workflows/quality_control.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/.github/workflows/quality_control.yml b/.github/workflows/quality_control.yml index 4221d1a8..25902314 100644 --- a/.github/workflows/quality_control.yml +++ b/.github/workflows/quality_control.yml @@ -26,6 +26,25 @@ jobs: - name: Check for correct formatting with clang-format run: python3 ci/run-clang-format.py -e "ci/*" -e "bin/*" -r . + # New quality control script using Python and PlatformIO. + defect_detector: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4.1.1 + - uses: actions/cache@v4 + with: + path: | + ~/.cache/pip + ~/.platformio/.cache + key: ${{runner.os}}-pio + - uses: actions/setup-python@v5 + with: + python-version: '3.9' + - name: Install PlatformIO + run: pip install --upgrade platformio + - name: Run Quality Control script + run: cd src/build/scripts && python build.py + # Static code analysis with cppcheck using PlatformIO # defect_detector: # runs-on: ubuntu-latest From 20892d3c702d985163a5b29e22632b95b813f27e Mon Sep 17 00:00:00 2001 From: ZZ-Cat Date: Fri, 29 Aug 2025 06:32:34 +0000 Subject: [PATCH 12/13] ci(quality control): :sparkles: Add build verification of commonly used devices This provides a starting point that just works, for future improvement. It build-tests CFA across commonly used development boards that have been tested and verified by the community. This is the way moving forward. No more untested development boards. --- .github/workflows/quality_control.yml | 2 +- src/build/scripts/build.py | 17 +++++++++++++++++ src/build/scripts/platformio.ini | 4 ++-- 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/.github/workflows/quality_control.yml b/.github/workflows/quality_control.yml index 25902314..6fbbd9de 100644 --- a/.github/workflows/quality_control.yml +++ b/.github/workflows/quality_control.yml @@ -43,7 +43,7 @@ jobs: - name: Install PlatformIO run: pip install --upgrade platformio - name: Run Quality Control script - run: cd src/build/scripts && python build.py + run: cd src/build/scripts && python build.py --build-on-compatible-devices # Static code analysis with cppcheck using PlatformIO # defect_detector: diff --git a/src/build/scripts/build.py b/src/build/scripts/build.py index 09ea9af3..339a881d 100644 --- a/src/build/scripts/build.py +++ b/src/build/scripts/build.py @@ -47,6 +47,23 @@ print(f"{e.stderr.strip()}") print("Failed to start the serial monitor. Please resolve the issues before proceeding.") exit(1) + + # Check compatibility across verified devices. + # TO-DO: + # - Conduct static analysis across verified devices. + # - May need to update platformio.ini and the other targets files for this. + # - For now, this just works. + elif "--build-on-compatible-devices" in args: + # No arguments provided—defaults to building across commonly used devices. + # Because these are the ones that are tested and verified It Just Works. + command = "pio run" + try: + subprocess.run(command, shell=True, check=True, capture_output=True) + except subprocess.CalledProcessError as e: + print(f"{e.stdout.strip()}") + print(f"{e.stderr.strip()}") + print("Build failed. One or more devices are not compatible.") + exit(1) # If no arguments were specified, run the build command. else: diff --git a/src/build/scripts/platformio.ini b/src/build/scripts/platformio.ini index acf5d0e1..cf8e27da 100644 --- a/src/build/scripts/platformio.ini +++ b/src/build/scripts/platformio.ini @@ -13,8 +13,8 @@ core_dir = /workspaces/CRSFforArduino/.pio/core workspace_dir = /workspaces/CRSFforArduino/.pio default_envs = ; defect_detector - development - ; ${build.all} + ; development + ${build.commonly_used} extra_configs = /workspaces/CRSFforArduino/src/build/targets/common.ini /workspaces/CRSFforArduino/src/build/targets/quality_control.ini From d72eb2cf241a377dbe58f3d465a6a99201c9932c Mon Sep 17 00:00:00 2001 From: ZZ-Cat Date: Fri, 29 Aug 2025 06:34:57 +0000 Subject: [PATCH 13/13] ci(quality control): :fire: Remove commented out code --- .github/workflows/quality_control.yml | 45 --------------------------- src/build/scripts/build.py | 13 -------- src/build/scripts/platformio.ini | 3 -- 3 files changed, 61 deletions(-) diff --git a/.github/workflows/quality_control.yml b/.github/workflows/quality_control.yml index 6fbbd9de..e08a92c2 100644 --- a/.github/workflows/quality_control.yml +++ b/.github/workflows/quality_control.yml @@ -44,48 +44,3 @@ jobs: run: pip install --upgrade platformio - name: Run Quality Control script run: cd src/build/scripts && python build.py --build-on-compatible-devices - - # Static code analysis with cppcheck using PlatformIO - # defect_detector: - # runs-on: ubuntu-latest - - # steps: - # - uses: actions/checkout@v4.1.1 - # - uses: actions/cache@v4 - # with: - # path: | - # ~/.cache/pip - # ~/.platformio/.cache - # key: ${{ runner.os }}-pio - # - uses: actions/setup-python@v5 - # with: - # python-version: '3.9' - # - name: Install PlatformIO Core - # run: pip install --upgrade platformio - - # - name: Build defect detector - # run: pio run -e defect_detector - - # - name: Run defect detector - # run: pio check -e defect_detector --fail-on-defect=low --fail-on-defect=medium --fail-on-defect=high - - # # Build the project with PlatformIO - # build_on_compatible_targets: - # runs-on: ubuntu-latest - - # steps: - # - uses: actions/checkout@v4.1.1 - # - uses: actions/cache@v4 - # with: - # path: | - # ~/.cache/pip - # ~/.platformio/.cache - # key: ${{ runner.os }}-pio - # - uses: actions/setup-python@v5 - # with: - # python-version: '3.9' - # - name: Install PlatformIO Core - # run: pip install --upgrade platformio - - # - name: Build CRSF for Arduino on compatible targets - # run: pio run diff --git a/src/build/scripts/build.py b/src/build/scripts/build.py index 339a881d..ee03a7e3 100644 --- a/src/build/scripts/build.py +++ b/src/build/scripts/build.py @@ -79,16 +79,3 @@ # Exit with code 0 if everything is fine. exit(0) - - # # Run the PlatformIO build command - # command = "pio run -e development" - # try: - # subprocess.run(command, shell=True, check=True, text=True, capture_output=True) - # except subprocess.CalledProcessError as e: - # print(f"{e.stdout.strip()}") - # print(f"{e.stderr.strip()}") - # print("Tests failed. Please resolve the issues before proceeding.") - # exit(1) - - # # Exit with code 0 if everything is fine. - # exit(0) diff --git a/src/build/scripts/platformio.ini b/src/build/scripts/platformio.ini index cf8e27da..336bae04 100644 --- a/src/build/scripts/platformio.ini +++ b/src/build/scripts/platformio.ini @@ -41,8 +41,5 @@ build_src_filter = + + + - ; +<../examples/platformio/main.cpp> - ; +<*/*/*.cpp> - ; +<*.cpp> build_type = debug extends = env_common_samd51