Scripts/Misc: Remove unneccessary GameObjectActions casts

Author: Shauren

src/server/scripts/Northrend/Ulduar/Ulduar/boss_hodir.cpp

@@ -465,7 +465,7 @@ struct boss_hodir : public BossAI
                     std::vector<GameObject*> firesObjects;
                     GetGameObjectListWithEntryInGrid(firesObjects, me, GO_TOASTY_FIRE, 100.0f);
                     for (GameObject* fire : firesObjects)
-                        fire->ActivateObject(GameObjectActions(GameObjectActions::Despawn));
+                        fire->ActivateObject(GameObjectActions::Despawn);
 
                     events.ScheduleEvent(EVENT_FLASH_FREEZE_FINISHED_3, 1s);
                     break;
@@ -751,7 +751,7 @@ struct npc_toasty_fire : public ScriptedAI
         if (spellInfo->Id == SPELL_ICE_SHARDS_DAMAGE_1 || spellInfo->Id == SPELL_ICE_SHARDS_DAMAGE_2)
         {
             if (GameObject* fire = me->FindNearestGameObject(GO_TOASTY_FIRE, 1.0f))
-                fire->ActivateObject(GameObjectActions(GameObjectActions::Despawn));
+                fire->ActivateObject(GameObjectActions::Despawn);
 
             me->DespawnOrUnsummon();
         }

src/server/scripts/Northrend/Ulduar/Ulduar/instance_ulduar.cpp

@@ -586,7 +586,7 @@ class instance_ulduar : public InstanceMapScript
                         if (Creature* hodir = GetCreature(DATA_HODIR))
                             hodir->AI()->DoAction(ACTION_CACHE_SHATTERED);
                         if (GameObject* hodirRareCache = instance->GetGameObject(HodirRareCacheGUID))
-                            hodirRareCache->ActivateObject(GameObjectActions(GameObjectActions::Despawn));
+                            hodirRareCache->ActivateObject(GameObjectActions::Despawn);
                         break;
                     case EVENT_FLASH_FREEZE_FINISHED:
                         if (Creature* hodir = GetCreature(DATA_HODIR))
@@ -654,9 +654,9 @@ class instance_ulduar : public InstanceMapScript
                         if (state == DONE)
                         {
                             if (GameObject* hodirRareCache = instance->GetGameObject(HodirRareCacheGUID))
-                                hodirRareCache->ActivateObject(GameObjectActions(GameObjectActions::MakeActive));
+                                hodirRareCache->ActivateObject(GameObjectActions::MakeActive);
                             if (GameObject* hodirChest = instance->GetGameObject(HodirChestGUID))
-                                hodirChest->ActivateObject(GameObjectActions(GameObjectActions::MakeActive));
+                                hodirChest->ActivateObject(GameObjectActions::MakeActive);
 
                             instance->SummonCreature(NPC_HODIR_OBSERVATION_RING, ObservationRingKeepersPos[1]);
                         }

src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_lady_vashj.cpp

@@ -265,7 +265,7 @@ struct boss_lady_vashj : public BossAI
     {
         for (uint32 data : ShieldGeneratorData)
             if (GameObject* generator = instance->GetGameObject(data))
-                generator->ActivateObject(GameObjectActions(GameObjectActions::MakeInert));
+                generator->ActivateObject(GameObjectActions::MakeInert);
 
         DoDespawnSummons();
         DoCleanupTriggers();
@@ -460,7 +460,7 @@ struct boss_lady_vashj : public BossAI
 
                     for (uint32 data : ShieldGeneratorData)
                         if (GameObject* generator = instance->GetGameObject(data))
-                            generator->ActivateObject(GameObjectActions(GameObjectActions::MakeActive));
+                            generator->ActivateObject(GameObjectActions::MakeActive);
 
                     me->SetReactState(REACT_AGGRESSIVE);
 
@@ -703,7 +703,7 @@ struct go_shield_generator : public GameObjectAI
         if (Creature* vashj = _instance->GetCreature(BOSS_LADY_VASHJ))
             vashj->AI()->DoAction(ACTION_SHIELD_GENERATOR_DEACTIVATED);
 
-        me->ActivateObject(GameObjectActions(GameObjectActions::MakeInert));
+        me->ActivateObject(GameObjectActions::MakeInert);
 
         return false;
     }

src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_lurker_below.cpp

@@ -434,7 +434,7 @@ struct go_strange_pool : public GameObjectAI
             if (Creature* trigger = GetClosestCreatureWithEntry(me, NPC_WORLD_TRIGGER_NOT_IMMUNE_PC, 50.0f))
                 trigger->CastSpell(player, SPELL_LURKER_SPAWN_TRIGGER);
 
-            me->ActivateObject(GameObjectActions(GameObjectActions::Despawn));
+            me->ActivateObject(GameObjectActions::Despawn);
 
             me->GetMap()->SummonCreature(NPC_THE_LURKER_BELOW, LurkerSpawnPosition);
             if (InstanceScript* instance = me->GetInstanceScript())

src/server/scripts/Outland/CoilfangReservoir/SteamVault/instance_steam_vault.cpp

@@ -62,7 +62,7 @@ class instance_steam_vault : public InstanceMapScript
                     if (GetBossState(DATA_HYDROMANCER_THESPIA) == DONE && GetBossState(DATA_MEKGINEER_STEAMRIGGER) == DONE)
                     {
                         HandleGameObject(ObjectGuid::Empty, true, go);
-                        go->ActivateObject(GameObjectActions(GameObjectActions::MakeInert));
+                        go->ActivateObject(GameObjectActions::MakeInert);
                     }
                 }
             }
@@ -77,12 +77,12 @@ class instance_steam_vault : public InstanceMapScript
                     case DATA_HYDROMANCER_THESPIA:
                         if (state == DONE)
                             if (GameObject* panel = GetGameObject(DATA_ACCESS_PANEL_THESPIA))
-                                panel->ActivateObject(GameObjectActions(GameObjectActions::MakeActive));
+                                panel->ActivateObject(GameObjectActions::MakeActive);
                         break;
                     case DATA_MEKGINEER_STEAMRIGGER:
                         if (state == DONE)
                             if (GameObject* panel = GetGameObject(DATA_ACCESS_PANEL_STEAMRIGGER))
-                                panel->ActivateObject(GameObjectActions(GameObjectActions::MakeActive));
+                                panel->ActivateObject(GameObjectActions::MakeActive);
                         break;
                     default:
                         break;

src/server/scripts/Outland/CoilfangReservoir/SteamVault/steam_vault.cpp

@@ -36,7 +36,7 @@ struct go_main_chambers_access_panel : public GameObjectAI
 
     bool OnGossipHello(Player* /*player*/) override
     {
-        me->ActivateObject(GameObjectActions(GameObjectActions::MakeInert));
+        me->ActivateObject(GameObjectActions::MakeInert);
 
         if (Creature* controller = _instance->GetCreature(DATA_DOOR_CONTROLLER))
             controller->AI()->Talk(EMOTE_PANEL_USED);
@@ -49,7 +49,7 @@ struct go_main_chambers_access_panel : public GameObjectAI
             if (GameObject* go = _instance->GetGameObject(DATA_MAIN_CHAMBERS_DOOR))
             {
                 _instance->HandleGameObject(ObjectGuid::Empty, true, go);
-                go->ActivateObject(GameObjectActions(GameObjectActions::MakeInert));
+                go->ActivateObject(GameObjectActions::MakeInert);
             }
         }
 

src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/instance_hellfire_ramparts.cpp

@@ -89,7 +89,7 @@ class instance_ramparts : public InstanceMapScript
                     if (state == DONE)
                     {
                         if (GameObject* chest = GetGameObject(DATA_FEL_IRON_CHEST))
-                            chest->ActivateObject(GameObjectActions(GameObjectActions::MakeActive));
+                            chest->ActivateObject(GameObjectActions::MakeActive);
                     }
                     else if (state == FAIL)
                         Events.ScheduleEvent(EVENT_RESET_VAZRUDEN, 30s);