Core/GameObjects: Use all axis rotations for gameobject model collision, not just orientation

(cherry-picked from commit c13d26e1fa40ac8d40e1b4f7c72e4c1ef3f6c5e8)

Author: Shauren

src/common/Collision/Models/GameObjectModel.cpp

@@ -19,6 +19,7 @@
 #include "Log.h"
 #include "MapTree.h"
 #include "Timer.h"
+#include <G3D/Quat.h>
 #include "VMapDefinitions.h"
 #include "VMapFactory.h"
 #include "VMapManager2.h"
@@ -126,7 +127,7 @@ bool GameObjectModel::initialize(std::unique_ptr<GameObjectModelOwnerBase> model
     iScale = modelOwner->GetScale();
     iInvScale = 1.f / iScale;
 
-    G3D::Matrix3 iRotation = G3D::Matrix3::fromEulerAnglesZYX(modelOwner->GetOrientation(), 0, 0);
+    G3D::Matrix3 iRotation = modelOwner->GetRotation().toRotationMatrix();
     iInvRot = iRotation.inverse();
     // transform bounding box:
     mdl_box = AABox(mdl_box.low() * iScale, mdl_box.high() * iScale);
@@ -246,7 +247,7 @@ bool GameObjectModel::UpdatePosition()
 
     iPos = owner->GetPosition();
 
-    G3D::Matrix3 iRotation = G3D::Matrix3::fromEulerAnglesZYX(owner->GetOrientation(), 0, 0);
+    G3D::Matrix3 iRotation = owner->GetRotation().toRotationMatrix();
     iInvRot = iRotation.inverse();
     // transform bounding box:
     mdl_box = AABox(mdl_box.low() * iScale, mdl_box.high() * iScale);

src/common/Collision/Models/GameObjectModel.h

@@ -26,6 +26,11 @@
 #include "Define.h"
 #include <memory>
 
+namespace G3D
+{
+class Quat;
+}
+
 namespace VMAP
 {
     class WorldModel;
@@ -46,7 +51,7 @@ class TC_COMMON_API GameObjectModelOwnerBase
     virtual uint32 GetDisplayId() const = 0;
     virtual uint32 GetPhaseMask() const = 0;
     virtual G3D::Vector3 GetPosition() const = 0;
-    virtual float GetOrientation() const = 0;
+    virtual G3D::Quat GetRotation() const = 0;
     virtual float GetScale() const = 0;
     virtual void DebugVisualizeCorner(G3D::Vector3 const& /*corner*/) const = 0;
 };

src/server/game/Entities/GameObject/GameObject.cpp

@@ -2859,7 +2859,7 @@ class GameObjectModelOwnerImpl : public GameObjectModelOwnerBase
     uint32 GetDisplayId() const override { return _owner->GetDisplayId(); }
     uint32 GetPhaseMask() const override { return _owner->GetPhaseMask(); }
     G3D::Vector3 GetPosition() const override { return G3D::Vector3(_owner->GetPositionX(), _owner->GetPositionY(), _owner->GetPositionZ()); }
-    float GetOrientation() const override { return _owner->GetOrientation(); }
+    G3D::Quat GetRotation() const override { return G3D::Quat(_owner->GetLocalRotation().x, _owner->GetLocalRotation().y, _owner->GetLocalRotation().z, _owner->GetLocalRotation().w); }
     float GetScale() const override { return _owner->GetObjectScale(); }
     void DebugVisualizeCorner(G3D::Vector3 const& corner) const override { const_cast<GameObject*>(_owner)->SummonCreature(1, corner.x, corner.y, corner.z, 0, TEMPSUMMON_MANUAL_DESPAWN); }