LocText Deprecation

[superware]

Hello,

Using {lex:LocText Value, Suffix=:} shows a 'LocTextExt' is obsolete ... please use lex:Loc instead warning all over the project, yet Loc doesn't support the very useful and easy to use Suffix property.

Any thoughts?

[Karnah]

Hi, @superware.
We just ignored this warning and still use LocText, because it is much simpler than other options.

About other options:
Loc supports Converter and it is very flexible. For example:

{lex:Loc Value, Converter={lex:ToUpperConverter}}

For Suffix you can use StringFormatConverter. We did our own IValueConverter implementation:

public object? Convert(object? value, Type targetType, object? parameter, CultureInfo culture)
{
    var formatString = parameter as string;
    if (string.IsNullOrEmpty(formatString))
        return null;

    return string.Format(culture, formatString, value);
}

So, you can put formatString to ConverterParameter:

{lex:Loc Value, Converter={c:StringFormatConverter}, ConverterParameter='{}Prefix{0}Postfix'}}

[Karnah]

@konne, what do you think? Maybe it's better to remove Obsolette attribute for LocText?

[superware]

BTW, I've just found myself using {lex:LocText Item_n, FormatSegment1='1'} where the translated string is "Item #{0}"... why are FormatSegmentX string and not object?

Is there a reason for not merging all these useful features into a unified lex:Loc?