Skip to content

Commit 69e804c

Browse files
Bump eslint-plugin-react-hooks from 5.2.0 to 7.0.1 (#253)
* Bump eslint-plugin-react-hooks from 5.2.0 to 7.0.1 Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 5.2.0 to 7.0.1. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/packages/eslint-plugin-react-hooks/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks) --- updated-dependencies: - dependency-name: eslint-plugin-react-hooks dependency-version: 7.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * remove unnecessary react effect caught by new linter --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ann 杏 Kilzer <akilzer@gmail.com>
1 parent f132349 commit 69e804c

3 files changed

Lines changed: 56 additions & 19 deletions

File tree

package-lock.json

Lines changed: 52 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"all-contributors-cli": "6.26.1",
5656
"eslint": "9.37.0",
5757
"eslint-plugin-react": "7.37.5",
58-
"eslint-plugin-react-hooks": "5.2.0",
58+
"eslint-plugin-react-hooks": "7.0.1",
5959
"eslint-plugin-react-refresh": "0.4.6",
6060
"globals": "^16.4.0",
6161
"husky": "9.1.7",

src/components/TeamMemberCard/TeamMemberCard.tsx

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { FC, useEffect, useState } from 'react'
1+
import { FC } from 'react'
22
import Card from '@mui/material/Card'
33
import CardContent from '@mui/material/CardContent'
44
import CardMedia from '@mui/material/CardMedia'
@@ -12,20 +12,10 @@ interface TeamMemberCardProps {
1212
}
1313

1414
const TeamMemberCard: FC<TeamMemberCardProps> = ({ member }) => {
15-
const [name, setName] = useState(member.nameEN)
16-
const [title, setTitle] = useState(member.titleEN)
17-
1815
const i18n = getI18n()
1916

20-
useEffect(() => {
21-
if (i18n.language === 'en') {
22-
setName(member.nameEN)
23-
setTitle(member.titleEN)
24-
} else if (i18n.language === 'ja') {
25-
setName(member.nameJA || member.nameEN)
26-
setTitle(member.titleJA || member.titleEN)
27-
}
28-
}, [member, i18n.language])
17+
const name = i18n.language === 'ja' ? (member.nameJA || member.nameEN) : member.nameEN
18+
const title = i18n.language === 'ja' ? (member.titleJA || member.titleEN) : member.titleEN
2919

3020
return <OptionalLinkWrapper url={member.url}>
3121
<Card sx={{ height: 450, width: 300 }} aria-label="team-member-card">

0 commit comments

Comments
 (0)