Remove File Type filter (DLL/EXE/Config/Resource/Other)

Remove the file type filter controls, getFileTypeCategory() function,
__configExts__/__resourceExts__ constants, data-ext attribute from
row generation, and all related tests. The diff detail and importance
filters remain.

Note: dotnet is unavailable in this environment; tests could not be
run locally.

https://claude.ai/code/session_01VHEe12W2fkQZ7xneXy8Wry

Author: claude

FolderDiffIL4DotNet.Tests/Services/HtmlReportGenerateServiceTests.cs

@@ -1678,11 +1678,6 @@ public void GenerateDiffReportHtml_ContainsFilterBar()
             Assert.Contains("id=\"filter-imp-high\"", html);
             Assert.Contains("id=\"filter-imp-medium\"", html);
             Assert.Contains("id=\"filter-imp-low\"", html);
-            Assert.Contains("id=\"filter-ft-dll\"", html);
-            Assert.Contains("id=\"filter-ft-exe\"", html);
-            Assert.Contains("id=\"filter-ft-config\"", html);
-            Assert.Contains("id=\"filter-ft-resource\"", html);
-            Assert.Contains("id=\"filter-ft-other\"", html);
             Assert.Contains("id=\"filter-unchecked\"", html);
             Assert.Contains("id=\"filter-search\"", html);
             Assert.Contains("applyFilters()", html);
@@ -1728,23 +1723,6 @@ public void GenerateDiffReportHtml_FileRowsHaveDataSectionAttribute()
             Assert.Contains("data-section=\"add\"", html);
         }
 
-        [Fact]
-        public void GenerateDiffReportHtml_FileRowsHaveDataExtAttribute()
-        {
-            // Arrange / テスト準備
-            var (oldDir, newDir, reportDir) = MakeDirs("data-ext");
-            File.WriteAllText(Path.Combine(newDir, "new.dll"), "new-content");
-            var config = CreateConfig();
-            _resultLists.AddAddedFileAbsolutePath(Path.Combine(newDir, "new.dll"));
-
-            _service.GenerateDiffReportHtml(CreateReportContext(oldDir, newDir, reportDir, config));
-            var html = File.ReadAllText(Path.Combine(reportDir, HtmlReportGenerateService.DIFF_REPORT_HTML_FILE_NAME));
-
-            // Assert: data-ext attribute with correct extension
-            // 正しい拡張子の data-ext 属性を検証
-            Assert.Contains("data-ext=\".dll\"", html);
-        }
-
         [Fact]
         public void GenerateDiffReportHtml_ModifiedRowsWithImportance_HaveDataImportanceAttribute()
         {

JsTests/diff_report.test.js

@@ -106,7 +106,6 @@ describe('collectState', () => {
     loadScript({
       bodyHtml: `
         <input type="checkbox" id="filter-imp-high" checked>
-        <input type="checkbox" id="filter-ft-dll" checked>
         <input type="text" id="filter-search" value="test">
         <input type="checkbox" id="chk-real" checked>
       `,
@@ -115,7 +114,6 @@ describe('collectState', () => {
 
     const state = window.collectState();
     expect(state).not.toHaveProperty('filter-imp-high');
-    expect(state).not.toHaveProperty('filter-ft-dll');
     expect(state).not.toHaveProperty('filter-search');
     expect(state['chk-real']).toBe(true);
   });
@@ -162,57 +160,20 @@ describe('autoSave', () => {
   });
 });
 
-// ─── getFileTypeCategory ─────────────────────────────────────────────────────
-describe('getFileTypeCategory', () => {
-  beforeEach(() => loadScript());
-
-  const cases = [
-    ['.dll', 'dll'],
-    ['.DLL', 'dll'],
-    ['.exe', 'exe'],
-    ['.EXE', 'exe'],
-    ['.json', 'config'],
-    ['.xml', 'config'],
-    ['.config', 'config'],
-    ['.yaml', 'config'],
-    ['.yml', 'config'],
-    ['.csproj', 'config'],
-    ['.sln', 'config'],
-    ['.resx', 'resource'],
-    ['.png', 'resource'],
-    ['.ico', 'resource'],
-    ['.ttf', 'resource'],
-    ['.txt', 'other'],
-    ['.cs', 'other'],
-    ['', 'other'],
-    [null, 'other'],
-    [undefined, 'other'],
-  ];
-
-  test.each(cases)('getFileTypeCategory(%s) returns %s', (ext, expected) => {
-    expect(window.getFileTypeCategory(ext)).toBe(expected);
-  });
-});
-
 // ─── applyFilters ────────────────────────────────────────────────────────────
 describe('applyFilters', () => {
   function loadFilterEnv(rows) {
     const filterBar = `
       <input type="checkbox" id="filter-imp-high" checked>
       <input type="checkbox" id="filter-imp-medium" checked>
       <input type="checkbox" id="filter-imp-low" checked>
-      <input type="checkbox" id="filter-ft-dll" checked>
-      <input type="checkbox" id="filter-ft-exe" checked>
-      <input type="checkbox" id="filter-ft-config" checked>
-      <input type="checkbox" id="filter-ft-resource" checked>
-      <input type="checkbox" id="filter-ft-other" checked>
       <input type="checkbox" id="filter-unchecked">
       <input type="text" id="filter-search" value="">
       <span id="save-status"></span>
     `;
 
     const tableRows = rows.map(r =>
-      `<tr data-section="${r.section}" data-ext="${r.ext}" ${r.importance ? 'data-importance="' + r.importance + '"' : ''}>
+      `<tr data-section="${r.section}" ${r.importance ? 'data-importance="' + r.importance + '"' : ''} ${r.diff ? 'data-diff="' + r.diff + '"' : ''}>
         <td><input type="checkbox" id="chk-${r.id}" ${r.checked ? 'checked' : ''}></td>
         <td><span class="path-text">${r.path}</span></td>
       </tr>`
@@ -224,26 +185,10 @@ describe('applyFilters', () => {
     fireDOMContentLoaded();
   }
 
-  test('hides rows by file type when filter unchecked', () => {
-    loadFilterEnv([
-      { id: '1', section: 'modified', ext: '.dll', path: 'lib/a.dll' },
-      { id: '2', section: 'modified', ext: '.exe', path: 'bin/b.exe' },
-      { id: '3', section: 'modified', ext: '.json', path: 'cfg/c.json' },
-    ]);
-
-    document.getElementById('filter-ft-dll').checked = false;
-    window.applyFilters();
-
-    const rows = document.querySelectorAll('tr[data-section]');
-    expect(rows[0].classList.contains('filter-hidden')).toBe(true);
-    expect(rows[1].classList.contains('filter-hidden')).toBe(false);
-    expect(rows[2].classList.contains('filter-hidden')).toBe(false);
-  });
-
   test('hides rows by importance when filter unchecked', () => {
     loadFilterEnv([
-      { id: '1', section: 'modified', ext: '.dll', importance: 'High', path: 'a.dll' },
-      { id: '2', section: 'modified', ext: '.dll', importance: 'Low', path: 'b.dll' },
+      { id: '1', section: 'modified', importance: 'High', path: 'a.dll' },
+      { id: '2', section: 'modified', importance: 'Low', path: 'b.dll' },
     ]);
 
     document.getElementById('filter-imp-low').checked = false;
@@ -256,7 +201,7 @@ describe('applyFilters', () => {
 
   test('importance filter does not hide rows without data-importance', () => {
     loadFilterEnv([
-      { id: '1', section: 'unchanged', ext: '.dll', path: 'unchanged.dll' },
+      { id: '1', section: 'unchanged', path: 'unchanged.dll' },
     ]);
 
     // Uncheck all importance filters
@@ -272,8 +217,8 @@ describe('applyFilters', () => {
 
   test('filters by search text against path (case-insensitive)', () => {
     loadFilterEnv([
-      { id: '1', section: 'modified', ext: '.dll', path: 'src/MyApp.dll' },
-      { id: '2', section: 'modified', ext: '.dll', path: 'src/Other.dll' },
+      { id: '1', section: 'modified', path: 'src/MyApp.dll' },
+      { id: '2', section: 'modified', path: 'src/Other.dll' },
     ]);
 
     document.getElementById('filter-search').value = 'myapp';
@@ -286,8 +231,8 @@ describe('applyFilters', () => {
 
   test('unchecked-only filter shows only unchecked rows', () => {
     loadFilterEnv([
-      { id: '1', section: 'modified', ext: '.dll', path: 'a.dll', checked: true },
-      { id: '2', section: 'modified', ext: '.dll', path: 'b.dll', checked: false },
+      { id: '1', section: 'modified', path: 'a.dll', checked: true },
+      { id: '2', section: 'modified', path: 'b.dll', checked: false },
     ]);
 
     document.getElementById('filter-unchecked').checked = true;
@@ -304,16 +249,11 @@ describe('applyFilters', () => {
         <input type="checkbox" id="filter-imp-high" checked>
         <input type="checkbox" id="filter-imp-medium" checked>
         <input type="checkbox" id="filter-imp-low" checked>
-        <input type="checkbox" id="filter-ft-dll" checked>
-        <input type="checkbox" id="filter-ft-exe" checked>
-        <input type="checkbox" id="filter-ft-config" checked>
-        <input type="checkbox" id="filter-ft-resource" checked>
-        <input type="checkbox" id="filter-ft-other">
         <input type="checkbox" id="filter-unchecked">
         <input type="text" id="filter-search">
         <span id="save-status"></span>
         <table><tbody>
-          <tr data-section="modified" data-ext=".txt"><td><span class="path-text">readme.txt</span></td></tr>
+          <tr data-section="modified"><td><span class="path-text">readme.txt</span></td></tr>
           <tr class="diff-row"><td>diff content here</td></tr>
         </tbody></table>
       `,
@@ -328,9 +268,9 @@ describe('applyFilters', () => {
 
   test('when all filters checked, no rows are hidden', () => {
     loadFilterEnv([
-      { id: '1', section: 'modified', ext: '.dll', importance: 'High', path: 'a.dll' },
-      { id: '2', section: 'modified', ext: '.exe', importance: 'Low', path: 'b.exe' },
-      { id: '3', section: 'unchanged', ext: '.json', path: 'c.json' },
+      { id: '1', section: 'modified', importance: 'High', path: 'a.dll' },
+      { id: '2', section: 'modified', importance: 'Low', path: 'b.exe' },
+      { id: '3', section: 'unchanged', path: 'c.json' },
     ]);
 
     window.applyFilters();
@@ -348,11 +288,6 @@ describe('resetFilters', () => {
         <input type="checkbox" id="filter-imp-high">
         <input type="checkbox" id="filter-imp-medium" checked>
         <input type="checkbox" id="filter-imp-low" checked>
-        <input type="checkbox" id="filter-ft-dll">
-        <input type="checkbox" id="filter-ft-exe" checked>
-        <input type="checkbox" id="filter-ft-config" checked>
-        <input type="checkbox" id="filter-ft-resource" checked>
-        <input type="checkbox" id="filter-ft-other" checked>
         <input type="checkbox" id="filter-unchecked" checked>
         <input type="text" id="filter-search" value="some query">
         <span id="save-status"></span>
@@ -363,7 +298,6 @@ describe('resetFilters', () => {
     window.resetFilters();
 
     expect(document.getElementById('filter-imp-high').checked).toBe(true);
-    expect(document.getElementById('filter-ft-dll').checked).toBe(true);
     expect(document.getElementById('filter-unchecked').checked).toBe(false);
     expect(document.getElementById('filter-search').value).toBe('');
   });

Services/HtmlReport/HtmlReportGenerateService.Helpers.cs

@@ -57,12 +57,11 @@ private static void AppendFileRow(
             string reasonId = $"reason_{sectionPrefix}_{idx}";
             string notesId  = $"notes_{sectionPrefix}_{idx}";
             int recordNo    = idx + 1;
-            string ext = System.IO.Path.GetExtension(path).ToLowerInvariant();
             string impAttr = string.IsNullOrEmpty(importance) ? "" : $" data-importance=\"{HtmlEncode(importance)}\"";
             // Normalize diff detail to category for filtering / フィルタリング用に diff detail をカテゴリに正規化
             string diffCat = NormalizeDiffCategory(col6);
             string diffAttr = string.IsNullOrEmpty(diffCat) ? "" : $" data-diff=\"{diffCat}\"";
-            sb.AppendLine($"<tr data-section=\"{sectionPrefix}\" data-ext=\"{HtmlEncode(ext)}\"{impAttr}{diffAttr}>");
+            sb.AppendLine($"<tr data-section=\"{sectionPrefix}\"{impAttr}{diffAttr}>");
             sb.AppendLine($"  <td class=\"col-no\">{recordNo}</td>");
             sb.AppendLine($"  <td class=\"col-cb\"><input type=\"checkbox\" id=\"{cbId}\"></td>");
             sb.AppendLine($"  <td class=\"col-reason\"><input type=\"text\" id=\"{reasonId}\"></td>");

Services/HtmlReport/diff_report.js

@@ -48,7 +48,7 @@
     document.body.appendChild(vi);
   });
 
-  var __filterIds__ = ['filter-diff-sha256match','filter-diff-sha256mismatch','filter-diff-ilmatch','filter-diff-ilmismatch','filter-diff-textmatch','filter-diff-textmismatch','filter-imp-high','filter-imp-medium','filter-imp-low','filter-ft-dll','filter-ft-exe','filter-ft-config','filter-ft-resource','filter-ft-other','filter-unchecked','filter-search'];
+  var __filterIds__ = ['filter-diff-sha256match','filter-diff-sha256mismatch','filter-diff-ilmatch','filter-diff-ilmismatch','filter-diff-textmatch','filter-diff-textmismatch','filter-imp-high','filter-imp-medium','filter-imp-low','filter-unchecked','filter-search'];
   function collectState() {
     var s = {};
     document.querySelectorAll('input[id], textarea[id]').forEach(function(el) {
@@ -349,20 +349,9 @@
   }
 
   // ── Filtering ──────────────────────────────────────────────────────────
-  var __configExts__  = ['.json','.xml','.config','.yaml','.yml','.ini','.toml','.env','.props','.targets','.csproj','.vbproj','.fsproj','.sln'];
-  var __resourceExts__ = ['.resx','.resources','.png','.jpg','.jpeg','.ico','.svg','.gif','.bmp','.wav','.mp3','.ttf','.woff','.woff2','.eot'];
-  function getFileTypeCategory(ext) {
-    if (!ext) return 'other';
-    ext = ext.toLowerCase();
-    if (ext === '.dll') return 'dll';
-    if (ext === '.exe') return 'exe';
-    if (__configExts__.indexOf(ext) >= 0) return 'config';
-    if (__resourceExts__.indexOf(ext) >= 0) return 'resource';
-    return 'other';
-  }
   function applyFilters() {
     var impHigh    = document.getElementById('filter-imp-high');
-    // If any element is missing (e.g. reviewed mode), skip
+    // If any element is missing (e.g. reviewed mode), skip / 要素がない場合（レビュー済みモード等）スキップ
     if (!impHigh) return;
 
     // Diff detail filter (6 individual values) / Diff Detail フィルター（6個別値）
@@ -375,16 +364,13 @@
       TextMismatch:   document.getElementById('filter-diff-textmismatch').checked
     };
     var impFilter  = { High: impHigh.checked, Medium: document.getElementById('filter-imp-medium').checked, Low: document.getElementById('filter-imp-low').checked };
-    var ftDll      = document.getElementById('filter-ft-dll');
-    var ftFilter   = { dll: ftDll.checked, exe: document.getElementById('filter-ft-exe').checked, config: document.getElementById('filter-ft-config').checked, resource: document.getElementById('filter-ft-resource').checked, other: document.getElementById('filter-ft-other').checked };
     var onlyUnchecked = document.getElementById('filter-unchecked').checked;
     var searchEl   = document.getElementById('filter-search');
     var searchText = (searchEl.value || '').toLowerCase().trim();
 
-    // All checked = no filtering for that category
+    // All checked = no filtering for that category / 全チェック時はフィルタリングなし
     var diffActive = !(diffFilter.SHA256Match && diffFilter.SHA256Mismatch && diffFilter.ILMatch && diffFilter.ILMismatch && diffFilter.TextMatch && diffFilter.TextMismatch);
     var impActive  = !(impFilter.High && impFilter.Medium && impFilter.Low);
-    var ftActive   = !(ftFilter.dll && ftFilter.exe && ftFilter.config && ftFilter.resource && ftFilter.other);
 
     document.querySelectorAll('tbody > tr[data-section]').forEach(function(tr) {
       var show = true;
@@ -395,12 +381,6 @@
           if (!diffFilter[diff]) show = false;
         }
       }
-      // File type filter
-      if (show && ftActive) {
-        var ext = tr.getAttribute('data-ext') || '';
-        var cat = getFileTypeCategory(ext);
-        if (!ftFilter[cat]) show = false;
-      }
       // Importance filter (only for rows with importance)
       if (show && impActive) {
         var imp = tr.getAttribute('data-importance');

Services/HtmlReportGenerateService.cs

@@ -140,16 +140,6 @@ private string BuildHtml(
             sb.AppendLine("</div>");
             sb.AppendLine("</div>"); // end .filter-tables
 
-            // File Type filter row / File Type フィルター行
-            sb.AppendLine("<div class=\"ctrl-filter-row\">");
-            sb.AppendLine("  <label class=\"filter-label\">" + HtmlEncode("File Type") + ":</label>");
-            sb.AppendLine("  <label class=\"filter-chip\"><input type=\"checkbox\" id=\"filter-ft-dll\" checked onchange=\"applyFilters()\"> DLL</label>");
-            sb.AppendLine("  <label class=\"filter-chip\"><input type=\"checkbox\" id=\"filter-ft-exe\" checked onchange=\"applyFilters()\"> EXE</label>");
-            sb.AppendLine("  <label class=\"filter-chip\"><input type=\"checkbox\" id=\"filter-ft-config\" checked onchange=\"applyFilters()\"> Config</label>");
-            sb.AppendLine("  <label class=\"filter-chip\"><input type=\"checkbox\" id=\"filter-ft-resource\" checked onchange=\"applyFilters()\"> Resource</label>");
-            sb.AppendLine("  <label class=\"filter-chip\"><input type=\"checkbox\" id=\"filter-ft-other\" checked onchange=\"applyFilters()\"> " + HtmlEncode("Other") + "</label>");
-            sb.AppendLine("</div>");
-
             // Search + Unchecked only row / 検索 + 未チェックのみ行
             sb.AppendLine("<div class=\"ctrl-filter-row\">");
             sb.AppendLine("  <label class=\"filter-chip\"><input type=\"checkbox\" id=\"filter-unchecked\" onchange=\"applyFilters()\"> " + HtmlEncode("Unchecked only") + "</label>");

doc/DEVELOPER_GUIDE.md

@@ -155,7 +155,6 @@ The HTML report includes a client-side filter bar that allows users to narrow do
 
 ### JavaScript ([`diff_report.js`](../Services/HtmlReport/diff_report.js))
 
-- `getFileTypeCategory(ext)` — maps file extensions to categories (`dll`, `exe`, `config`, `resource`, `other`).
 - `applyFilters()` — reads all filter controls and applies `filter-hidden` / `filter-hidden-parent` CSS classes to rows.
 - `resetFilters()` — restores all checkboxes and clears the search box.
 - `__filterIds__` — array of filter input IDs excluded from `collectState()` / localStorage auto-save.
@@ -951,7 +950,6 @@ HTML レポートには、複数の条件でファイル行を絞り込めるク
 
 ### JavaScript（[`diff_report.js`](../Services/HtmlReport/diff_report.js)）
 
-- `getFileTypeCategory(ext)` — ファイル拡張子をカテゴリ（`dll`、`exe`、`config`、`resource`、`other`）にマッピング。
 - `applyFilters()` — すべてのフィルタコントロールを読み取り、行に `filter-hidden` / `filter-hidden-parent` CSS クラスを適用。
 - `resetFilters()` — すべてのチェックボックスを復元し、検索ボックスをクリア。
 - `__filterIds__` — `collectState()` / localStorage 自動保存から除外されるフィルタ入力 ID の配列。