Skip to content

Commit a51d665

Browse files
committed
Fix semantic changes consistency and remove code emphasis from Status cells
- Fix src/Service.dll: Warnings section now has same semantic changes as Modified Files (was showing only 2 entries vs 46 in Modified Files) - Remove <code> tags from Status column body cells ([ + ]/[ - ]/[ * ]) per user request — background color is sufficient emphasis - Verify all files appearing in both Modified Files and Warnings sections have consistent inline content https://claude.ai/code/session_01Sh7FCwgc4muABUcE6XXmWK
1 parent 6011f91 commit a51d665

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

FolderDiffIL4DotNet.Tests/Services/HtmlReportGenerateServiceTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -896,7 +896,7 @@ public void GenerateDiffReportHtml_AssemblySemanticChanges_KindAccessModifiersUs
896896
Assert.Contains("<code>Method</code>", html); // Kind
897897
Assert.Contains("<code>public</code>", html); // Access
898898
Assert.Contains("<code>virtual</code>", html); // Modifiers
899-
Assert.Contains("style=\"background:#e3f2fd\"><code>[ * ]</code>", html); // Status cell with blue bg
899+
Assert.Contains("style=\"background:#e3f2fd\">[ * ]", html); // Status cell with blue bg (no code emphasis)
900900
Assert.Contains("<code>Changed</code>", html); // Body
901901
}
902902

Services/HtmlReport/HtmlReportGenerateService.Sections.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ private void AppendAssemblySemanticChangesRow(
416416
string changeMarker = ChangeToMarker(e.Change);
417417
string statusBg = ChangeToStatusBg(e.Change);
418418
string statusStyle = statusBg.Length > 0 ? $" style=\"background:{statusBg}\"" : "";
419-
contentBuilder.AppendLine($"{trOpen}<td class=\"sc-col-cb\"><input type=\"checkbox\" id=\"{cbId}\"></td><td>{classTd}</td><td>{baseTypeTd}</td><td{statusStyle}><code>{changeMarker}</code></td><td><code>{HtmlEncode(e.MemberKind)}</code></td><td>{accessTd}</td><td>{modifiersTd}</td><td>{HtmlEncode(e.MemberType)}</td><td>{HtmlEncode(e.MemberName)}</td><td>{HtmlEncode(e.ReturnType)}</td><td>{HtmlEncode(e.Parameters)}</td><td>{bodyTd}</td></tr>");
419+
contentBuilder.AppendLine($"{trOpen}<td class=\"sc-col-cb\"><input type=\"checkbox\" id=\"{cbId}\"></td><td>{classTd}</td><td>{baseTypeTd}</td><td{statusStyle}>{changeMarker}</td><td><code>{HtmlEncode(e.MemberKind)}</code></td><td>{accessTd}</td><td>{modifiersTd}</td><td>{HtmlEncode(e.MemberType)}</td><td>{HtmlEncode(e.MemberName)}</td><td>{HtmlEncode(e.ReturnType)}</td><td>{HtmlEncode(e.Parameters)}</td><td>{bodyTd}</td></tr>");
420420
scRowIdx++;
421421
}
422422
contentBuilder.AppendLine("</tbody></table>");
@@ -483,7 +483,7 @@ private static void AppendSummaryCountTable(StringBuilder sb, AssemblySemanticCh
483483
string trOpen = isCont ? "<tr class=\"group-cont\">" : "<tr>";
484484
string cntStatusBg = ChangeToStatusBg(change);
485485
string cntStatusStyle = cntStatusBg.Length > 0 ? $" style=\"background:{cntStatusBg}\"" : "";
486-
sb.AppendLine($"{trOpen}<td>{classTd}</td><td{cntStatusStyle}><code>{ChangeToMarker(change)}</code></td><td>{count}</td></tr>");
486+
sb.AppendLine($"{trOpen}<td>{classTd}</td><td{cntStatusStyle}>{ChangeToMarker(change)}</td><td>{count}</td></tr>");
487487
}
488488
sb.AppendLine("</tbody></table>");
489489
}

0 commit comments

Comments
 (0)