Address issue-draft summary review findings (#5058)

Author: Widthdom

TESTING_GUIDE.md

@@ -20,7 +20,7 @@ Use the full suite by default. Use targeted filters only while iterating locally
 ## Test Stack
 
 - `WorkspaceCheckTruncationIssue5055Tests` owns the bounded `workspace_check` list contract. Keep zero, below-limit, exact-limit, and over-limit coverage for all six categories, plus the 1260/20/1240 example and one shared filesystem fixture for raw JSON, list-only projection, compact output, byte-budget trimming, deterministic order, and human sample labeling.
-- Recipe issue-draft summary coverage in `QueryCommandRunnerSearchTests` keeps the dedicated compact DTO separate from full draft bodies, asserts returned/total/omitted row cardinality (including `count == drafts.length`), measures the complete UTF-8 document with multibyte paths and its final newline, verifies whole-row truncation and typed `E028` audit identity, and preserves the full-output contract.
+- Recipe issue-draft summary coverage in `QueryCommandRunnerSearchTests` keeps the dedicated compact DTO separate from full draft bodies, asserts returned/total/omitted row cardinality (including `count == drafts.length` and positive queries hidden by `--total-limit`), preserves pre-limit evidence-path counts with authority/lower-bound metadata, measures the complete UTF-8 document with multibyte paths and its final newline, verifies whole-row truncation and typed `E028` audit identity, and preserves the full-output contract.
 - Marker-gate reference coverage keeps cross-language positive syntax in `ReferenceExtractorMarkerGateTests.cs`, with dedicated GraphQL/HTML/Markdown and XAML/XML cases proving that markerless continuation lines still advance parser state. `ReferenceExtractorPerformanceBudgetTests` owns three complementary regressions: Kotlin infix detection must not enumerate a large known-name set, Docker instruction classification must allocate nothing and scale with the instruction prefix rather than irrelevant line length, and warmed C#/Java/Kotlin markerless-decoy extraction must produce no references while staying below 24 MiB of measured allocations and the 3-second primary-target runaway guard. Keep the broad allocation/time guards on `net8.0`; keep the focused positive and state-preservation tests cross-target.
 - Framework: xUnit
 - Target frameworks: `net8.0` and `net9.0`
@@ -1017,7 +1017,7 @@ dotnet test --filter "FullyQualifiedName~GitHelperTests"
 ## テストスタック
 
 - `WorkspaceCheckTruncationIssue5055Tests` は上限付き `workspace_check` 一覧の契約を担当します。6カテゴリすべての0件・上限未満・上限一致・上限超過、1260/20/1240 の例、および raw JSON、一覧単独 projection、compact 出力、byte budget による短縮、決定的順序、human 向け sample 表示を1つの共有 filesystem fixture で検証する coverage を維持してください。
-- `QueryCommandRunnerSearchTests` の recipe issue-draft summary coverage は、専用 compact DTO を完全版 draft body から分離し、返却 / total / omitted row の cardinality（`count == drafts.length` を含む）、multibyte path と末尾改行を含む UTF-8 document 全体の計測、完全な row 単位の truncation、型付き `E028` の audit identity、完全版 output contract の維持を検証します。
+- `QueryCommandRunnerSearchTests` の recipe issue-draft summary coverage は、専用 compact DTO を完全版 draft body から分離し、返却 / total / omitted row の cardinality（`count == drafts.length` と `--total-limit` に隠れた positive query を含む）、limit 適用前の evidence-path count と authority / lower-bound metadata の維持、multibyte path と末尾改行を含む UTF-8 document 全体の計測、完全な row 単位の truncation、型付き `E028` の audit identity、完全版 output contract の維持を検証します。
 - marker gate の reference coverage は、言語横断の正しい構文を `ReferenceExtractorMarkerGateTests.cs` にまとめ、GraphQL/HTML/Markdown と XAML/XML の専用 case で marker のない継続行でも parser state が更新されることを固定します。`ReferenceExtractorPerformanceBudgetTests` は相補的な3つの回帰契約を所有します。Kotlin infix 検出では大きな既知名集合を列挙しないこと、Docker instruction 分類では allocation が0で無関係な行長ではなく instruction prefix に応じて scale すること、warmup 済みの C#/Java/Kotlin markerless-decoy 抽出では reference が0件のまま計測 allocation 24 MiB未満かつ primary target の3秒 runaway guard内であることを検証します。広い allocation / time guard は `net8.0` に限定し、focused な正例とstate維持のテストはcross-targetのままにしてください。
 - フレームワーク: xUnit
 - メインのテストプロジェクト: `tests/CodeIndex.Tests/CodeIndex.Tests.csproj`

USER_GUIDE.md

@@ -1677,7 +1677,10 @@ to recipe issue-draft export when agents only need compact top-level metadata:
 the output uses a dedicated summary contract with one compact row per positive
 query instead of embedding full issue bodies, source rows, or repeated recipe
 metadata. Each row reports counts, severity/confidence, labels, at most five
-evidence paths with explicit omission counts, and a full-detail replay command.
+evidence paths with explicit omission counts, count authority/lower bounds when
+the candidate window is incomplete, and a full-detail replay command. Positive
+queries remain represented even when `--total-limit` leaves them with zero
+returned results; the uncapped recovery command omits that run-wide limit.
 The root reports total/returned/omitted row counts, whether the total is
 authoritative, `query_freshness`, and an uncapped `recovery_command`. Combine it
 with `--max-json-bytes <n>` to measure the complete UTF-8 document (including
@@ -5147,8 +5150,10 @@ JSON summary には `confidence` と `minimum_score` が出力されます。dra
 top-level metadata だけを必要とする場合は、recipe issue-draft export に `--summary-only` を追加します。
 この出力は専用の summary contract を使い、完全な Issue body、source row、query ごとに重複する
 recipe metadata を埋め込まず、結果がある query ごとに compact な row を1件出力します。各 row は
-count、severity / confidence、label、最大5件の evidence path と明示的な省略件数、完全な詳細を取得する
-replay command を返します。root は total / returned / omitted row count、total が authoritative か、
+count、severity / confidence、label、最大5件の evidence path、明示的な省略件数、candidate window が
+不完全な場合の count authority / lower bound、完全な詳細を取得する replay command を返します。
+`--total-limit` により返却 result が0件になった positive query も row として保持し、上限なしの recovery
+command からは run 全体のその limit を除外します。root は total / returned / omitted row count、total が authoritative か、
 `query_freshness`、上限なしの `recovery_command` を返します。`--max-json-bytes <n>` を併用すると、末尾の
 改行を含む UTF-8 document 全体を計測し、上限に収まる完全な row だけを保持します。row 0件の envelope
 さえ収まらない場合は `E028` で fail-closed にし、retry guidance でも実行元の `search` または `audit`

changelog.d/unreleased/5058.fixed.md

@@ -14,8 +14,8 @@ affected:
 
 ## English
 
-- **Recipe issue-draft summaries now fit bounded automation payloads (#5058; follow-up to #4064, #4118, and #4308)** — `--summary-only` now uses a dedicated compact contract with one whole row per positive query, bounded evidence paths, explicit omission and total-authority metadata, full-detail replay commands, and an uncapped recovery command. `--max-json-bytes` measures the complete UTF-8 document including its final newline, truncates only at row boundaries, and preserves the invoked `search` or `audit` identity in `E028` guidance; full issue-draft output remains unchanged.
+- **Recipe issue-draft summaries now fit bounded automation payloads (#5058; follow-up to #4064, #4118, and #4308)** — `--summary-only` now uses a dedicated compact contract with one whole row per positive query, including queries hidden by `--total-limit`, bounded evidence paths with truthful authority/lower-bound metadata, full-detail replay commands, and an uncapped recovery command. `--max-json-bytes` measures the complete UTF-8 document including its final newline, truncates only at row boundaries, and preserves the invoked `search` or `audit` identity in `E028` guidance; full issue-draft output remains unchanged.
 
 ## 日本語
 
-- **recipe issue-draft summary が automation の上限付き payload に収まるよう修正しました (#5058、#4064、#4118、#4308 の follow-up)** — `--summary-only` は、結果がある query ごとの完全な row、上限付き evidence path、明示的な省略件数と total の authority metadata、完全な詳細を取得する replay command、上限なしの recovery command を持つ専用 compact contract を使います。`--max-json-bytes` は末尾改行を含む UTF-8 document 全体を計測し、row 境界だけで truncate し、`E028` guidance でも実行元の `search` または `audit` identity を維持します。完全版 issue-draft output は変更しません。
+- **recipe issue-draft summary が automation の上限付き payload に収まるよう修正しました (#5058、#4064、#4118、#4308 の follow-up)** — `--summary-only` は、`--total-limit` に隠れた query を含む結果がある query ごとの完全な row、正確な authority / lower-bound metadata を伴う上限付き evidence path、完全な詳細を取得する replay command、上限なしの recovery command を持つ専用 compact contract を使います。`--max-json-bytes` は末尾改行を含む UTF-8 document 全体を計測し、row 境界だけで truncate し、`E028` guidance でも実行元の `search` または `audit` identity を維持します。完全版 issue-draft output は変更しません。

src/CodeIndex/Cli/QueryCommandRunner.SearchRecipes.cs

@@ -1916,7 +1916,7 @@ private static int WriteSearchRecipeIssueDraftSummary(
     {
         const int evidencePathLimit = 5;
         var summaries = queryResults
-            .Where(queryResult => queryResult.Count > 0)
+            .Where(queryResult => queryResult.MinimumMatchedCount > 0)
             .Select(queryResult =>
             {
                 var labels = queryResult.RecommendedLabels
@@ -1926,12 +1926,9 @@ private static int WriteSearchRecipeIssueDraftSummary(
                     .Distinct(StringComparer.OrdinalIgnoreCase)
                     .OrderBy(label => label, StringComparer.OrdinalIgnoreCase)
                     .ToList();
-                var fileCount = queryResult.Results
-                    .Select(result => result.Path)
-                    .Where(path => !string.IsNullOrWhiteSpace(path))
-                    .Distinct(StringComparer.Ordinal)
-                    .Count();
-                var evidencePaths = queryResult.TopFiles
+                var fileCount = queryResult.SummaryEvidencePathCount;
+                var fileCountAuthoritative = queryResult.SummaryEvidencePathCountAuthoritative;
+                var evidencePaths = queryResult.SummaryEvidencePaths
                     .Take(evidencePathLimit)
                     .ToList();
                 var omittedEvidencePathCount = Math.Max(0, fileCount - evidencePaths.Count);
@@ -1941,17 +1938,23 @@ private static int WriteSearchRecipeIssueDraftSummary(
                     BuildSearchIssueDraftTitle(recipe, queryResult),
                     queryResult.Count,
                     fileCount,
+                    fileCountAuthoritative,
+                    fileCountAuthoritative ? null : fileCount,
                     queryResult.MinimumMatchedCount,
                     queryResult.MinimumOmittedResultCount,
                     queryResult.Truncated,
                     evidencePaths,
                     fileCount,
+                    fileCountAuthoritative,
+                    fileCountAuthoritative ? null : fileCount,
                     evidencePaths.Count,
                     omittedEvidencePathCount,
-                    omittedEvidencePathCount > 0,
+                    fileCountAuthoritative,
+                    fileCountAuthoritative ? null : omittedEvidencePathCount,
+                    omittedEvidencePathCount > 0 || !fileCountAuthoritative,
                     labels,
                     queryResult.Severity,
-                    GetSearchRecipeConfidence(queryResult.Count),
+                    GetSearchRecipeConfidence(queryResult.MinimumMatchedCount),
                     queryResult.NextCursor,
                     BuildSearchRecipeReplayCommand(
                         recipe,
@@ -1971,7 +1974,8 @@ private static int WriteSearchRecipeIssueDraftSummary(
             recipe,
             options,
             summaryOnly: true,
-            includeMaxJsonBytes: false);
+            includeMaxJsonBytes: false,
+            includeTotalLimit: false);
         var totalCount = summaries.Count;
         var totalCountAuthoritative = !hasFailures;
         string? envelopeJson = null;
@@ -2324,6 +2328,12 @@ private static List<SearchRecipeQueryResultJsonResult> CollectSearchRecipeQueryR
                 results = ApplySearchRecipeFileRejectQueries(reader, results, options, recipeQuery);
                 var rows = BuildSearchDisplayRows(results, options, exact, recipeQuery.Query, rawFtsOverride: false, recipeQuery: recipeQuery);
                 rows = ApplySearchRecipeSemanticFilter(reader, options, recipeQuery, rows);
+                var summaryEvidencePaths = BuildSearchRecipeTopFiles(rows);
+                var summaryEvidencePathCount = rows
+                    .Select(row => row.Result.Path)
+                    .Where(path => !string.IsNullOrWhiteSpace(path))
+                    .Distinct(StringComparer.Ordinal)
+                    .Count();
                 var outputSelection = ApplySearchOutputSelection(rows, options, resultLimit, sourceTotalAuthoritative);
                 rows = outputSelection.Rows;
                 if (includeAuditClassifications)
@@ -2376,7 +2386,12 @@ private static List<SearchRecipeQueryResultJsonResult> CollectSearchRecipeQueryR
                     outputSelection.Returned,
                     outputSelection.SelectorOmittedCount,
                     outputSelection.LimitOmittedCount,
-                    outputSelection.Selectors));
+                    outputSelection.Selectors)
+                {
+                    SummaryEvidencePaths = summaryEvidencePaths,
+                    SummaryEvidencePathCount = summaryEvidencePathCount,
+                    SummaryEvidencePathCountAuthoritative = sourceTotalAuthoritative,
+                });
                 if (freshnessContext != null)
                 {
                     freshnessObservations.Add(SuccessfulSearchQueryObservation(
@@ -5881,7 +5896,8 @@ private static string BuildSearchRecipeReplayCommand(
         QueryCommandOptions options,
         string? queryName = null,
         bool summaryOnly = false,
-        bool includeMaxJsonBytes = true)
+        bool includeMaxJsonBytes = true,
+        bool includeTotalLimit = true)
     {
         var recipeSelector = string.IsNullOrWhiteSpace(queryName)
             ? recipe.Name
@@ -5942,7 +5958,7 @@ private static string BuildSearchRecipeReplayCommand(
             AddReplayValueOption(args, "--exclude-origin", origin);
         foreach (var kind in options.ResultKinds)
             AddReplayValueOption(args, "--result-kind", kind);
-        if (options.TotalLimit.HasValue)
+        if (includeTotalLimit && options.TotalLimit.HasValue)
             AddReplayValueOption(args, "--total-limit", options.TotalLimit.Value.ToString(CultureInfo.InvariantCulture));
         AddReplayValueOption(args, "--snippet-lines", options.SnippetLines.ToString(CultureInfo.InvariantCulture));
         AddReplayValueOption(args, "--snippet-focus", FormatSearchSnippetFocusMode(options.SnippetFocus));

src/CodeIndex/Cli/SearchAuditRecipes.cs

@@ -4718,7 +4718,17 @@ internal sealed record SearchRecipeQueryResultJsonResult(
     [property: JsonPropertyName("returned")] int Returned,
     [property: JsonPropertyName("selector_omitted_count")] int SelectorOmittedCount,
     [property: JsonPropertyName("limit_omitted_count")] int LimitOmittedCount,
-    [property: JsonPropertyName("selectors")] List<SearchRowSelectorJsonResult> Selectors);
+    [property: JsonPropertyName("selectors")] List<SearchRowSelectorJsonResult> Selectors)
+{
+    [JsonIgnore]
+    public List<SearchRecipeTopFileJsonResult> SummaryEvidencePaths { get; init; } = [];
+
+    [JsonIgnore]
+    public int SummaryEvidencePathCount { get; init; }
+
+    [JsonIgnore]
+    public bool SummaryEvidencePathCountAuthoritative { get; init; }
+}
 
 internal sealed record SearchNamedBatchCountSummaryRunJsonResult(
     [property: JsonPropertyName("api_version")] string ApiVersion,
@@ -4919,13 +4929,25 @@ internal sealed record SearchIssueDraftSummaryJsonResult(
     [property: JsonPropertyName("title")] string Title,
     [property: JsonPropertyName("result_count")] int ResultCount,
     [property: JsonPropertyName("file_count")] int FileCount,
+    [property: JsonPropertyName("file_count_authoritative")] bool FileCountAuthoritative,
+    [property: JsonPropertyName("file_count_lower_bound")]
+    [property: JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
+    int? FileCountLowerBound,
     [property: JsonPropertyName("minimum_matched_count")] int MinimumMatchedCount,
     [property: JsonPropertyName("minimum_omitted_result_count")] int MinimumOmittedResultCount,
     [property: JsonPropertyName("results_truncated")] bool ResultsTruncated,
     [property: JsonPropertyName("evidence_paths")] List<SearchRecipeTopFileJsonResult> EvidencePaths,
     [property: JsonPropertyName("evidence_path_count")] int EvidencePathCount,
+    [property: JsonPropertyName("evidence_path_count_authoritative")] bool EvidencePathCountAuthoritative,
+    [property: JsonPropertyName("evidence_path_count_lower_bound")]
+    [property: JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
+    int? EvidencePathCountLowerBound,
     [property: JsonPropertyName("evidence_paths_returned_count")] int EvidencePathsReturnedCount,
     [property: JsonPropertyName("evidence_paths_omitted_count")] int EvidencePathsOmittedCount,
+    [property: JsonPropertyName("evidence_paths_omitted_count_authoritative")] bool EvidencePathsOmittedCountAuthoritative,
+    [property: JsonPropertyName("evidence_paths_omitted_count_lower_bound")]
+    [property: JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
+    int? EvidencePathsOmittedCountLowerBound,
     [property: JsonPropertyName("evidence_paths_truncated")] bool EvidencePathsTruncated,
     [property: JsonPropertyName("labels")] List<string> Labels,
     [property: JsonPropertyName("severity")] string Severity,