fix(core): share registry singleton state

Author: xuefei1313

packages/vrender-core/__tests__/unit/common/contribution-provider.test.ts

@@ -104,6 +104,16 @@ describe('contribution-provider', () => {
     expect(spy2).toHaveBeenCalledTimes(1);
   });
 
+  test('ContributionStore should use realm-level shared state for duplicated ESM entry evaluation', () => {
+    const id = Symbol('shared-svc');
+    const cache = createProviderCache({ isBound: jest.fn(() => false), getAll: jest.fn(() => []) }, id);
+    const state = (globalThis as any)[Symbol.for('@visactor/vrender-core/contribution-store-state')];
+
+    expect(state).toBeDefined();
+    expect(state.store).toBe(ContributionStore.store);
+    expect(state.store.get(id)?.has(cache)).toBe(true);
+  });
+
   test('bindContributionProviderNoSingletonScope does not call inSingletonScope', () => {
     let factory: DynamicValueFactory | undefined;
 

packages/vrender-core/__tests__/unit/entries/runtime-installer.test.ts

@@ -1,8 +1,15 @@
 import { application } from '../../../src/application';
-import { AppContext, configureRuntimeApplicationForApp } from '../../../src/entries';
+import { AppContext, configureRuntimeApplicationForApp, getRuntimeInstallerBindingContext } from '../../../src/entries';
 import { DefaultIncrementalDrawContribution } from '../../../src/render/contributions/render/incremental-draw-contribution';
 
 describe('runtime installer', () => {
+  test('runtime installer should use realm-level shared state for duplicated ESM entry evaluation', () => {
+    const state = (globalThis as any)[Symbol.for('@visactor/vrender-core/runtime-installer-state')];
+
+    expect(state).toBeDefined();
+    expect(state.runtimeInstallerContext).toBe(getRuntimeInstallerBindingContext());
+  });
+
   test('configureRuntimeApplicationForApp should configure an app-scoped incremental draw contribution factory', () => {
     const context = new AppContext();
     const app = {

packages/vrender-core/__tests__/unit/factory/factory.test.ts

@@ -8,7 +8,7 @@ import type {
   IWindow
 } from '../../../src/interface';
 import type { IGraphic, IGraphicAttribute } from '../../../src/interface/graphic';
-import { GraphicFactory, LayerFactory, StageFactory } from '../../../src/factory';
+import { Factory, GraphicFactory, LayerFactory, StageFactory } from '../../../src/factory';
 
 class StageStub {
   readonly params: Partial<IStageParams>;
@@ -41,6 +41,17 @@ class GraphicStub {
 }
 
 describe('factory module', () => {
+  test('Factory plugin registry should use realm-level shared state for duplicated ESM entry evaluation', () => {
+    class PluginStub {}
+
+    Factory.registerPlugin('unit-plugin', PluginStub);
+    const state = (globalThis as any)[Symbol.for('@visactor/vrender-core/factory-state')];
+
+    expect(state).toBeDefined();
+    expect(state.pluginClasses['unit-plugin']).toBe(PluginStub);
+    expect(Factory.getPlugin('unit-plugin')).toBe(PluginStub);
+  });
+
   test('StageFactory should create stage instances with forwarded params', () => {
     const factory = new StageFactory(StageStub as any);
     const params = { width: 320, height: 180 };

packages/vrender-core/__tests__/unit/graphic/graphic-factory-migration.test.ts

@@ -1,14 +1,29 @@
 import type { IRectGraphicAttribute } from '../../../src/interface';
 import { createGraphic, graphicCreator, registerGraphic } from '../../../src/graphic';
+import { Arc3d } from '../../../src/graphic/arc3d';
 import { DefaultGraphicService } from '../../../src/graphic/graphic-service/graphic-service';
+import { Group } from '../../../src/graphic/group';
 import { Rect } from '../../../src/graphic/rect';
+import { registerArc3dGraphic } from '../../../src/register/register-arc3d';
+import { registerGroupGraphic } from '../../../src/register/register-group';
 import { registerRectGraphic } from '../../../src/register/register-rect';
 
 class GraphicStub {
   constructor(public readonly attribute: Record<string, unknown>) {}
 }
 
 describe('graphic factory migration', () => {
+  test('graphic registry should use realm-level shared state for duplicated ESM entry evaluation', () => {
+    registerGraphic('realm-shared-stub', GraphicStub as any);
+
+    const registryState = (globalThis as any)[Symbol.for('@visactor/vrender-core/graphic-registry')];
+
+    expect(registryState).toBeDefined();
+    expect(registryState.graphicCreator).toBe(graphicCreator);
+    expect(registryState.graphicFactory.create('realm-shared-stub', { x: 1 })).toBeInstanceOf(GraphicStub);
+    expect(createGraphic('realm-shared-stub', { x: 2 })).toBeInstanceOf(GraphicStub);
+  });
+
   test('registerGraphic should register creators for createGraphic', () => {
     registerGraphic('unit-stub', GraphicStub as any);
 
@@ -37,6 +52,22 @@ describe('graphic factory migration', () => {
     expect((rect as Rect).attribute.width).toBe(100);
   });
 
+  test('registerGroupGraphic should enable createGraphic for group from a separate register entry', () => {
+    registerGroupGraphic();
+
+    const group = createGraphic('group', {});
+
+    expect(group).toBeInstanceOf(Group);
+  });
+
+  test('registerArc3dGraphic should enable createGraphic for arc3d from a separate register entry', () => {
+    registerArc3dGraphic();
+
+    const arc3d = createGraphic('arc3d', {});
+
+    expect(arc3d).toBeInstanceOf(Arc3d);
+  });
+
   test('DefaultGraphicService should default to the shared graphic creator adapter', () => {
     const service = new DefaultGraphicService();
 

packages/vrender-core/__tests__/unit/legacy/legacy-binding-context.test.ts

@@ -113,4 +113,14 @@ describe('legacy binding context', () => {
       expect(loadRenderContributions).toHaveBeenCalledTimes(1);
     });
   });
+
+  test('legacy bootstrap should use realm-level shared state for duplicated ESM entry evaluation', () => {
+    jest.isolateModules(() => {
+      const bootstrap = require('../../../src/legacy/bootstrap');
+      const state = (globalThis as any)[Symbol.for('@visactor/vrender-core/legacy-bootstrap-state')];
+
+      expect(state).toBeDefined();
+      expect(state.legacyBindingContext).toBe(bootstrap.getLegacyBindingContext());
+    });
+  });
 });

packages/vrender-core/__tests__/unit/modules/container-compatibility.test.ts

@@ -12,6 +12,14 @@ function readArtifact(relativePath: string) {
 }
 
 describe('vrender-core container compatibility', () => {
+  test('application should use realm-level shared state for duplicated ESM entry evaluation', () => {
+    const { application } = require(path.join(packageRoot, 'src/application'));
+    const state = (globalThis as any)[Symbol.for('@visactor/vrender-core/application-state')];
+
+    expect(state).toBeDefined();
+    expect(state.application).toBe(application);
+  });
+
   test('es artifacts should expose legacy container compatibility surface', () => {
     expect(readArtifact('es/modules.js')).toContain('export const container');
     expect(readArtifact('es/modules.d.ts')).toContain('container');

packages/vrender-core/__tests__/unit/public-subpath-exports.test.ts

@@ -19,6 +19,7 @@ type ExpectedSubpath = {
 
 const expectedExports: ExpectedSubpath[] = [
   { subpath: './graphic/creator', source: 'src/graphic/creator.ts' },
+  { subpath: './graphic/graphic-registry', source: 'src/graphic/graphic-registry.ts' },
   { subpath: './graphic/base', source: 'src/graphic/base.ts' },
   { subpath: './graphic/modules', source: 'src/graphic/modules.ts' },
   { subpath: './graphic/symbol', source: 'src/graphic/symbol.ts' },

packages/vrender-core/package.json

@@ -27,6 +27,7 @@
       "graphic/base": ["es/graphic/base.d.ts"],
       "graphic/builtin-symbol": ["es/graphic/builtin-symbol.d.ts"],
       "graphic/creator": ["es/graphic/creator.d.ts"],
+      "graphic/graphic-registry": ["es/graphic/graphic-registry.d.ts"],
       "graphic/group": ["es/graphic/group.d.ts"],
       "graphic/modules": ["es/graphic/modules.d.ts"],
       "graphic/symbol": ["es/graphic/symbol.d.ts"],
@@ -185,6 +186,11 @@
       "import": "./es/graphic/creator.js",
       "require": "./cjs/graphic/creator.js"
     },
+    "./graphic/graphic-registry": {
+      "types": "./es/graphic/graphic-registry.d.ts",
+      "import": "./es/graphic/graphic-registry.js",
+      "require": "./cjs/graphic/graphic-registry.js"
+    },
     "./graphic/group": {
       "types": "./es/graphic/group.d.ts",
       "import": "./es/graphic/group.js",

packages/vrender-core/src/application-state.ts

@@ -0,0 +1,58 @@
+import type { IGraphicUtil, ILayerService, ITransformUtil } from './interface/core';
+import type {
+  ICanvasFactory,
+  IContext2dFactory,
+  IGlobal,
+  IGraphicService,
+  ILayerHandlerContribution,
+  IPickerService,
+  IPluginService,
+  IRenderService,
+  IWindow,
+  IWindowHandlerContribution,
+  LayerMode
+} from './interface';
+import type { IDrawContribution } from './interface/render';
+
+export class Application {
+  global: IGlobal;
+  graphicUtil: IGraphicUtil;
+  graphicService: IGraphicService;
+  renderService: IRenderService;
+  renderServiceFactory?: () => IRenderService;
+  pluginService?: IPluginService;
+  pluginServiceFactory?: () => IPluginService;
+  pickerServiceFactory?: () => IPickerService;
+  windowFactory?: () => IWindow;
+  windowHandlerFactory?: (env: string) => IWindowHandlerContribution;
+  layerHandlerFactory?: (layerMode: LayerMode) => ILayerHandlerContribution;
+  incrementalDrawContributionFactory?: () => IDrawContribution;
+  canvasFactory?: (env: string) => ICanvasFactory | undefined;
+  context2dFactory?: (env: string) => IContext2dFactory | undefined;
+  transformUtil: ITransformUtil;
+  layerService: ILayerService;
+}
+
+export const APPLICATION_STATE_SYMBOL = Symbol.for('@visactor/vrender-core/application-state');
+
+export interface IApplicationState {
+  application: Application;
+}
+
+function createApplicationState(): IApplicationState {
+  return {
+    application: new Application()
+  };
+}
+
+export function getApplicationState(): IApplicationState {
+  const scope = globalThis as typeof globalThis & { [APPLICATION_STATE_SYMBOL]?: IApplicationState };
+
+  if (!scope[APPLICATION_STATE_SYMBOL]) {
+    scope[APPLICATION_STATE_SYMBOL] = createApplicationState();
+  }
+
+  return scope[APPLICATION_STATE_SYMBOL] as IApplicationState;
+}
+
+export const application = getApplicationState().application;

packages/vrender-core/src/application.ts

@@ -1,36 +1,2 @@
-import type { IGraphicUtil, ILayerService, ITransformUtil } from './interface/core';
-import type {
-  ICanvasFactory,
-  IContext2dFactory,
-  IGlobal,
-  IGraphicService,
-  ILayerHandlerContribution,
-  IPickerService,
-  IPluginService,
-  IRenderService,
-  IWindow,
-  IWindowHandlerContribution,
-  LayerMode
-} from './interface';
-import type { IDrawContribution } from './interface/render';
-
-export class Application {
-  global: IGlobal;
-  graphicUtil: IGraphicUtil;
-  graphicService: IGraphicService;
-  renderService: IRenderService;
-  renderServiceFactory?: () => IRenderService;
-  pluginService?: IPluginService;
-  pluginServiceFactory?: () => IPluginService;
-  pickerServiceFactory?: () => IPickerService;
-  windowFactory?: () => IWindow;
-  windowHandlerFactory?: (env: string) => IWindowHandlerContribution;
-  layerHandlerFactory?: (layerMode: LayerMode) => ILayerHandlerContribution;
-  incrementalDrawContributionFactory?: () => IDrawContribution;
-  canvasFactory?: (env: string) => ICanvasFactory | undefined;
-  context2dFactory?: (env: string) => IContext2dFactory | undefined;
-  transformUtil: ITransformUtil;
-  layerService: ILayerService;
-}
-
-export const application = new Application();
+export { application, Application, APPLICATION_STATE_SYMBOL, getApplicationState } from './application-state';
+export type { IApplicationState } from './application-state';