fix: unbind array trigger events on release

Author: dajiaohuang

packages/vchart/__tests__/unit/interaction/base-trigger.test.ts

@@ -0,0 +1,34 @@
+import { BaseTrigger } from '../../../src/interaction/triggers/base';
+import type { IBaseTriggerOptions, ITriggerEventHandler } from '../../../src/interaction/interface/trigger';
+
+class TestTrigger extends BaseTrigger<IBaseTriggerOptions> {
+  type = 'test';
+  readonly handler = jest.fn();
+
+  protected getEvents(): Array<{ type: string | string[]; handler: ITriggerEventHandler }> {
+    return [{ type: ['pointerdown', 'none', 'pointermove'], handler: this.handler }];
+  }
+}
+
+describe('BaseTrigger', () => {
+  it('unbinds every event in an array-valued trigger when released', () => {
+    const event = {
+      on: jest.fn(),
+      off: jest.fn(),
+      emit: jest.fn()
+    };
+    const trigger = new TestTrigger({ event, interaction: {} as IBaseTriggerOptions['interaction'] });
+
+    trigger.init();
+    trigger.release();
+
+    expect(event.on.mock.calls).toEqual([
+      ['pointerdown', trigger.handler],
+      ['pointermove', trigger.handler]
+    ]);
+    expect(event.off.mock.calls).toEqual([
+      ['pointerdown', trigger.handler],
+      ['pointermove', trigger.handler]
+    ]);
+  });
+});

packages/vchart/src/interaction/triggers/base.ts

@@ -102,7 +102,7 @@ export abstract class BaseTrigger<T extends IBaseTriggerOptions> implements ITri
         if (evt.type && evt.handler) {
           if (isArray(evt.type)) {
             evt.type.forEach(evtType => {
-              evtType && evtType !== 'none' && this.options.event.on(evtType, evt.handler);
+              evtType && evtType !== 'none' && this.options.event.off(evtType, evt.handler);
             });
           } else {
             evt.type !== 'none' && this.options.event.off(evt.type, evt.handler);