Skip to content
This repository was archived by the owner on Aug 9, 2020. It is now read-only.
This repository was archived by the owner on Aug 9, 2020. It is now read-only.

Fail to propagate result for certain case #52

Description

@dlackty

We're trying to integrate this library with Google SignIn, and however subscriber gets no result.

After investigation, we found that there's potential issue for this library. For Google SignIn, they use a SignInHubActivity, which presents a dialog then puts itself into pause state. Then when user click on the dialog option, it will set result and finish activity.

@Override public void onActivityPaused(Activity activity) {
liveActivityOrNull = null;
}

At this moment, RxActivityResult.activitiesLifecycle.getLiveActivity() returns null and thus breaks the expected subscription behavior.

Possibly related: #36
Possible fix: use getOLiveActivity instead

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions