Rear and Right directions of the pain compass are swapped

[dkenw]

What happened:

When I got shot from the back, the pain compass show the damage is from the right side, and vice versa.

See the code:

cs16-client/cl_dll/health.cpp

Lines 327 to 336 in d6916e6

	{
	if (side > EPSILON)
	m_fAttack[0] = max(m_fAttack[0], side);
	if (side < -EPSILON)
	m_fAttack[1] = max(m_fAttack[1], 0 - side );
	if (front > EPSILON)
	m_fAttack[2] = max(m_fAttack[2], front);
	if (front < -EPSILON)
	m_fAttack[3] = max(m_fAttack[3], 0 - front );
	}

The issue:

if (side < -EPSILON)
    m_fAttack[1] = ...; // Rear source written into RIGHT slot

if (front > EPSILON)
    m_fAttack[2] = ...; // Right source written into REAR slot

Actual attacker direction	Array slot written	Slot is rendered as	Result
Front	0	Front/top	Correct
Back	1	Right	Wrong
Right	2	Rear/bottom	Wrong
Left	3	Left	Correct

The solution you might want:

forwardDot = DotProduct (vecFrom, forward);
rightDot = DotProduct (vecFrom, right);

// ...

{
    if (forwardDot > EPSILON)
        m_fAttack[ATK_FRONT] = max(m_fAttack[ATK_FRONT], forwardDot);
    if (forwardDot < -EPSILON)
        m_fAttack[ATK_REAR] = max(m_fAttack[ATK_REAR], 0 - forwardDot );
    if (rightDot > EPSILON)
        m_fAttack[ATK_RIGHT] = max(m_fAttack[ATK_RIGHT], rightDot);
    if (rightDot < -EPSILON)
        m_fAttack[ATK_LEFT] = max(m_fAttack[ATK_LEFT], 0 - rightDot );
}

[a1batross]

If you have slop tokens to post a bugreport, you can have slop tokens to send a PR and provide a test.

[dkenw]

i wrote the report myself. solution is written by codex.
it's fine we can close it actually if u don't care.

[dkenw]

in fact, among this giant volume of low-quality issues in this github repo, i found a critical bug, spent my time to debug it, wrote a report diligently, included the culprit and a solution, yet receiving a not-quite-friendly message, is somewhat discouraging. i'm sorry if i offended you. i do appreciate your work in maintaining all these.

[a1batross]

Sorry, I just meant that if you found a bug and also provided a solution, you can as well send the patch directly, it's just makes everything much easier. But no, LLM written description of a bug doesn't make it easier to understand. It would've been much better if you tried to write in your own words.

I don't really remember why I decided to rework this code, honestly it should've been reverted to vanilla Half-Life.

[Velaron]

I am more a fan of this approach, I won't accept AI solutions into my projects because I feel like this is a spit into my soul. Generate Issues with AI all you want if they are unique and correct.

[dkenw]

guys the issue is hand-written. i even had wrong grammar in the first sentence. well, anyway