From e4a210b14c1920a6410dc16e562aaa6bfeeb8009 Mon Sep 17 00:00:00 2001 From: tarepan Date: Wed, 30 Apr 2025 08:52:36 +0000 Subject: [PATCH 1/3] refactor r.f. with ref --- .github/workflows/build-engine-package.yml | 2 +- Dockerfile | 2 +- pyproject.toml | 4 ++-- voicevox_engine/app/middlewares.py | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-engine-package.yml b/.github/workflows/build-engine-package.yml index 99ce159f4..dae3e661a 100644 --- a/.github/workflows/build-engine-package.yml +++ b/.github/workflows/build-engine-package.yml @@ -650,7 +650,7 @@ jobs: - name: Check out the repository uses: actions/checkout@v4 - - name: Change tag to this commit for refreshing the release # c.f. voicevox_engine#854 + - name: Change tag to this commit for refreshing the release # ref: voicevox_engine#854 run: | git tag -f ${{ needs.config.outputs.version }} git push -f --tag diff --git a/Dockerfile b/Dockerfile index 6fa708afa..d6a30bdee 100644 --- a/Dockerfile +++ b/Dockerfile @@ -187,7 +187,7 @@ WORKDIR /opt/voicevox_engine # ca-certificates: pyopenjtalk dictionary download # build-essential: pyopenjtalk local build -# ref: https://github.com/VOICEVOX/voicevox_engine/issues/770 +# ref: voicevox_engine#770 RUN <=4.0.1", "httpx>=0.28.1", # NOTE: required by fastapi.testclient.TestClient (fastapi-slim's unmanaged dependency) "mypy>=1.10.0", "pip-audit>=2.7.3", - "pip-licenses==5.0.0", # NOTE: must be specified exactly (c.f. #1281) + "pip-licenses==5.0.0", # NOTE: must be specified exactly (ref: voicevox_engine#1281) "pre-commit>=4.0.1", "pytest>=8.2.0", "ruff>=0.11.1", diff --git a/voicevox_engine/app/middlewares.py b/voicevox_engine/app/middlewares.py index d7a6a34ea..62752ec65 100644 --- a/voicevox_engine/app/middlewares.py +++ b/voicevox_engine/app/middlewares.py @@ -19,7 +19,7 @@ def configure_middlewares( """FastAPI のミドルウェアを設定する。""" # 未処理の例外が発生するとCORSMiddlewareが適用されない問題に対するワークアラウンド - # ref: https://github.com/VOICEVOX/voicevox_engine/issues/91 + # ref: voicevox_engine#91 async def global_execution_handler(request: Request, exc: Exception) -> Response: print_exception(exc) return JSONResponse( From f435896d67ccadf4a0564f5eb06bf45f3bc89881 Mon Sep 17 00:00:00 2001 From: tarepan Date: Thu, 1 May 2025 21:58:54 +0000 Subject: [PATCH 2/3] add issue URL instead of issue number --- .github/workflows/build-engine-package.yml | 2 +- Dockerfile | 2 +- pyproject.toml | 4 ++-- voicevox_engine/app/middlewares.py | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-engine-package.yml b/.github/workflows/build-engine-package.yml index dae3e661a..21a30afef 100644 --- a/.github/workflows/build-engine-package.yml +++ b/.github/workflows/build-engine-package.yml @@ -650,7 +650,7 @@ jobs: - name: Check out the repository uses: actions/checkout@v4 - - name: Change tag to this commit for refreshing the release # ref: voicevox_engine#854 + - name: Change tag to this commit for refreshing the release # ref: https://github.com/VOICEVOX/voicevox_engine/issues/854 run: | git tag -f ${{ needs.config.outputs.version }} git push -f --tag diff --git a/Dockerfile b/Dockerfile index d6a30bdee..6fa708afa 100644 --- a/Dockerfile +++ b/Dockerfile @@ -187,7 +187,7 @@ WORKDIR /opt/voicevox_engine # ca-certificates: pyopenjtalk dictionary download # build-essential: pyopenjtalk local build -# ref: voicevox_engine#770 +# ref: https://github.com/VOICEVOX/voicevox_engine/issues/770 RUN <=4.0.1", "httpx>=0.28.1", # NOTE: required by fastapi.testclient.TestClient (fastapi-slim's unmanaged dependency) "mypy>=1.10.0", "pip-audit>=2.7.3", - "pip-licenses==5.0.0", # NOTE: must be specified exactly (ref: voicevox_engine#1281) + "pip-licenses==5.0.0", # NOTE: must be specified exactly (ref: https://github.com/VOICEVOX/voicevox_engine/issues/1281) "pre-commit>=4.0.1", "pytest>=8.2.0", "ruff>=0.11.1", diff --git a/voicevox_engine/app/middlewares.py b/voicevox_engine/app/middlewares.py index 62752ec65..d7a6a34ea 100644 --- a/voicevox_engine/app/middlewares.py +++ b/voicevox_engine/app/middlewares.py @@ -19,7 +19,7 @@ def configure_middlewares( """FastAPI のミドルウェアを設定する。""" # 未処理の例外が発生するとCORSMiddlewareが適用されない問題に対するワークアラウンド - # ref: voicevox_engine#91 + # ref: https://github.com/VOICEVOX/voicevox_engine/issues/91 async def global_execution_handler(request: Request, exc: Exception) -> Response: print_exception(exc) return JSONResponse( From 4ccc7088d33756dd2ece71735f95ac7620c9e2c2 Mon Sep 17 00:00:00 2001 From: tarepan Date: Thu, 1 May 2025 22:00:04 +0000 Subject: [PATCH 3/3] fix cf with ref --- voicevox_engine/core/core_wrapper.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/voicevox_engine/core/core_wrapper.py b/voicevox_engine/core/core_wrapper.py index f593b1492..6b980ec9c 100644 --- a/voicevox_engine/core/core_wrapper.py +++ b/voicevox_engine/core/core_wrapper.py @@ -252,7 +252,7 @@ def _find_version_0_12_core_or_later(core_dir: Path) -> str | None: - コアライブラリの名前が CORENAME_DICT の定義に従っている の両方が真のときである。 - cf. https://github.com/VOICEVOX/voicevox_engine/issues/385 + ref: https://github.com/VOICEVOX/voicevox_engine/issues/385 """ if (core_dir / "metas.json").exists(): return None