Milestone 2 feedback

[lmguzman]

Great job with milestone 2!

I was able to install your package and your tests correctly came up with your functions!

Here are some things that I think you should improve:

• For binary search, if I give it a value outside of the list ( e.g. binary_search(8, [1,2,3,4,5,6])), why does it return position = 0? Shouldn’t it give position NA or something like that?

• I realize that your function specification is for a list of integers. Would it make sense to allow for NAs to be in your list?

• You should put that you only allow numbers until 1000 in your documentation.

[fwu03]

For binary search, instead of returning position=0 for a value outside of the list, now the function returns None (e.g. binary_search(8, [1,2,3,4,5,6]) => [False, 8, None])

[lmguzman]

I just wanted to add another comment. I ran your test files and for Test_find_prime all test passed as well as for flatten_list_prime.py. However, for test_binary_search.py I got some tests failing:

=================================== FAILURES ===================================
_________________________________ test_output __________________________________

def test_output():
    # assert return contain correct values
    assert binary_search.binary_search(3, [1,2,3,4]) == [True,3,2], "Assertion Failed, the output is wrong"
    # assert return contain correct values

  assert binary_search.binary_search(3, [1,2,4]) == [False,3,None], "Assertion Failed, the output is wrong"

E AssertionError: Assertion Failed, the output is wrong
E assert [False, 3, 0] == [False, 3, None]
E At index 2 diff: 0 != None
E Use -v to get the full diff

test_binary_search.py:30: AssertionError
====================== 1 failed, 2 passed in 0.15 seconds ======================

Make sure you fix this for your next milestone as I will be running the tests again.

Great job otherwise!

[fwu03]

This is because we updated the binary_search function yesterday according to your feedback before. To test the new function, you might need to update the package first by 'pip install --upgrade git+https://github.com/UBC-MDS/mlist_Python.git'. Thanks!