From d11f847013ffed1dbe9fb1a1ed260102e9491356 Mon Sep 17 00:00:00 2001 From: Ashwin Ramaswami Date: Tue, 4 Jun 2019 08:57:42 -0700 Subject: [PATCH 1/2] Update .travis.yml --- .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 698f8ea..4bf48a2 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,4 +2,5 @@ language: node_js node_js: - "8.9.3" script: - - npm test \ No newline at end of file + - npm test + - npm run build From 8ce4929032d74e15840b837b95f9142d24673dfe Mon Sep 17 00:00:00 2001 From: Ashwin Ramaswami Date: Tue, 4 Jun 2019 10:18:48 -0700 Subject: [PATCH 2/2] fix: upgrade typescript to fix CI Build --- package-lock.json | 6 +++--- package.json | 2 +- src/routes/user_resumes.ts | 2 +- src/services/file_actions.ts | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index 1bf3202..de683a3 100644 --- a/package-lock.json +++ b/package-lock.json @@ -7880,9 +7880,9 @@ } }, "typescript": { - "version": "2.9.2", - "resolved": "https://registry.npmjs.org/typescript/-/typescript-2.9.2.tgz", - "integrity": "sha512-Gr4p6nFNaoufRIY4NMdpQRNmgxVIGMs4Fcu/ujdYk3nAZqk7supzBE9idmvfZIlH/Cuj//dvi+019qEue9lV0w==" + "version": "3.5.1", + "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.5.1.tgz", + "integrity": "sha512-64HkdiRv1yYZsSe4xC1WVgamNigVYjlssIoaH2HcZF0+ijsk5YK2g0G34w9wJkze8+5ow4STd22AynfO6ZYYLw==" }, "uglify-js": { "version": "3.6.0", diff --git a/package.json b/package.json index afab618..c4a4ce5 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ "mongoose": "^5.4.1", "path": "^0.12.7", "request": "^2.83.0", - "typescript": "^2.9.2", + "typescript": "^3.5.1", "yamljs": "^0.3.0" }, "engines": { diff --git a/src/routes/user_resumes.ts b/src/routes/user_resumes.ts index 95604e0..3f23581 100644 --- a/src/routes/user_resumes.ts +++ b/src/routes/user_resumes.ts @@ -42,4 +42,4 @@ export function getUserResumes(req: Request, res: Response) { .catch(err => { return res.status(400).json(err); }) -}; \ No newline at end of file +}; diff --git a/src/services/file_actions.ts b/src/services/file_actions.ts index 3dcc003..a3fa3f6 100644 --- a/src/services/file_actions.ts +++ b/src/services/file_actions.ts @@ -1,4 +1,4 @@ -import AWS from "aws-sdk"; +import AWS, {S3} from "aws-sdk"; export async function uploadBase64Content(key, fileContent) { const contentType = fileContent.match(/data:([^;]+);/)[1]; @@ -43,5 +43,5 @@ export async function getFile(filePath) { if (err) { return reject(err); } resolve(data); }); - }); -} \ No newline at end of file + }) as Promise; +}