chore(ci): satisfy workspace clippy

Author: Travis-Gilbert

crates/rustyred-core/src/graph_store.rs

@@ -2125,7 +2125,7 @@ impl RedCoreGraphStore {
 
     fn should_snapshot_for(&self, txn_id: u64) -> bool {
         let interval = self.options.snapshot_interval_writes;
-        interval > 0 && txn_id > self.snapshot_txn_id && txn_id % interval == 0
+        interval > 0 && txn_id > self.snapshot_txn_id && txn_id.is_multiple_of(interval)
     }
 
     fn write_snapshot(&mut self) -> GraphStoreResult<()> {

crates/rustyred-server/src/graph_sync.rs

@@ -151,8 +151,9 @@ async fn handle_socket(state: AppState, tenant_id: String, room_id: String, sock
                         }
                     }
                     Message::Ping(payload) => {
-                        if sink.send(Message::Pong(payload)).await.is_err() {
-                            break;
+                        match sink.send(Message::Pong(payload)).await {
+                            Ok(()) => {}
+                            Err(_) => break,
                         }
                     }
                     Message::Close(_) => break,

crates/rustyred-server/src/memory.rs

@@ -144,8 +144,10 @@ pub struct RecallBody {
     #[serde(default)]
     pub include_low_fitness: bool,
     #[serde(default)]
+    #[allow(dead_code)]
     pub include_consolidation_sources: bool,
     #[serde(default)]
+    #[allow(dead_code)]
     pub consume_handoffs: bool,
 }
 
@@ -207,6 +209,7 @@ pub struct SelfArchiveBody {
     #[serde(default)]
     pub reason: Option<String>,
     #[serde(default)]
+    #[allow(dead_code)]
     pub actor: Option<String>,
 }
 
@@ -347,9 +350,7 @@ fn strip_code(input: &str) -> String {
                 }
                 j += 1;
             }
-            for _ in i..j {
-                out.push(b' ');
-            }
+            out.resize(out.len() + (j - i), b' ');
             i = j;
             continue;
         }
@@ -362,9 +363,7 @@ fn strip_code(input: &str) -> String {
             if j < bytes.len() && bytes[j] == b'`' {
                 j += 1;
             }
-            for _ in i..j {
-                out.push(b' ');
-            }
+            out.resize(out.len() + (j - i), b' ');
             i = j;
             continue;
         }
@@ -765,7 +764,7 @@ pub async fn memory_mentions_wait(
     let actor = body.actor.trim().to_string();
     let limit = body.limit.unwrap_or(20).min(200);
     let timeout = body.timeout_seconds.unwrap_or(30).min(120);
-    let interval_ms = ((body.interval_seconds.unwrap_or(1.0)).max(0.1).min(5.0) * 1000.0) as u64;
+    let interval_ms = ((body.interval_seconds.unwrap_or(1.0)).clamp(0.1, 5.0) * 1000.0) as u64;
 
     let started = std::time::Instant::now();
     let deadline = std::time::Duration::from_secs(timeout);
@@ -1207,7 +1206,7 @@ pub async fn memory_self_revise(
     let properties = Value::Object(props);
 
     // Use prior labels (preserves verb kind) plus marker.
-    let mut labels: Vec<String> = prior.labels.iter().cloned().collect();
+    let mut labels: Vec<String> = prior.labels.to_vec();
     if !labels.iter().any(|l| l == "MemoryAtom") {
         labels.insert(0, "MemoryAtom".to_string());
     }

crates/rustyred-server/src/state.rs

@@ -273,7 +273,7 @@ impl AppState {
             if let (Some(lat), Some(lon)) = (lat, lon) {
                 let _ = SpatialBackend::upsert(index.as_mut(), &node.id, lat, lon);
             } else {
-                let _ = SpatialBackend::remove(index.as_mut(), &node.id);
+                SpatialBackend::remove(index.as_mut(), &node.id);
             }
         }
     }

crates/rustyred-server/src/yjs_sync.rs

@@ -277,8 +277,9 @@ async fn handle_socket(
                         }
                     }
                     Message::Ping(payload) => {
-                        if sink.send(Message::Pong(payload)).await.is_err() {
-                            break;
+                        match sink.send(Message::Pong(payload)).await {
+                            Ok(()) => {}
+                            Err(_) => break,
                         }
                     }
                     Message::Close(_) => break,
@@ -457,6 +458,7 @@ impl ProvenanceSidecar {
     }
 
     /// Blame: which actor authored the item carrying this yrs `client_id`.
+    #[cfg(test)]
     pub(crate) fn writer_of(&self, client_id: u64) -> Option<&str> {
         self.clients.get(&client_id).map(|a| a.actor.as_str())
     }
@@ -482,8 +484,7 @@ mod tests {
     fn doc_text(doc: &Doc) -> String {
         let text = doc.get_or_insert_text("t");
         let txn = doc.transact();
-        let content = text.get_string(&txn);
-        content
+        text.get_string(&txn)
     }
 
     #[test]