fix: address review feedback for theme option

Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionMobile/sessions/69a37858-a158-4559-8c34-b2ef103ca511

Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>

Author: Copilot

TransactionProcessor.Mobile.BusinessLogic/Database/DatabaseContext.cs

@@ -38,10 +38,10 @@ public async Task<Int64> CreateTransaction(TransactionRecord transactionRecord)
             return SQLite3.LastInsertRowid(this.Connection.Handle);
         }
 
-        public async Task<String?> GetApplicationOption(String optionName) {
+        public Task<String?> GetApplicationOption(String optionName) {
             ApplicationOption option = this.Connection.Find<ApplicationOption>(optionName);
 
-            return option?.OptionValue;
+            return Task.FromResult(option?.OptionValue);
         }
 
         public async Task<List<LogMessage>> GetLogMessages(Int32 batchSize, Boolean isTrainingMode) {
@@ -90,12 +90,14 @@ public async Task RemoveUploadedMessages(List<LogMessage> logMessagesToRemove) {
             }
         }
 
-        public async Task SaveApplicationOption(String optionName,
-                                                String optionValue) {
+        public Task SaveApplicationOption(String optionName,
+                                         String optionValue) {
             this.Connection.InsertOrReplace(new ApplicationOption {
                                                                   OptionName = optionName,
                                                                   OptionValue = optionValue
                                                               });
+
+            return Task.CompletedTask;
         }
 
         public async Task UpdateTransaction(TransactionRecord transactionRecord) {

TransactionProcessor.Mobile/App.xaml.cs

@@ -9,6 +9,7 @@
 using TransactionProcessor.Mobile.Pages.Transactions.MobileTopup;
 using TransactionProcessor.Mobile.Pages.Transactions.Voucher;
 using TransactionProcessor.Mobile.BusinessLogic.UIServices;
+using Microsoft.Maui.ApplicationModel;
 
 #if ANDROID
 using AndroidX.Core.View;
@@ -51,7 +52,7 @@ void ApplyAutomationIdMapping<TVirtualView, THandlerInterface>(
         public App(IApplicationThemeService applicationThemeService)
         {
             InitializeComponent();
-            applicationThemeService.ApplyConfiguredTheme().GetAwaiter().GetResult();
+            MainThread.BeginInvokeOnMainThread(async () => await applicationThemeService.ApplyConfiguredTheme());
 
 #if ANDROID
             ApplyAutomationIdMapping(ViewHandler.ViewMapper);