fixes :|

Author: StuartFerguson

Shared.EventStore/Aggregate/DomainEventFactory.cs

@@ -48,7 +48,7 @@ public DomainEvent CreateDomainEvent(Guid aggregateId, ResolvedEvent @event)
         }
 
         if (eventType == null)
-            throw new ApplicationException($"Failed to find a domain event with type {@event.Event.EventType}");
+            throw new ArgumentException(($"Failed to find a domain event with type {@event.Event.EventType}");
 
         DomainEvent domainEvent = (DomainEvent)JsonConvert.DeserializeObject(json, eventType);
 

Shared.EventStore/SubscriptionWorker/SubscriptionRepository.cs

@@ -81,19 +81,19 @@ public async Task<PersistentSubscriptions> GetSubscriptions(Boolean forceRefresh
              this.WriteTrace("Full refresh on repository");
 
              Result<List<PersistentSubscriptionInfo>> list = await this.GetAllSubscriptions(cancellationToken);
+             if (list.IsFailed) {
+                 this.WriteTrace(list.Message);
+                 return this.Subscriptions;
+             }
 
-            // TODO: Log failure?
-            this.FullRefreshHits++;
+             this.FullRefreshHits++;
 
              this.Subscriptions = this.Subscriptions.Update(list.Data);
 
              this.WriteTrace($"Full refresh on repository completed {this.FullRefreshHits}");
 
              return this.Subscriptions;
          }
-         catch (Exception ex) {
-             throw new ApplicationException($"Unable to get persistent subscription list. [{ex}]");
-         }
          finally {
              Interlocked.Exchange(ref this.running, 0);
          }