Prevent duplicate file lines

Author: StuartFerguson

FileProcessor.BusinessLogic/RequestHandlers/FileRequestHandler.cs

@@ -297,7 +297,7 @@ private async Task<Unit> ProcessFile(Guid fileId,
 
                     foreach (String fileLine in fileLines)
                     {
-                        fileAggregate.AddFileLine(fileLine);
+                        fileAggregate.AddFileLine(fileLine.Trim());
                     }
 
                     await this.FileAggregateRepository.SaveChanges(fileAggregate, cancellationToken);

FileProcessor.FileAggregate.Tests/FileAggregateTests.cs

@@ -94,6 +94,22 @@ public void FileAggregate_AddFileLine_FileLineAdded()
             fileDetails.ProcessingSummary.IgnoredLines.ShouldBe(0);
         }
 
+        [Fact]
+        public void FileAggregate_AddFileLine_AddDuplicateLine_FileLineIsNotAddedAdded()
+        {
+            FileAggregate fileAggregate = FileAggregate.Create(TestData.FileId);
+            fileAggregate.CreateFile(TestData.FileImportLogId, TestData.EstateId, TestData.MerchantId, TestData.UserId,
+                                     TestData.FileProfileId, TestData.FileLocation, TestData.FileUploadedDateTime);
+            fileAggregate.AddFileLine(TestData.FileLine);
+            fileAggregate.AddFileLine(TestData.FileLine);
+
+            FileDetails fileDetails = fileAggregate.GetFile();
+            fileDetails.FileLines.ShouldNotBeNull();
+            fileDetails.FileLines.ShouldNotBeEmpty();
+            fileDetails.FileLines.ShouldHaveSingleItem();
+            fileDetails.FileLines.Count.ShouldBe(1);
+        }
+
         [Fact]
         public void FileAggregate_AddFileLine_FileNotCreated_FileLineAdded()
         {

FileProcessor.FileAggregate/FileAggregate.cs

@@ -267,6 +267,12 @@ public void AddFileLine(String fileLine)
                 throw new InvalidOperationException($"File Id {this.AggregateId} has not been uploaded yet");
             }
 
+            Boolean lineAlreadyExists = this.FileLines.Any(f => f.LineData == fileLine);
+
+            // We already have this line so just return
+            if (lineAlreadyExists)
+                return;
+
             Int32 lineNumber = this.FileLines.Count + 1;
 
             FileLineAddedEvent fileLineAddedEvent = new FileLineAddedEvent(this.AggregateId, this.EstateId, lineNumber, fileLine);