fix: various clang tidy reports

Author: Green-Sky

audio/src/backend/openal.cpp

@@ -115,16 +115,12 @@ OpenAL::OpenAL(IAudioSettings& _settings)
     captureTimer.setInterval(AUDIO_FRAME_DURATION / 2);
     captureTimer.setSingleShot(false);
     captureTimer.moveToThread(audioThread);
-    // TODO for Qt 5.6+: use qOverload
-    connect(audioThread, &QThread::started, &captureTimer,
-            static_cast<void (QTimer::*)(void)>(&QTimer::start));
+    connect(audioThread, &QThread::started, &captureTimer, qOverload<>(&QTimer::start));
 
     cleanupTimer.setInterval(1000);
     cleanupTimer.setSingleShot(false);
     connect(&cleanupTimer, &QTimer::timeout, this, &OpenAL::cleanupSound);
-    // TODO for Qt 5.6+: use qOverload
-    connect(audioThread, &QThread::started, &cleanupTimer,
-            static_cast<void (QTimer::*)(void)>(&QTimer::start));
+    connect(audioThread, &QThread::started, &cleanupTimer, qOverload<>(&QTimer::start));
 
     audioThread->start();
 }

src/chatlog/chatwidget.cpp

@@ -1228,9 +1228,8 @@ void ChatWidget::onRenderFinished()
     // invalidated. This could be improved in the future but for now I  do not
     // believe this is a serious usage impediment. Chats can be exported if a
     // user really needs more than 300 messages to be copied
-    if (chatLineStorage->find(selFirstRow) == chatLineStorage->end()
-        || chatLineStorage->find(selLastRow) == chatLineStorage->end()
-        || chatLineStorage->find(selClickedRow) == chatLineStorage->end()) {
+    if (!chatLineStorage->contains(selFirstRow) || !chatLineStorage->contains(selLastRow)
+        || !chatLineStorage->contains(selClickedRow)) {
         // FIXME: Segfault when selecting while scrolling down
         clearSelection();
     }

src/video/camerasource.cpp

@@ -97,6 +97,7 @@ Q_LOGGING_CATEGORY(ffmpegDeviceAudioOutput, "ffmpeg.device.audio_output")
 Q_LOGGING_CATEGORY(ffmpegDeviceAudioInput, "ffmpeg.device.audio_input")
 Q_LOGGING_CATEGORY(ffmpegDeviceOutput, "ffmpeg.device.output")
 Q_LOGGING_CATEGORY(ffmpegDeviceInput, "ffmpeg.device.input")
+Q_LOGGING_CATEGORY(ffmpegHWDevice, "ffmpeg.hwdevice")
 } // namespace logcat
 
 const QLoggingCategory& (*avLogCategory(const AVClass* avc))()
@@ -141,6 +142,10 @@ const QLoggingCategory& (*avLogCategory(const AVClass* avc))()
         return logcat::ffmpegDeviceOutput;
     case AV_CLASS_CATEGORY_DEVICE_INPUT:
         return logcat::ffmpegDeviceInput;
+#if LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(60, 2, 100)
+    case AV_CLASS_CATEGORY_HWDEVICE:
+        return logcat::ffmpegHWDevice;
+#endif
     }
     return logcat::ffmpeg;
 }

src/widget/form/settingswidget.cpp

@@ -45,17 +45,20 @@ SettingsWidget::SettingsWidget(UpdateCheck& updateCheck, IAudioControl& audio, C
     settingsWidgets->setTabPosition(QTabWidget::North);
     bodyLayout->addWidget(settingsWidgets.get());
 
-    std::unique_ptr<GeneralForm> gfrm(new GeneralForm(settings, style));
+    std::unique_ptr<GeneralForm> gfrm = std::make_unique<GeneralForm>(settings, style);
     connect(gfrm.get(), &GeneralForm::updateIcons, parent, &Widget::updateIcons);
 
-    std::unique_ptr<UserInterfaceForm> uifrm(new UserInterfaceForm(smileyPack, settings, style, this));
-    std::unique_ptr<PrivacyForm> pfrm(new PrivacyForm(core, settings, style, profile));
+    std::unique_ptr<UserInterfaceForm> uifrm =
+        std::make_unique<UserInterfaceForm>(smileyPack, settings, style, this);
+    std::unique_ptr<PrivacyForm> pfrm = std::make_unique<PrivacyForm>(core, settings, style, profile);
     connect(pfrm.get(), &PrivacyForm::clearAllReceipts, parent, &Widget::clearAllReceipts);
 
-    auto* rawAvfrm = new AVForm(audio, coreAV, cameraSource, audioSettings, videoSettings, style);
-    std::unique_ptr<AVForm> avfrm(rawAvfrm);
-    std::unique_ptr<AdvancedForm> expfrm(new AdvancedForm(settings, style, messageBoxManager));
-    std::unique_ptr<AboutForm> abtfrm(new AboutForm(updateCheck, core->getSelfId().toString(), style));
+    std::unique_ptr<AVForm> avfrm =
+        std::make_unique<AVForm>(audio, coreAV, cameraSource, audioSettings, videoSettings, style);
+    std::unique_ptr<AdvancedForm> expfrm =
+        std::make_unique<AdvancedForm>(settings, style, messageBoxManager);
+    std::unique_ptr<AboutForm> abtfrm =
+        std::make_unique<AboutForm>(updateCheck, core->getSelfId().toString(), style);
 
     connect(&updateCheck, &UpdateCheck::updateAvailable, this, &SettingsWidget::onUpdateAvailable);