chore: portfolio alignment + MainUiState refactor

Brings the Linux client in line with the rest of the TinkerNorth portfolio
(dish-android, dish-mac, satellite) on tooling, CI, hook semantics, and
data-flow shape, and ships a release pipeline.

Tooling
- .clang-format / .clang-tidy replaced with the canonical TinkerNorth
  rulesets (md5 matches dish-android + satellite verbatim). Source tree
  reformatted; ctest still 100% pass (29/29).
- .githooks/pre-commit flipped from --dry-run --Werror to autofix-and-
  re-stage, matching the dish-mac and satellite hooks.

CI (.github/workflows/linux-ci.yml)
- clang-format pinned to 22.1.4 via pipx (was unpinned apt — Ubuntu
  24.04's v18 disagreed with brew's v22 on braced-init lists).

AppModel refactor — MainUiState
- Replaces the slotsChanged / connectionsChanged / pairingTargetChanged
  trio with one canonical stateChanged() signal carrying a MainUiState
  slice (slotList, connections, pairingTarget). Mirrors dish-android's
  MainViewModel + dish-mac's @published shape so the three clients all
  expose state the same way.
- MainWindow subscribes once and reads model->state().{slotList,
  connections, pairingTarget}. Pairing dialog flow now driven from
  state-change observation instead of a separate signal.
- Field is named slotList not slots because Qt's moc reserves that token.

Release pipeline (new .github/workflows/release.yml)
- Tag-triggered (v*) build of release binary on ubuntu-22.04 (matches
  oldest LTS we want to support at runtime).
- Packages as both .deb (for Debian/Ubuntu) and AppImage (for everyone
  else), uploaded to GitHub Releases.

Documentation
- CONTRIBUTING.md updated to reflect autofix hook semantics.

Author: emir-hasanbegovic

.clang-format

@@ -1,45 +1,62 @@
----
-Language: Cpp
-BasedOnStyle: Google
+# TinkerNorth — canonical clang-format configuration.
+# This exact file is shared by satellite, dish-android (JNI), dish-linux,
+# and dish-mac (any C/C++ source). Pinned to clang-format 22.1.4 in CI;
+# older versions may produce small diffs on braced-init lists.
+# Run:  clang-format -i <files>
+
+BasedOnStyle: LLVM
+
+# Indentation
 IndentWidth: 4
 TabWidth: 4
 UseTab: Never
-ColumnLimit: 110
-AccessModifierOffset: -4
+IndentCaseLabels: false
+NamespaceIndentation: None
+
+# Braces
+BreakBeforeBraces: Attach            # K&R: opening brace on same line
+AllowShortBlocksOnASingleLine: Always
+AllowShortFunctionsOnASingleLine: All
+AllowShortIfStatementsOnASingleLine: WithoutElse
+AllowShortLoopsOnASingleLine: true
+AllowShortLambdasOnASingleLine: All
+
+# Line length
+ColumnLimit: 100
+
+# Alignment
 AlignAfterOpenBracket: Align
+AlignConsecutiveAssignments: false
+AlignConsecutiveDeclarations: false
+AlignOperands: Align
 AlignTrailingComments: true
-AllowShortFunctionsOnASingleLine: Inline
-AllowShortIfStatementsOnASingleLine: Never
-AllowShortLoopsOnASingleLine: false
-AlwaysBreakTemplateDeclarations: Yes
-BinPackArguments: false
-BinPackParameters: false
-BreakBeforeBraces: Attach
+
+# Spaces
+SpaceBeforeParens: ControlStatements  # if (...) but func(...)
+SpaceAfterCStyleCast: false
+SpacesInParentheses: false
+SpacesInSquareBrackets: false
+SpaceBeforeSquareBrackets: false
+
+# Includes
+SortIncludes: false                   # don't reorder — Windows headers are order-sensitive
+IncludeBlocks: Preserve
+
+# Pointer/reference alignment
+PointerAlignment: Left                # char* buf  (not  char *buf)
+ReferenceAlignment: Left
+
+# Other
+AllowAllParametersOfDeclarationOnNextLine: true
+BinPackArguments: true
+BinPackParameters: true
 BreakConstructorInitializers: BeforeColon
-ConstructorInitializerAllOnOneLineOrOnePerLine: true
+ConstructorInitializerIndentWidth: 4
 ContinuationIndentWidth: 4
 Cpp11BracedListStyle: true
 DerivePointerAlignment: false
 FixNamespaceComments: true
-IncludeBlocks: Preserve
-IndentCaseLabels: true
-IndentPPDirectives: None
-KeepEmptyLinesAtTheStartOfBlocks: false
-NamespaceIndentation: None
-PointerAlignment: Left
+MaxEmptyLinesToKeep: 1
 ReflowComments: true
-SortIncludes: CaseInsensitive
-SortUsingDeclarations: true
-SpaceAfterCStyleCast: false
-SpaceAfterTemplateKeyword: false
-SpaceBeforeAssignmentOperators: true
-SpaceBeforeParens: ControlStatements
-SpaceInEmptyParentheses: false
-SpacesBeforeTrailingComments: 2
-SpacesInAngles: false
-SpacesInCStyleCastParentheses: false
-SpacesInContainerLiterals: false
-SpacesInParentheses: false
-SpacesInSquareBrackets: false
+SpaceBeforeCpp11BracedList: false
 Standard: c++17
----

.clang-tidy

@@ -1,52 +1,51 @@
----
+# TinkerNorth — canonical clang-tidy configuration.
+# This exact file is shared by satellite, dish-android (JNI), dish-linux,
+# and dish-mac (any C/C++ source).
+#
+# HeaderFilterRegex matches headers under src/, app/src/main/cpp/, or tests/
+# so the same config covers every repo without per-repo overrides.
+
 Checks: >
   -*,
   bugprone-*,
-  clang-analyzer-*,
-  cppcoreguidelines-*,
-  modernize-*,
-  performance-*,
-  portability-*,
-  readability-*,
   -bugprone-easily-swappable-parameters,
-  -cppcoreguidelines-avoid-magic-numbers,
-  -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
-  -cppcoreguidelines-pro-bounds-pointer-arithmetic,
-  -cppcoreguidelines-pro-bounds-constant-array-index,
-  -cppcoreguidelines-pro-type-reinterpret-cast,
-  -cppcoreguidelines-pro-type-vararg,
-  -cppcoreguidelines-non-private-member-variables-in-classes,
-  -cppcoreguidelines-owning-memory,
-  -cppcoreguidelines-avoid-non-const-global-variables,
-  -modernize-use-trailing-return-type,
-  -modernize-avoid-c-arrays,
-  -portability-avoid-pragma-once,
-  -readability-magic-numbers,
-  -readability-identifier-length,
-  -readability-function-cognitive-complexity,
-  -readability-redundant-access-specifiers
+  -bugprone-narrowing-conversions,
+  cert-*,
+  -cert-err58-cpp,
+  cppcoreguidelines-init-variables,
+  cppcoreguidelines-avoid-goto,
+  misc-redundant-expression,
+  misc-unused-using-decls,
+  modernize-use-auto,
+  modernize-use-nullptr,
+  modernize-use-override,
+  modernize-use-using,
+  modernize-loop-convert,
+  modernize-redundant-void-arg,
+  modernize-return-braced-init-list,
+  performance-*,
+  -performance-no-int-to-ptr,
+  readability-braces-around-statements,
+  readability-const-return-type,
+  readability-container-size-empty,
+  readability-duplicate-include,
+  readability-else-after-return,
+  readability-implicit-bool-conversion,
+  readability-inconsistent-declaration-parameter-name,
+  readability-misleading-indentation,
+  readability-redundant-control-flow,
+  readability-redundant-string-cstr,
+  readability-simplify-boolean-expr,
+  readability-string-compare,
+
 WarningsAsErrors: ''
-HeaderFilterRegex: '^.*/dish-linux/src/.*$'
-FormatStyle: file
+
+HeaderFilterRegex: '.*/(src|app/src/main/cpp|tests)/.*\.h$'
+
 CheckOptions:
-  - key: readability-identifier-naming.ClassCase
-    value: CamelCase
-  - key: readability-identifier-naming.StructCase
-    value: CamelCase
-  - key: readability-identifier-naming.EnumCase
-    value: CamelCase
-  - key: readability-identifier-naming.FunctionCase
-    value: camelBack
-  - key: readability-identifier-naming.VariableCase
-    value: camelBack
-  - key: readability-identifier-naming.PrivateMemberSuffix
-    value: _
-  - key: readability-identifier-naming.ConstexprVariableCase
-    value: CamelCase
-  - key: readability-identifier-naming.ConstexprVariablePrefix
-    value: k
-  - key: readability-identifier-naming.GlobalConstantCase
-    value: CamelCase
-  - key: readability-identifier-naming.GlobalConstantPrefix
-    value: k
----
+  - key: modernize-use-auto.MinTypeNameLength
+    value: 5
+  - key: readability-braces-around-statements.ShortStatementLines
+    value: 1
+  - key: performance-move-const-arg.CheckTriviallyCopyableMove
+    value: false

.githooks/pre-commit

@@ -1,50 +1,46 @@
 #!/usr/bin/env bash
-# Dish Linux pre-commit hook: runs clang-format (check) and clang-tidy
-# (warnings → errors) on staged C++ sources. Skips gracefully if either
-# tool is missing so contributors who haven't run setup-hooks.sh aren't
-# blocked — CI enforces both checks in strict mode.
+# Dish Linux pre-commit hook: autofixes clang-format on staged C/C++ sources
+# (mirroring the satellite and dish-mac hook semantics) and runs clang-tidy
+# in advisory mode. Skips gracefully if either tool is missing — CI enforces
+# both checks in strict mode.
 set -euo pipefail
 
 repo_root=$(git rev-parse --show-toplevel)
 cd "$repo_root"
 
-# Collect staged C/C++ sources under src/ and tests/ (added/copied/modified).
-mapfile -t staged < <(
-    git diff --cached --name-only --diff-filter=ACM \
-        -- 'src/*.cpp' 'src/*.h' 'src/*.hpp' 'tests/*.cpp' 'tests/*.h'
-)
-
-if [ "${#staged[@]}" -eq 0 ]; then
+# Collect staged C/C++ sources under src/ and tests/ (added/copied/modified),
+# NUL-separated to handle paths with spaces.
+staged=$(git diff --cached --name-only --diff-filter=ACM -z \
+    -- 'src/*.cpp' 'src/*.h' 'src/*.hpp' 'tests/*.cpp' 'tests/*.h' \
+    | tr '\0' '\n' | sed '/^$/d')
+if [ -z "$staged" ]; then
     exit 0
 fi
 
-format_ok=1
-tidy_ok=1
-
-# ── clang-format ─────────────────────────────────────────────────────────
+# ── clang-format (autofix) ───────────────────────────────────────────────
 if command -v clang-format >/dev/null 2>&1; then
-    echo "▶ clang-format --dry-run --Werror (${#staged[@]} file(s))"
-    if ! clang-format --dry-run --Werror "${staged[@]}"; then
-        echo "  run: clang-format -i ${staged[*]}"
-        format_ok=0
-    fi
+    echo "▶ clang-format (staged files)"
+    echo "$staged" | while IFS= read -r file; do
+        clang-format -i "$file"
+        git add "$file"
+    done
 else
-    echo "⚠  clang-format not installed — skipping (install clang-format)"
+    echo "⚠  clang-format not installed — skipping (sudo apt install clang-format)"
 fi
 
-# ── clang-tidy ───────────────────────────────────────────────────────────
+# ── clang-tidy (advisory) ────────────────────────────────────────────────
 # Needs a compile_commands.json. We generate one in build-debug via CMake
 # (CMAKE_EXPORT_COMPILE_COMMANDS is ON in CMakeLists.txt). Match CI: report
 # warnings but don't block the commit on stylistic findings — .clang-tidy's
 # WarningsAsErrors='' is authoritative.
 if command -v clang-tidy >/dev/null 2>&1; then
     if [ -f build-debug/compile_commands.json ]; then
         cpp_files=()
-        for f in "${staged[@]}"; do
+        while IFS= read -r f; do
             case "$f" in
                 *.cpp) cpp_files+=("$f") ;;
             esac
-        done
+        done <<<"$staged"
         if [ "${#cpp_files[@]}" -gt 0 ]; then
             echo "▶ clang-tidy -p build-debug (${#cpp_files[@]} file(s))"
             clang-tidy -p build-debug --quiet "${cpp_files[@]}" || true
@@ -53,11 +49,5 @@ if command -v clang-tidy >/dev/null 2>&1; then
         echo "⚠  build-debug/compile_commands.json missing — run scripts/build.sh debug"
     fi
 else
-    echo "⚠  clang-tidy not installed — skipping (install clang-tidy)"
-fi
-
-if [ "$format_ok" -eq 0 ] || [ "$tidy_ok" -eq 0 ]; then
-    echo
-    echo "✗ pre-commit failed — fix the issues above and re-stage."
-    exit 1
+    echo "⚠  clang-tidy not installed — skipping (sudo apt install clang-tidy)"
 fi

.github/workflows/linux-ci.yml

@@ -26,7 +26,21 @@ jobs:
             build-essential cmake ninja-build pkg-config \
             qt6-base-dev qt6-base-dev-tools \
             libsodium-dev libsdl2-dev \
-            clang-format clang-tidy
+            clang-tidy
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+
+      # Pinned to match satellite + dish-android + dish-mac. Ubuntu 24.04 ships
+      # clang-format 18 which disagrees with brew's 22.x on braced-init lists,
+      # so we pull the matching wheel from PyPI to keep the four repos in sync.
+      - name: Install clang-format (pinned 22.1.4)
+        run: |
+          pipx install clang-format==22.1.4
+          pipx ensurepath
+          echo "$HOME/.local/bin" >> "$GITHUB_PATH"
 
       - name: clang-format (check only)
         run: |