Skip to content

strpos result comparison bug (and other bugs) #5

Description

@primehalo

In the performPaymentInitialization function, you compare the result of strpos($s, ":") against -1 when it should be compared against FALSE because strpos returns FALSE when no match is found and in PHP -1 is not a FALSE value.

I would also suggest using urlecode() on the query variables when building the URL query string.

In the performTransaction function "id" and "parseResults" are both missing their preceding "$this->"

Towards the bottom of the sendMessage function there appears to be a missing "else" in between "} {".

In the parseResults function, the "s2" and "flag" variables are missing their preceding "$" in one spot each and StartsWith is missing its preceding "$this->".

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions