ci(frontend): publish generated dashboard diagnostics

Author: TheHiddenObserver

.github/workflows/benchmark-frontend.yml

@@ -2,13 +2,14 @@ name: Benchmark Frontend CI
 
 on:
   push:
-    branches: [master, frontend-dashboard-data-pipeline]
+    branches: [master]
     paths:
       - '.github/workflows/benchmark-frontend.yml'
       - 'dev/benchmarks/**'
       - 'dev/tests/test_benchmark_frontend_data.py'
       - 'dev/tests/test_frontend_contracts.py'
       - 'dev/tests/test_frontend_domain_coverage.py'
+      - 'dev/tests/fixtures/benchmark_frontend/**'
       - 'frontend/**'
       - 'docs/assets/benchmarks/**'
       - 'results/benchmark_frontend_sources/**'
@@ -19,13 +20,13 @@ on:
       - 'dev/tests/test_benchmark_frontend_data.py'
       - 'dev/tests/test_frontend_contracts.py'
       - 'dev/tests/test_frontend_domain_coverage.py'
+      - 'dev/tests/fixtures/benchmark_frontend/**'
       - 'frontend/**'
       - 'docs/assets/benchmarks/**'
       - 'results/benchmark_frontend_sources/**'
 
 jobs:
   python-data:
-    if: github.event_name == 'pull_request' || github.ref == 'refs/heads/master'
     runs-on: ubuntu-latest
     strategy:
       matrix:
@@ -35,16 +36,25 @@ jobs:
       - uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
-      - run: python -m pip install -U pip pytest jsonschema
-      - run: |
+      - name: Install test dependencies
+        run: python -m pip install -U pip pytest jsonschema
+      - name: Run generator and parser tests
+        run: |
+          set -o pipefail
           pytest \
             dev/tests/test_benchmark_frontend_data.py \
             dev/tests/test_frontend_contracts.py \
-            dev/tests/test_frontend_domain_coverage.py -v
-      - run: python dev/benchmarks/generate_benchmark_data.py --check --strict-sources
+            dev/tests/test_frontend_domain_coverage.py -vv 2>&1 | tee pytest-frontend.log
+      - uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: pytest-frontend-${{ matrix.python-version }}
+          path: pytest-frontend.log
+          retention-days: 7
+      - name: Validate generator output
+        run: python dev/benchmarks/generate_benchmark_data.py --check --strict-sources
 
   frontend:
-    if: github.event_name == 'pull_request' || github.ref == 'refs/heads/master'
     runs-on: ubuntu-latest
     defaults:
       run:
@@ -54,12 +64,20 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version: '20'
+      - name: Reject committed frontend artifacts
+        run: |
+          if git -C "$GITHUB_WORKSPACE" ls-files \
+            'frontend/node_modules/**' \
+            'frontend/test-results/**' \
+            'frontend/playwright-report/**' | grep -q .; then
+            echo "Generated frontend dependencies/test artifacts must not be committed."
+            exit 1
+          fi
       - run: npm ci
       - run: npm run typecheck
       - run: npm run build
 
   staleness:
-    if: github.event_name == 'pull_request' || github.ref == 'refs/heads/master'
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -69,22 +87,37 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version: '20'
-      - run: |
+      - name: Generate data (deterministic)
+        run: |
           python dev/benchmarks/generate_benchmark_data.py \
             --out frontend/public/data/benchmark_data.json \
             --report frontend/public/data/parse_report.json \
             --inventory-out frontend/public/data/source_inventory.json \
             --deterministic --strict-sources
-      - run: |
+      - name: Build frontend
+        run: |
           cd frontend
           npm ci
           npm run build
-      - run: |
+      - uses: actions/upload-artifact@v4
+        with:
+          name: june-dashboard-generated
+          path: |
+            frontend/public/data/
+            docs/assets/benchmarks/
+          retention-days: 7
+      - name: Check staleness
+        run: |
           changes="$(git status --porcelain -- frontend/public/data docs/assets/benchmarks)"
-          test -z "$changes" || { printf '%s\n' "$changes"; exit 1; }
+          if [ -n "$changes" ]; then
+            echo "Generated benchmark assets are stale:"
+            printf '%s\n' "$changes"
+            git diff -- frontend/public/data docs/assets/benchmarks
+            exit 1
+          fi
+          echo "OK — generated benchmark assets are current"
 
   frontend-e2e:
-    if: github.event_name == 'pull_request' || github.ref == 'refs/heads/master'
     runs-on: ubuntu-latest
     needs: [frontend, staleness]
     defaults:
@@ -98,76 +131,9 @@ jobs:
       - run: npm ci
       - run: npx playwright install --with-deps chromium
       - run: npm run test:e2e
-
-  refresh-june-dashboard:
-    if: github.event_name == 'push' && github.ref == 'refs/heads/frontend-dashboard-data-pipeline'
-    runs-on: ubuntu-latest
-    permissions:
-      contents: write
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          ref: frontend-dashboard-data-pipeline
-      - uses: actions/setup-python@v5
+      - uses: actions/upload-artifact@v4
+        if: always()
         with:
-          python-version: '3.11'
-      - uses: actions/setup-node@v4
-        with:
-          node-version: '20'
-      - name: Run tests with diagnostic capture
-        id: pytest
-        continue-on-error: true
-        run: |
-          python -m pip install -U pip pytest jsonschema
-          set -o pipefail
-          pytest \
-            dev/tests/test_benchmark_frontend_data.py \
-            dev/tests/test_frontend_contracts.py \
-            dev/tests/test_frontend_domain_coverage.py -vv 2>&1 | tee /tmp/june-dashboard-pytest.log
-      - name: Commit failure summary
-        if: steps.pytest.outcome == 'failure'
-        run: |
-          tail -n 200 /tmp/june-dashboard-pytest.log > dev/tests/june_dashboard_pytest_failure.txt
-          rm -f .github/workflows/finalize-june-dashboard.yml
-          git show b63e184fa2d9de3c1d2ba8f83c251c5788ca0847:.github/workflows/benchmark-frontend.yml > .github/workflows/benchmark-frontend.yml
-          git config user.name github-actions[bot]
-          git config user.email 41898282+github-actions[bot]@users.noreply.github.com
-          git add -A
-          git commit -m "test(frontend): capture June-only failure"
-          git push origin HEAD:frontend-dashboard-data-pipeline
-      - name: Generate bundle
-        if: steps.pytest.outcome == 'success'
-        run: |
-          python dev/benchmarks/generate_benchmark_data.py \
-            --out frontend/public/data/benchmark_data.json \
-            --report frontend/public/data/parse_report.json \
-            --inventory-out frontend/public/data/source_inventory.json \
-            --deterministic --strict-sources
-      - name: Build and test frontend
-        if: steps.pytest.outcome == 'success'
-        working-directory: frontend
-        run: |
-          npm ci
-          npm run typecheck
-          npm run build
-          npx playwright install --with-deps chromium
-          npm run test:e2e
-      - name: Commit generated assets
-        if: steps.pytest.outcome == 'success'
-        run: |
-          rm -f .github/workflows/finalize-june-dashboard.yml
-          git show b63e184fa2d9de3c1d2ba8f83c251c5788ca0847:.github/workflows/benchmark-frontend.yml > .github/workflows/benchmark-frontend.yml
-          read runs models <<EOF
-          $(python - <<'PY'
-          import json
-          from pathlib import Path
-          data = json.loads(Path('frontend/public/data/benchmark_data.json').read_text())
-          print(len(data['runs']), len(data['models']))
-          PY
-          )
-          EOF
-          git config user.name github-actions[bot]
-          git config user.email 41898282+github-actions[bot]@users.noreply.github.com
-          git add -A
-          git commit -m "build(frontend): publish June-only bundle (${runs} runs, ${models} models)"
-          git push origin HEAD:frontend-dashboard-data-pipeline
+          name: playwright-report
+          path: frontend/playwright-report/
+          retention-days: 30