v1.9.26 — Fix 9 bugs: disk cleanup byte counter, NTP exit codes, menu navigation, firewall state, CSV null partition, IP display, iSCSI NIC wrapping

Author: TheAbider

Changelog.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## v1.9.26
+
+- **Bug Fix:** Disk cleanup byte counter was corrupted by directory entries — `Get-ChildItem` without `-File` included directories, whose `.Length` returns name character count (not byte size). The "freed space" report was inflated with nonsense values. Added `-File` flag to both temp cleanup loops (20-DiskCleanup).
+- **Bug Fix:** NTP configuration reported "configured successfully" even when `w32tm /config` or `/resync` failed — native executables set `$LASTEXITCODE` but don't throw PowerShell exceptions, so the `try/catch` caught nothing. Now checks `$LASTEXITCODE` after each `w32tm` call (19-NTPConfiguration).
+- **Bug Fix:** Detailed time status display truncation logic was broken for `w32tm` error output — `2>&1` redirects stderr as `ErrorRecord` objects, not strings. Accessing `.Length` on `ErrorRecord` returns `$null`, making the `Substring` guard a no-op. Now converts to string first (19-NTPConfiguration).
+- **Bug Fix:** Navigation commands (`exit`, `help`, `back`, `b`/`B`) were silently ignored in two network menus — `Start-Show-HostNetworkIPMenu` and `Start-Show-VM-NetworkMenu` were missing the `Test-NavigationCommand` call that all other menu runners have. Typing "exit" fell into the "Invalid choice" handler (49-MenuRunner).
+- **Bug Fix:** Firewall state detection compared `.Enabled` (a `GpoBoolean` enum) to the string `"True"` instead of `$true` — worked by accident via type coercion but reported "Disabled" instead of using the catch-block "Unknown" when a profile was null (05-SystemCheck).
+- **Bug Fix:** Current IP display garbled output when adapter had multiple IPv4 addresses — `Get-NetIPAddress` can return multiple objects, causing `$currentIP.IPAddress` to concatenate array elements. Added `Select-Object -First 1` (07-IPConfiguration).
+- **Bug Fix:** Cluster dashboard and CSV health checks crashed or showed 0 GB for faulted/offline CSVs — `SharedVolumeInfo.Partition` is null when a CSV is unavailable, causing `$null / 1GB` to produce zeros. Added null guards with skip+warning in all three CSV iteration loops (51-ClusterDashboard).
+- **Bug Fix:** iSCSI NIC identification menu couldn't select adapters when only one physical NIC existed — pipeline result wasn't wrapped in `@()`, so `.Count` and array indexing failed on single objects. Wrapped all three `Get-NetAdapter` assignments (10-iSCSI).
+- 63 modules, 1854 tests
+
 ## v1.9.25
 
 - **Bug Fix:** All bare `Exit` statements caused a "System error" dialog when running as the compiled EXE — ps2exe wraps `Exit` in a way that throws `BreakException`. Replaced with `[Environment]::Exit()` in both `Exit-Script` exit paths (47-ExitCleanup) and batch mode entry/exit (50-EntryPoint). Affects 4 code paths: normal exit, no-reboot exit, batch admin check failure, and batch completion.

Header.ps1

@@ -30,11 +30,22 @@
     7h3 4b1d3r
 
 .VERSION
-    1.9.25
+    1.9.26
 
 .LAST UPDATED
     02/25/2026
 
+.CHANGELOG v1.9.26
+    BUG FIXES:
+    - FIXED: Disk cleanup byte counter included directory name lengths instead of file sizes — Get-ChildItem without -File counted DirectoryInfo.Length (name char count) as freed bytes (20-DiskCleanup)
+    - FIXED: NTP configuration reported success even when w32tm failed — native exe exit codes were piped to Out-Null and never checked (19-NTPConfiguration)
+    - FIXED: Detailed time status display broke on w32tm error output — ErrorRecord objects from 2>&1 lack .Length property, causing truncation logic to silently fail (19-NTPConfiguration)
+    - FIXED: Navigation commands (exit, help, back) ignored in Host IP Network and VM Network menus — missing Test-NavigationCommand call before switch statement (49-MenuRunner)
+    - FIXED: Firewall state check compared .Enabled to string "True" instead of boolean $true — also added null guard for missing firewall profiles (05-SystemCheck)
+    - FIXED: Current IP display garbled when adapter had multiple IPv4 addresses — Get-NetIPAddress can return multiple objects (07-IPConfiguration)
+    - FIXED: Cluster dashboard crashed on faulted/offline CSVs — SharedVolumeInfo.Partition is null when CSV is unavailable, causing division on null (51-ClusterDashboard)
+    - FIXED: NIC identification menu failed with single physical adapter — pipeline result not wrapped in @() for reliable .Count and array indexing (10-iSCSI)
+
 .CHANGELOG v1.9.25
     BUG FIXES:
     - FIXED: Bare Exit statements caused "System error" dialog when running as compiled EXE — ps2exe requires [Environment]::Exit() instead of Exit (47-ExitCleanup, 50-EntryPoint)

Modules/00-Initialization.ps1

@@ -135,7 +135,7 @@ if (-not $script:ModuleRoot) { $script:ModuleRoot = $PSScriptRoot }
 if (-not $script:ModuleRoot -and $script:ScriptPath) {
     $script:ModuleRoot = [System.IO.Path]::GetDirectoryName($script:ScriptPath)
 }
-$script:ScriptVersion = "1.9.25"
+$script:ScriptVersion = "1.9.26"
 $script:ScriptStartTime = Get-Date
 
 # OS version detection (for feature compatibility)

Modules/05-SystemCheck.ps1

@@ -161,9 +161,9 @@ function Get-FirewallState {
         $publicProfile = Get-NetFirewallProfile -Profile Public -ErrorAction SilentlyContinue
 
         return @{
-            Domain = if ($domainProfile.Enabled -eq "True") { "Enabled" } else { "Disabled" }
-            Private = if ($privateProfile.Enabled -eq "True") { "Enabled" } else { "Disabled" }
-            Public = if ($publicProfile.Enabled -eq "True") { "Enabled" } else { "Disabled" }
+            Domain = if ($null -ne $domainProfile -and $domainProfile.Enabled -eq $true) { "Enabled" } else { "Disabled" }
+            Private = if ($null -ne $privateProfile -and $privateProfile.Enabled -eq $true) { "Enabled" } else { "Disabled" }
+            Public = if ($null -ne $publicProfile -and $publicProfile.Enabled -eq $true) { "Enabled" } else { "Disabled" }
         }
     }
     catch {

Modules/07-IPConfiguration.ps1

@@ -133,7 +133,7 @@ function Set-VMIPAddress {
     )
 
     # Get current IP configuration
-    $currentIP = Get-NetIPAddress -InterfaceAlias $selectedAdapterName -AddressFamily IPv4 -ErrorAction SilentlyContinue
+    $currentIP = Get-NetIPAddress -InterfaceAlias $selectedAdapterName -AddressFamily IPv4 -ErrorAction SilentlyContinue | Select-Object -First 1
     if ($currentIP) {
         Write-OutputColor "Current IP: $($currentIP.IPAddress)/$($currentIP.PrefixLength)" -color "Info"
     }

Modules/10-iSCSI.ps1

@@ -1228,13 +1228,13 @@ function Start-Show-iSCSISANMenu {
             }
             "2" {
                 # NIC identification helper
-                $adapters = Get-NetAdapter | Where-Object {
+                $adapters = @(Get-NetAdapter | Where-Object {
                     $_.Name -notlike "vEthernet*" -and
                     $_.InterfaceDescription -notlike "*Hyper-V*" -and
                     $_.InterfaceDescription -notlike "*Virtual*"
-                }
+                })
 
-                if (-not $adapters -or $adapters.Count -eq 0) {
+                if ($adapters.Count -eq 0) {
                     Write-OutputColor "  No physical adapters found." -color "Error"
                     Write-PressEnter
                 }
@@ -1246,23 +1246,23 @@ function Start-Show-iSCSISANMenu {
                         }
                         elseif ($identifyChoice -match '^[Rr]$') {
                             # Refresh adapter list
-                            $adapters = Get-NetAdapter | Where-Object {
+                            $adapters = @(Get-NetAdapter | Where-Object {
                                 $_.Name -notlike "vEthernet*" -and
                                 $_.InterfaceDescription -notlike "*Hyper-V*" -and
                                 $_.InterfaceDescription -notlike "*Virtual*"
-                            }
+                            })
                             continue
                         }
                         elseif ($identifyChoice -match '^\d+$') {
                             $idx = [int]$identifyChoice
                             if ($idx -ge 1 -and $idx -le $adapters.Count) {
                                 Disable-NICForIdentification -Adapter $adapters[$idx - 1]
                                 # Refresh after enable
-                                $adapters = Get-NetAdapter | Where-Object {
+                                $adapters = @(Get-NetAdapter | Where-Object {
                                     $_.Name -notlike "vEthernet*" -and
                                     $_.InterfaceDescription -notlike "*Hyper-V*" -and
                                     $_.InterfaceDescription -notlike "*Virtual*"
-                                }
+                                })
                             }
                         }
                     }

Modules/19-NTPConfiguration.ps1

@@ -109,18 +109,26 @@ function Set-NTPServer {
     try {
         if ($IsDomainType) {
             # Configure to sync with domain hierarchy
-            w32tm /config /syncfromflags:DOMHIER /update | Out-Null
+            $null = w32tm /config /syncfromflags:DOMHIER /update 2>&1
         } else {
             # Configure manual NTP server
-            w32tm /config /manualpeerlist:$Server /syncfromflags:manual /reliable:yes /update | Out-Null
+            $null = w32tm /config /manualpeerlist:$Server /syncfromflags:manual /reliable:yes /update 2>&1
+        }
+
+        if ($LASTEXITCODE -ne 0) {
+            Write-OutputColor "  Failed to configure NTP server (exit code $LASTEXITCODE)." -color "Error"
+            return
         }
 
         # Restart time service
         Restart-Service w32time -Force -ErrorAction SilentlyContinue
         Start-Sleep -Seconds 2
 
         # Force sync
-        w32tm /resync /force | Out-Null
+        $null = w32tm /resync /force 2>&1
+        if ($LASTEXITCODE -ne 0) {
+            Write-OutputColor "  NTP configured but time sync failed (exit code $LASTEXITCODE)." -color "Warning"
+        }
 
         Write-OutputColor "  NTP server configured successfully." -color "Success"
         Add-SessionChange -Category "System" -Description "Configured NTP server: $Server"
@@ -139,8 +147,9 @@ function Show-DetailedTimeStatus {
 
     $status = w32tm /query /status 2>&1
     foreach ($line in $status) {
-        if ($line -and $line.ToString().Trim()) {
-            $displayLine = if ($line.Length -gt 68) { $line.Substring(0,65) + "..." } else { $line }
+        $lineStr = $line.ToString()
+        if ($lineStr.Trim()) {
+            $displayLine = if ($lineStr.Length -gt 68) { $lineStr.Substring(0,65) + "..." } else { $lineStr }
             Write-OutputColor "  │$("  $displayLine".PadRight(72))│" -color "Info"
         }
     }

Modules/20-DiskCleanup.ps1

@@ -98,20 +98,20 @@ function Invoke-QuickClean {
 
     # User temp
     if (Test-Path $env:TEMP) {
-        $files = Get-ChildItem $env:TEMP -Recurse -Force -ErrorAction SilentlyContinue
+        $files = Get-ChildItem $env:TEMP -Recurse -Force -File -ErrorAction SilentlyContinue
         foreach ($file in $files) {
             $fileSize = $file.Length
-            Remove-Item $file.FullName -Force -Recurse -ErrorAction SilentlyContinue
+            Remove-Item $file.FullName -Force -ErrorAction SilentlyContinue
             if (-not (Test-Path $file.FullName)) { $cleaned += $fileSize }
         }
     }
 
     # Windows temp
     if (Test-Path "C:\Windows\Temp") {
-        $files = Get-ChildItem "C:\Windows\Temp" -Recurse -Force -ErrorAction SilentlyContinue
+        $files = Get-ChildItem "C:\Windows\Temp" -Recurse -Force -File -ErrorAction SilentlyContinue
         foreach ($file in $files) {
             $fileSize = $file.Length
-            Remove-Item $file.FullName -Force -Recurse -ErrorAction SilentlyContinue
+            Remove-Item $file.FullName -Force -ErrorAction SilentlyContinue
             if (-not (Test-Path $file.FullName)) { $cleaned += $fileSize }
         }
     }

Modules/49-MenuRunner.ps1

@@ -491,6 +491,10 @@ function Start-Show-HostNetworkIPMenu {
     while ($true) {
         $vmNetworkChoice = Show-Host-IPNetworkMenu -selectedAdapterName $selectedAdapterName
 
+        $navResult = Test-NavigationCommand -UserInput $vmNetworkChoice
+        if ($navResult.Action -eq "exit") { Exit-Script; return }
+        if ($navResult.Action -eq "back") { return }
+
         switch ($vmNetworkChoice) {
             "1" {
                 Set-VMIPAddress -selectedAdapterName $selectedAdapterName
@@ -538,6 +542,10 @@ function Start-Show-VM-NetworkMenu {
     while ($true) {
         $vmNetworkChoice = Show-VM-NetworkMenu -selectedAdapterName $selectedAdapterName
 
+        $navResult = Test-NavigationCommand -UserInput $vmNetworkChoice
+        if ($navResult.Action -eq "exit") { Exit-Script; return }
+        if ($navResult.Action -eq "back") { return }
+
         switch ($vmNetworkChoice) {
             "1" {
                 Set-VMIPAddress -selectedAdapterName $selectedAdapterName

Modules/51-ClusterDashboard.ps1

@@ -63,6 +63,10 @@ function Show-ClusterDashboard {
 
         foreach ($csv in $csvs) {
             $partition = $csv.SharedVolumeInfo.Partition
+            if (-not $partition) {
+                Write-OutputColor "  │$("  $($csv.Name) - Partition info unavailable".PadRight(72))│" -color "Warning"
+                continue
+            }
 
             $totalGB = [math]::Round($partition.Size / 1GB, 0)
             $freeGB = [math]::Round($partition.FreeSpace / 1GB, 0)
@@ -285,6 +289,12 @@ function Show-CSVHealth {
     foreach ($csv in $csvs) {
         $partition = $csv.SharedVolumeInfo.Partition
         $redirected = $csv.SharedVolumeInfo.FaultState
+        if (-not $partition) {
+            Write-OutputColor "  ┌────────────────────────────────────────────────────────────────────────┐" -color "Warning"
+            Write-OutputColor "  │$("  $($csv.Name) - Partition info unavailable".PadRight(72))│" -color "Warning"
+            Write-OutputColor "  └────────────────────────────────────────────────────────────────────────┘" -color "Warning"
+            continue
+        }
 
         $totalGB = [math]::Round($partition.Size / 1GB, 1)
         $freeGB = [math]::Round($partition.FreeSpace / 1GB, 1)
@@ -487,6 +497,13 @@ function Initialize-ClusterCSV {
     $issues = 0
     foreach ($csv in $csvs) {
         $partition = $csv.SharedVolumeInfo.Partition
+        if (-not $partition) {
+            Write-OutputColor "  ┌────────────────────────────────────────────────────────────────────────┐" -color "Warning"
+            Write-OutputColor "  │$("  $($csv.Name) - Partition info unavailable".PadRight(72))│" -color "Warning"
+            Write-OutputColor "  └────────────────────────────────────────────────────────────────────────┘" -color "Warning"
+            $issues++
+            continue
+        }
         $totalGB = [math]::Round($partition.Size / 1GB, 0)
         $freeGB = [math]::Round($partition.FreeSpace / 1GB, 0)
         $usedPct = if ($totalGB -gt 0) { [math]::Round(($totalGB - $freeGB) / $totalGB * 100, 0) } else { 0 }