Check if we can get by without depending on jilleJR?

[winsmith]

From a user:

Using the package manager to install requires the jilleJr version. It's probably better but I cannot use this version as other plugins I use rely on components that aren't in jilleJr's version of the plugin. Would be good to offer a package manager version that doesn't have this as a dependancy

[conath]

The project must have either Newtonsoft.JSON or on jilleJR's fork imported. So in this sense we don't specifically need the jilleJR dependency. The jilleJR fork is optimized for Unity, so I chose that one.

We have three options here:

1. Offer an alternative UPM repository with slightly modified meta files so we depend on Newtonsoft.JSON, no code changes.
2. Change the dependency in this repo to Newtonsoft.JSON
3. Remove the UPM dependency altogether and have users manually import the dependency or their choice. (mention in the README that either one must be imported)

[winsmith]

Good to know, thanks! <3 Let's see if more community members comment on their wishes

[QueRoxa]

1. Offer an alternative UPM repository with slightly modified meta files so we depend on Newtonsoft.JSON, no code changes.
2. Remove the UPM dependency altogether and have users manually import the dependency or their choice.

Hi, @conath - sorry, I was the one who suggested this issue.

I think either 2 or 3 is the best option, jilleJR's fork is optimised for Unity, and is sort of the default Unity uses (that's a whole other thing), it's only recently been adopted more by Unity, and many other plugins still rely on Newtonsoft.JSON and while 90% of cases would probably be fine with the user exchanging one for the other, I think there'll still be that 10% where it will cause issues.

The asset I have to use in Unity seemingly uses part of Newtonsoft.JSON that doesn't exist in jilleJR's fork, or is functionally incorrect / different. While I could probably fix that, it'll take me some time and isn't something everyone can do - or would want to while just experimenting adding telemetry.

Having a "preferred" UPM repository with jilleJR's fork and an "alternative" with Newtonsoft.JSON might be ideal?