diff --git a/manifestcheck/build.gradle.kts b/manifestcheck/build.gradle.kts index 849fb9f..25b375f 100644 --- a/manifestcheck/build.gradle.kts +++ b/manifestcheck/build.gradle.kts @@ -45,7 +45,7 @@ gradlePlugin { id = "com.telefonica.manifestcheck" displayName = "ManifestCheck" description = "ManifestCheck is a Gradle plugin that helps you catch Android permission/feature regressions automatically." - implementationClass = "io.github.simonschiller.permissioncheck.PermissionCheckPlugin" + implementationClass = "com.telefonica.manifestcheck.PermissionCheckPlugin" } } website = "https://github.com/Telefonica/android-permissioncheck" diff --git a/manifestcheck/src/main/kotlin/io/github/simonschiller/permissioncheck/PermissionCheckPlugin.kt b/manifestcheck/src/main/kotlin/com/telefonica/manifestcheck/PermissionCheckPlugin.kt similarity index 85% rename from manifestcheck/src/main/kotlin/io/github/simonschiller/permissioncheck/PermissionCheckPlugin.kt rename to manifestcheck/src/main/kotlin/com/telefonica/manifestcheck/PermissionCheckPlugin.kt index c1091a4..8cac1b4 100644 --- a/manifestcheck/src/main/kotlin/io/github/simonschiller/permissioncheck/PermissionCheckPlugin.kt +++ b/manifestcheck/src/main/kotlin/com/telefonica/manifestcheck/PermissionCheckPlugin.kt @@ -1,7 +1,7 @@ -package io.github.simonschiller.permissioncheck +package com.telefonica.manifestcheck import com.android.build.gradle.AppPlugin -import io.github.simonschiller.permissioncheck.config.TaskConfiguratorV1 +import com.telefonica.manifestcheck.config.TaskConfiguratorV1 import org.gradle.api.Plugin import org.gradle.api.Project @@ -21,4 +21,4 @@ class PermissionCheckPlugin : Plugin { taskConfigurator.configureTasks(project, extension) } } -} +} \ No newline at end of file diff --git a/manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/MultiVariantPermissionCheckIntegrationTest.kt b/manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/MultiVariantPermissionCheckIntegrationTest.kt similarity index 98% rename from manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/MultiVariantPermissionCheckIntegrationTest.kt rename to manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/MultiVariantPermissionCheckIntegrationTest.kt index 7627358..8021c7a 100644 --- a/manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/MultiVariantPermissionCheckIntegrationTest.kt +++ b/manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/MultiVariantPermissionCheckIntegrationTest.kt @@ -1,8 +1,8 @@ -package io.github.simonschiller.permissioncheck +package com.telefonica.manifestcheck -import io.github.simonschiller.permissioncheck.testutil.AndroidProjectExtension -import io.github.simonschiller.permissioncheck.testutil.TestVersions -import io.github.simonschiller.permissioncheck.testutil.outcomeOf +import com.telefonica.manifestcheck.testutil.AndroidProjectExtension +import com.telefonica.manifestcheck.testutil.TestVersions +import com.telefonica.manifestcheck.testutil.outcomeOf import org.gradle.kotlin.dsl.support.normaliseLineSeparators import org.gradle.testkit.runner.TaskOutcome import org.junit.jupiter.api.Assertions.* @@ -14,7 +14,8 @@ class MultiVariantPermissionCheckIntegrationTest { @JvmField @RegisterExtension - val androidProject = AndroidProjectExtension() + val androidProject = + AndroidProjectExtension() @ParameterizedTest @ArgumentsSource(TestVersions::class) diff --git a/manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/SingleVariantPermissionCheckIntegrationTest.kt b/manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/SingleVariantPermissionCheckIntegrationTest.kt similarity index 97% rename from manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/SingleVariantPermissionCheckIntegrationTest.kt rename to manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/SingleVariantPermissionCheckIntegrationTest.kt index dfc5c15..5b6725b 100644 --- a/manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/SingleVariantPermissionCheckIntegrationTest.kt +++ b/manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/SingleVariantPermissionCheckIntegrationTest.kt @@ -1,8 +1,8 @@ -package io.github.simonschiller.permissioncheck +package com.telefonica.manifestcheck -import io.github.simonschiller.permissioncheck.testutil.AndroidProjectExtension -import io.github.simonschiller.permissioncheck.testutil.TestVersions -import io.github.simonschiller.permissioncheck.testutil.outcomeOf +import com.telefonica.manifestcheck.testutil.AndroidProjectExtension +import com.telefonica.manifestcheck.testutil.TestVersions +import com.telefonica.manifestcheck.testutil.outcomeOf import org.gradle.kotlin.dsl.support.normaliseLineSeparators import org.gradle.testkit.runner.TaskOutcome import org.junit.jupiter.api.Assertions.* @@ -14,7 +14,8 @@ class SingleVariantPermissionCheckIntegrationTest { @JvmField @RegisterExtension - val androidProject = AndroidProjectExtension() + val androidProject = + AndroidProjectExtension() @ParameterizedTest @ArgumentsSource(TestVersions::class) diff --git a/manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/testutil/AndroidProjectExtension.kt b/manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/testutil/AndroidProjectExtension.kt similarity index 99% rename from manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/testutil/AndroidProjectExtension.kt rename to manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/testutil/AndroidProjectExtension.kt index 39ccb7b..47314d5 100644 --- a/manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/testutil/AndroidProjectExtension.kt +++ b/manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/testutil/AndroidProjectExtension.kt @@ -1,4 +1,4 @@ -package io.github.simonschiller.permissioncheck.testutil +package com.telefonica.manifestcheck.testutil import org.gradle.kotlin.dsl.support.normaliseLineSeparators import org.gradle.testkit.runner.BuildResult diff --git a/manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/testutil/AndroidProjectExtensionTest.kt b/manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/testutil/AndroidProjectExtensionTest.kt similarity index 58% rename from manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/testutil/AndroidProjectExtensionTest.kt rename to manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/testutil/AndroidProjectExtensionTest.kt index 9cd0b4c..1fc2bd7 100644 --- a/manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/testutil/AndroidProjectExtensionTest.kt +++ b/manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/testutil/AndroidProjectExtensionTest.kt @@ -1,4 +1,4 @@ -package io.github.simonschiller.permissioncheck.testutil +package com.telefonica.manifestcheck.testutil import org.junit.jupiter.api.Test import org.junit.jupiter.api.extension.RegisterExtension @@ -7,15 +7,16 @@ class AndroidProjectExtensionTest { @JvmField @RegisterExtension - val androidProject = AndroidProjectExtension() + val androidProject = + AndroidProjectExtension() @Test fun `AndroidProjectExtension creates project that works correctly`() { androidProject.runTask( "tasks", "--all", - gradleVersion = TestVersions.LATEST_GRADLE_VERSION, - agpVersion = TestVersions.LATEST_AGP_VERSION + gradleVersion = TestVersions.Companion.LATEST_GRADLE_VERSION, + agpVersion = TestVersions.Companion.LATEST_AGP_VERSION ) } } diff --git a/manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/testutil/TestVersions.kt b/manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/testutil/TestVersions.kt similarity index 92% rename from manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/testutil/TestVersions.kt rename to manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/testutil/TestVersions.kt index 7dde024..5780fc0 100644 --- a/manifestcheck/src/test/kotlin/io/github/simonschiller/permissioncheck/testutil/TestVersions.kt +++ b/manifestcheck/src/test/kotlin/com/telefonica/manifestcheck/testutil/TestVersions.kt @@ -1,4 +1,4 @@ -package io.github.simonschiller.permissioncheck.testutil +package com.telefonica.manifestcheck.testutil import org.junit.jupiter.api.extension.ExtensionContext import org.junit.jupiter.params.provider.Arguments @@ -7,6 +7,7 @@ import java.util.stream.Stream class TestVersions : ArgumentsProvider { + @Suppress("DEPRECATION") override fun provideArguments(context: ExtensionContext): Stream { val arguments = AGP_VERSIONS.flatMap { agpVersion -> GRADLE_VERSIONS diff --git a/plugin-configurator-v1/src/main/kotlin/io/github/simonschiller/permissioncheck/config/TaskConfiguratorV1.kt b/plugin-configurator-v1/src/main/kotlin/com/telefonica/manifestcheck/config/TaskConfiguratorV1.kt similarity index 88% rename from plugin-configurator-v1/src/main/kotlin/io/github/simonschiller/permissioncheck/config/TaskConfiguratorV1.kt rename to plugin-configurator-v1/src/main/kotlin/com/telefonica/manifestcheck/config/TaskConfiguratorV1.kt index 68c9313..dd1e1c3 100644 --- a/plugin-configurator-v1/src/main/kotlin/io/github/simonschiller/permissioncheck/config/TaskConfiguratorV1.kt +++ b/plugin-configurator-v1/src/main/kotlin/com/telefonica/manifestcheck/config/TaskConfiguratorV1.kt @@ -1,8 +1,8 @@ -package io.github.simonschiller.permissioncheck.config +package com.telefonica.manifestcheck.config import com.android.build.api.artifact.SingleArtifact import com.android.build.api.variant.AndroidComponentsExtension -import io.github.simonschiller.permissioncheck.PermissionCheckExtension +import com.telefonica.manifestcheck.PermissionCheckExtension import org.gradle.api.Project /** Configures the tasks for AGP versions 7.0.0-alpha01 and above. */ @@ -24,4 +24,4 @@ class TaskConfiguratorV1 : TaskConfigurator() { } } } -} +} \ No newline at end of file diff --git a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/PermissionCheckExtension.kt b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/PermissionCheckExtension.kt similarity index 95% rename from plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/PermissionCheckExtension.kt rename to plugin-core/src/main/kotlin/com/telefonica/manifestcheck/PermissionCheckExtension.kt index 7a14556..58036d0 100644 --- a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/PermissionCheckExtension.kt +++ b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/PermissionCheckExtension.kt @@ -1,4 +1,4 @@ -package io.github.simonschiller.permissioncheck +package com.telefonica.manifestcheck import org.gradle.api.file.* import org.gradle.api.model.ObjectFactory diff --git a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/PermissionCheckTask.kt b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/PermissionCheckTask.kt similarity index 87% rename from plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/PermissionCheckTask.kt rename to plugin-core/src/main/kotlin/com/telefonica/manifestcheck/PermissionCheckTask.kt index 8fb01d8..e22c7e6 100644 --- a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/PermissionCheckTask.kt +++ b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/PermissionCheckTask.kt @@ -1,11 +1,11 @@ -package io.github.simonschiller.permissioncheck - -import io.github.simonschiller.permissioncheck.internal.BaselineHandler -import io.github.simonschiller.permissioncheck.internal.ManifestParser -import io.github.simonschiller.permissioncheck.internal.PermissionChecker -import io.github.simonschiller.permissioncheck.internal.report.HtmlReporter -import io.github.simonschiller.permissioncheck.internal.report.LogReporter -import io.github.simonschiller.permissioncheck.internal.report.XmlReporter +package com.telefonica.manifestcheck + +import com.telefonica.manifestcheck.internal.BaselineHandler +import com.telefonica.manifestcheck.internal.ManifestParser +import com.telefonica.manifestcheck.internal.PermissionChecker +import com.telefonica.manifestcheck.internal.report.HtmlReporter +import com.telefonica.manifestcheck.internal.report.LogReporter +import com.telefonica.manifestcheck.internal.report.XmlReporter import org.gradle.api.DefaultTask import org.gradle.api.GradleException import org.gradle.api.file.RegularFile @@ -66,7 +66,8 @@ open class PermissionCheckTask : DefaultTask() { val permissions = variants.get().zip(manifestPermissions).toMap() val baselineFile = baseline.get().asFile - val baselineHandler = BaselineHandler(baselineFile) + val baselineHandler = + BaselineHandler(baselineFile) // Create (or recreate) the baseline if needed if (recreate.get() || !baselineFile.exists()) { @@ -87,7 +88,8 @@ open class PermissionCheckTask : DefaultTask() { } // Make sure the current permissions match the ones from the baseline - val permissionChecker = PermissionChecker() + val permissionChecker = + PermissionChecker() val violations = permissions.mapValues { (variantName, variantPermissions) -> permissionChecker.findViolations(baselinePermissions.getValue(variantName), variantPermissions, strict.get()) } diff --git a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/config/TaskConfigurator.kt b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/config/TaskConfigurator.kt similarity index 91% rename from plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/config/TaskConfigurator.kt rename to plugin-core/src/main/kotlin/com/telefonica/manifestcheck/config/TaskConfigurator.kt index eec6898..e4ad1b7 100644 --- a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/config/TaskConfigurator.kt +++ b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/config/TaskConfigurator.kt @@ -1,11 +1,11 @@ -package io.github.simonschiller.permissioncheck.config +package com.telefonica.manifestcheck.config -import io.github.simonschiller.permissioncheck.PermissionCheckExtension -import io.github.simonschiller.permissioncheck.PermissionCheckTask +import com.telefonica.manifestcheck.PermissionCheckExtension +import com.telefonica.manifestcheck.PermissionCheckTask import org.gradle.api.Project import org.gradle.api.tasks.TaskProvider import org.gradle.language.base.plugins.LifecycleBasePlugin -import java.util.* +import java.util.Locale /** * Base class to configure the Gradle tasks, different implementations are used to stay compatible with older AGP @@ -59,4 +59,4 @@ abstract class TaskConfigurator { task.strict.set(extension.strict) } } -} +} \ No newline at end of file diff --git a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/BaselineHandler.kt b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/BaselineHandler.kt similarity index 75% rename from plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/BaselineHandler.kt rename to plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/BaselineHandler.kt index e7f171d..3cd1695 100644 --- a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/BaselineHandler.kt +++ b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/BaselineHandler.kt @@ -1,13 +1,13 @@ -package io.github.simonschiller.permissioncheck.internal - -import io.github.simonschiller.permissioncheck.internal.data.BasePermission -import io.github.simonschiller.permissioncheck.internal.data.Feature -import io.github.simonschiller.permissioncheck.internal.data.Permission -import io.github.simonschiller.permissioncheck.internal.data.Sdk23Permission -import io.github.simonschiller.permissioncheck.internal.util.appendElement -import io.github.simonschiller.permissioncheck.internal.util.createDocumentBuilder -import io.github.simonschiller.permissioncheck.internal.util.forEach -import io.github.simonschiller.permissioncheck.internal.util.writeToFile +package com.telefonica.manifestcheck.internal + +import com.telefonica.manifestcheck.internal.data.BasePermission +import com.telefonica.manifestcheck.internal.data.Feature +import com.telefonica.manifestcheck.internal.data.Permission +import com.telefonica.manifestcheck.internal.data.Sdk23Permission +import com.telefonica.manifestcheck.internal.util.appendElement +import com.telefonica.manifestcheck.internal.util.createDocumentBuilder +import com.telefonica.manifestcheck.internal.util.forEach +import com.telefonica.manifestcheck.internal.util.writeToFile import java.io.File internal class BaselineHandler(private val baselineFile: File) { @@ -26,7 +26,8 @@ internal class BaselineHandler(private val baselineFile: File) { } // Package changes into a XML document - val document = createDocumentBuilder().newDocument() + val document = createDocumentBuilder() + .newDocument() document.appendElement("baseline") { baseline.toSortedMap().forEach { (variantName, variantPermissions) -> @@ -68,7 +69,10 @@ internal class BaselineHandler(private val baselineFile: File) { regularPermissions.forEach { element -> val name = element.getAttribute("name") val maxSdkVersion = element.getAttribute("maxSdkVersion").toIntOrNull() - variantPermissions += Permission(name, maxSdkVersion) + variantPermissions += Permission( + name, + maxSdkVersion + ) } // Parse SDK 23 permissions for variant @@ -76,7 +80,10 @@ internal class BaselineHandler(private val baselineFile: File) { sdk23Permissions.forEach { element -> val name = element.getAttribute("name") val maxSdkVersion = element.getAttribute("maxSdkVersion").toIntOrNull() - variantPermissions += Sdk23Permission(name, maxSdkVersion) + variantPermissions += Sdk23Permission( + name, + maxSdkVersion + ) } val features = variant.getElementsByTagName("uses-feature") @@ -84,7 +91,11 @@ internal class BaselineHandler(private val baselineFile: File) { val name = element.getAttribute("name") val required = element.getAttribute("required").toBooleanStrictOrNull() val glEsVersion = element.getAttribute("glEsVersion").takeIf { it.isNotEmpty() } - variantPermissions += Feature(name, required, glEsVersion) + variantPermissions += Feature( + name, + required, + glEsVersion + ) } permissions[variantName] = variantPermissions diff --git a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/ManifestParser.kt b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/ManifestParser.kt similarity index 77% rename from plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/ManifestParser.kt rename to plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/ManifestParser.kt index f761177..78ec8c8 100644 --- a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/ManifestParser.kt +++ b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/ManifestParser.kt @@ -1,11 +1,11 @@ -package io.github.simonschiller.permissioncheck.internal - -import io.github.simonschiller.permissioncheck.internal.data.BasePermission -import io.github.simonschiller.permissioncheck.internal.data.Feature -import io.github.simonschiller.permissioncheck.internal.data.Permission -import io.github.simonschiller.permissioncheck.internal.data.Sdk23Permission -import io.github.simonschiller.permissioncheck.internal.util.createDocumentBuilder -import io.github.simonschiller.permissioncheck.internal.util.forEach +package com.telefonica.manifestcheck.internal + +import com.telefonica.manifestcheck.internal.data.BasePermission +import com.telefonica.manifestcheck.internal.data.Feature +import com.telefonica.manifestcheck.internal.data.Permission +import com.telefonica.manifestcheck.internal.data.Sdk23Permission +import com.telefonica.manifestcheck.internal.util.createDocumentBuilder +import com.telefonica.manifestcheck.internal.util.forEach import org.w3c.dom.Document import java.io.File diff --git a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/PermissionChecker.kt b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/PermissionChecker.kt similarity index 93% rename from plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/PermissionChecker.kt rename to plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/PermissionChecker.kt index 08f3733..8ec9803 100644 --- a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/PermissionChecker.kt +++ b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/PermissionChecker.kt @@ -1,7 +1,7 @@ -package io.github.simonschiller.permissioncheck.internal +package com.telefonica.manifestcheck.internal -import io.github.simonschiller.permissioncheck.internal.data.BasePermission -import io.github.simonschiller.permissioncheck.internal.data.Violation +import com.telefonica.manifestcheck.internal.data.BasePermission +import com.telefonica.manifestcheck.internal.data.Violation internal class PermissionChecker { diff --git a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/data/Permissions.kt b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/data/Permissions.kt similarity index 98% rename from plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/data/Permissions.kt rename to plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/data/Permissions.kt index 0640eba..9289e30 100644 --- a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/data/Permissions.kt +++ b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/data/Permissions.kt @@ -1,4 +1,4 @@ -package io.github.simonschiller.permissioncheck.internal.data +package com.telefonica.manifestcheck.internal.data import org.w3c.dom.Document import org.w3c.dom.Element diff --git a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/data/Violation.kt b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/data/Violation.kt similarity index 98% rename from plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/data/Violation.kt rename to plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/data/Violation.kt index 36f5bea..be5ec0f 100644 --- a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/data/Violation.kt +++ b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/data/Violation.kt @@ -1,4 +1,4 @@ -package io.github.simonschiller.permissioncheck.internal.data +package com.telefonica.manifestcheck.internal.data import org.w3c.dom.Document import org.w3c.dom.Element diff --git a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/report/HtmlReporter.kt b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/report/HtmlReporter.kt similarity index 92% rename from plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/report/HtmlReporter.kt rename to plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/report/HtmlReporter.kt index a2bb1b8..221e7e0 100644 --- a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/report/HtmlReporter.kt +++ b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/report/HtmlReporter.kt @@ -1,14 +1,15 @@ -package io.github.simonschiller.permissioncheck.internal.report +package com.telefonica.manifestcheck.internal.report -import io.github.simonschiller.permissioncheck.internal.data.Violation -import io.github.simonschiller.permissioncheck.internal.util.appendElement -import io.github.simonschiller.permissioncheck.internal.util.createDocumentBuilder -import io.github.simonschiller.permissioncheck.internal.util.writeToFile +import com.telefonica.manifestcheck.internal.data.Violation +import com.telefonica.manifestcheck.internal.util.appendElement +import com.telefonica.manifestcheck.internal.util.createDocumentBuilder +import com.telefonica.manifestcheck.internal.util.writeToFile import org.w3c.dom.Element import org.w3c.dom.Node import java.io.File -internal class HtmlReporter(private val reportFile: File) : Reporter { +internal class HtmlReporter(private val reportFile: File) : + Reporter { // Only HTML report files are allowed init { diff --git a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/report/LogReporter.kt b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/report/LogReporter.kt similarity index 78% rename from plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/report/LogReporter.kt rename to plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/report/LogReporter.kt index c46dff4..ec8d763 100644 --- a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/report/LogReporter.kt +++ b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/report/LogReporter.kt @@ -1,9 +1,10 @@ -package io.github.simonschiller.permissioncheck.internal.report +package com.telefonica.manifestcheck.internal.report -import io.github.simonschiller.permissioncheck.internal.data.Violation +import com.telefonica.manifestcheck.internal.data.Violation import org.gradle.api.logging.Logger -internal class LogReporter(private val logger: Logger) : Reporter { +internal class LogReporter(private val logger: Logger) : + Reporter { override fun report(violations: Map>) { val faultyVariants = violations.filterValues { it.isNotEmpty() } diff --git a/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/report/Reporter.kt b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/report/Reporter.kt new file mode 100644 index 0000000..8b532d1 --- /dev/null +++ b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/report/Reporter.kt @@ -0,0 +1,7 @@ +package com.telefonica.manifestcheck.internal.report + +import com.telefonica.manifestcheck.internal.data.Violation + +internal interface Reporter { + fun report(violations: Map>) +} diff --git a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/report/XmlReporter.kt b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/report/XmlReporter.kt similarity index 66% rename from plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/report/XmlReporter.kt rename to plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/report/XmlReporter.kt index 048f759..65c6ba5 100644 --- a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/report/XmlReporter.kt +++ b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/report/XmlReporter.kt @@ -1,12 +1,13 @@ -package io.github.simonschiller.permissioncheck.internal.report +package com.telefonica.manifestcheck.internal.report -import io.github.simonschiller.permissioncheck.internal.data.Violation -import io.github.simonschiller.permissioncheck.internal.util.appendElement -import io.github.simonschiller.permissioncheck.internal.util.createDocumentBuilder -import io.github.simonschiller.permissioncheck.internal.util.writeToFile +import com.telefonica.manifestcheck.internal.data.Violation +import com.telefonica.manifestcheck.internal.util.appendElement +import com.telefonica.manifestcheck.internal.util.createDocumentBuilder +import com.telefonica.manifestcheck.internal.util.writeToFile import java.io.File -internal class XmlReporter(private val reportFile: File) : Reporter { +internal class XmlReporter(private val reportFile: File) : + Reporter { // Only XML report files are allowed init { diff --git a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/util/XmlUtils.kt b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/util/XmlUtils.kt similarity index 96% rename from plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/util/XmlUtils.kt rename to plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/util/XmlUtils.kt index 9dc4ac3..738ea54 100644 --- a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/util/XmlUtils.kt +++ b/plugin-core/src/main/kotlin/com/telefonica/manifestcheck/internal/util/XmlUtils.kt @@ -1,4 +1,4 @@ -package io.github.simonschiller.permissioncheck.internal.util +package com.telefonica.manifestcheck.internal.util import org.w3c.dom.Document import org.w3c.dom.Element diff --git a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/report/Reporter.kt b/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/report/Reporter.kt deleted file mode 100644 index e26a0df..0000000 --- a/plugin-core/src/main/kotlin/io/github/simonschiller/permissioncheck/internal/report/Reporter.kt +++ /dev/null @@ -1,7 +0,0 @@ -package io.github.simonschiller.permissioncheck.internal.report - -import io.github.simonschiller.permissioncheck.internal.data.Violation - -internal interface Reporter { - fun report(violations: Map>) -} diff --git a/plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/BaselineHandlerTest.kt b/plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/BaselineHandlerTest.kt similarity index 92% rename from plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/BaselineHandlerTest.kt rename to plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/BaselineHandlerTest.kt index 10b8cf7..be94bee 100644 --- a/plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/BaselineHandlerTest.kt +++ b/plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/BaselineHandlerTest.kt @@ -1,7 +1,8 @@ -package io.github.simonschiller.permissioncheck.internal +package com.telefonica.simonschiller.permissioncheck.internal -import io.github.simonschiller.permissioncheck.internal.data.Permission -import io.github.simonschiller.permissioncheck.internal.data.Sdk23Permission +import com.telefonica.manifestcheck.internal.BaselineHandler +import com.telefonica.manifestcheck.internal.data.Permission +import com.telefonica.manifestcheck.internal.data.Sdk23Permission import org.gradle.kotlin.dsl.support.normaliseLineSeparators import org.junit.jupiter.api.Assertions.assertEquals import org.junit.jupiter.api.Assertions.assertTrue @@ -26,7 +27,8 @@ class BaselineHandlerTest { Sdk23Permission("android.permission.WRITE_EXTERNAL_STORAGE", 26) ) - val baselineHandler = BaselineHandler(baselineFile) + val baselineHandler = + BaselineHandler(baselineFile) baselineHandler.serialize(mapOf("debug" to permissions)) val expectedBaselineContent = """ @@ -63,7 +65,8 @@ class BaselineHandlerTest { Sdk23Permission("android.permission.INTERNET") ) - val baselineHandler = BaselineHandler(baselineFile) + val baselineHandler = + BaselineHandler(baselineFile) baselineHandler.serialize(mapOf("debug" to permissions)) val expectedBaselineContent = """ @@ -101,7 +104,8 @@ class BaselineHandlerTest { Sdk23Permission("android.permission.WRITE_EXTERNAL_STORAGE", 26) ) - val baselineHandler = BaselineHandler(baselineFile) + val baselineHandler = + BaselineHandler(baselineFile) baselineHandler.serialize(mapOf("debug" to permissions)) val expectedBaselineContent = """ @@ -131,7 +135,8 @@ class BaselineHandlerTest { Sdk23Permission("android.permission.INTERNET") ) - val baselineHandler = BaselineHandler(baselineFile) + val baselineHandler = + BaselineHandler(baselineFile) baselineHandler.serialize(mapOf("debug" to permissions)) val expectedBaselineContent = """ @@ -161,7 +166,8 @@ class BaselineHandlerTest { Sdk23Permission("android.permission.WRITE_EXTERNAL_STORAGE", 26) ) - val baselineHandler = BaselineHandler(baselineFile) + val baselineHandler = + BaselineHandler(baselineFile) baselineHandler.serialize(mapOf("debug" to debugPermissions, "release" to releasePermissions)) val expectedBaselineContent = """ @@ -199,7 +205,8 @@ class BaselineHandlerTest { """.trimIndent()) - val baselineHandler = BaselineHandler(baselineFile) + val baselineHandler = + BaselineHandler(baselineFile) val baseline = baselineHandler.deserialize() val debugPermissions = setOf( @@ -219,7 +226,8 @@ class BaselineHandlerTest { fun `Non-existent baseline file is interpreted as empty`() { val baselineFile = tempDir.resolve("permission-baseline.xml") - val baselineHandler = BaselineHandler(baselineFile) + val baselineHandler = + BaselineHandler(baselineFile) val baseline = baselineHandler.deserialize() assertTrue(baseline.isEmpty()) @@ -228,7 +236,11 @@ class BaselineHandlerTest { @Test fun `Exception is thrown if baseline file has wrong type`() { val baselineFile = tempDir.resolve("permission-baseline.json") - assertThrows { BaselineHandler(baselineFile) } + assertThrows { + BaselineHandler( + baselineFile + ) + } } @Test @@ -250,7 +262,8 @@ class BaselineHandlerTest { Sdk23Permission("android.permission.INTERNET") ) - val baselineHandler = BaselineHandler(baselineFile) + val baselineHandler = + BaselineHandler(baselineFile) baselineHandler.serialize(mapOf("debug" to debugPermissions)) val expectedBaselineContent = """ @@ -288,7 +301,8 @@ class BaselineHandlerTest { """.trimIndent()) - val baselineHandler = BaselineHandler(baselineFile) + val baselineHandler = + BaselineHandler(baselineFile) baselineHandler.serialize(emptyMap()) val expectedBaselineContent = """ diff --git a/plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/ManifestParserTest.kt b/plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/ManifestParserTest.kt similarity index 85% rename from plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/ManifestParserTest.kt rename to plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/ManifestParserTest.kt index 6b24786..d17ebd4 100644 --- a/plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/ManifestParserTest.kt +++ b/plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/ManifestParserTest.kt @@ -1,7 +1,8 @@ -package io.github.simonschiller.permissioncheck.internal +package com.telefonica.simonschiller.permissioncheck.internal -import io.github.simonschiller.permissioncheck.internal.data.Permission -import io.github.simonschiller.permissioncheck.internal.data.Sdk23Permission +import com.telefonica.manifestcheck.internal.ManifestParser +import com.telefonica.manifestcheck.internal.data.Permission +import com.telefonica.manifestcheck.internal.data.Sdk23Permission import org.junit.jupiter.api.Assertions.assertEquals import org.junit.jupiter.api.Test import org.junit.jupiter.api.assertThrows @@ -10,7 +11,8 @@ import java.io.File import java.io.FileNotFoundException class ManifestParserTest { - private val manifestParser = ManifestParser() + private val manifestParser = + ManifestParser() @TempDir lateinit var tempDir: File diff --git a/plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/PermissionCheckerTest.kt b/plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/PermissionCheckerTest.kt similarity index 94% rename from plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/PermissionCheckerTest.kt rename to plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/PermissionCheckerTest.kt index 78bd9db..53223bb 100644 --- a/plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/PermissionCheckerTest.kt +++ b/plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/PermissionCheckerTest.kt @@ -1,14 +1,16 @@ -package io.github.simonschiller.permissioncheck.internal +package com.telefonica.simonschiller.permissioncheck.internal -import io.github.simonschiller.permissioncheck.internal.data.BasePermission -import io.github.simonschiller.permissioncheck.internal.data.Permission -import io.github.simonschiller.permissioncheck.internal.data.Sdk23Permission -import io.github.simonschiller.permissioncheck.internal.data.Violation +import com.telefonica.manifestcheck.internal.PermissionChecker +import com.telefonica.manifestcheck.internal.data.BasePermission +import com.telefonica.manifestcheck.internal.data.Permission +import com.telefonica.manifestcheck.internal.data.Sdk23Permission +import com.telefonica.manifestcheck.internal.data.Violation import org.junit.jupiter.api.Assertions.assertEquals import org.junit.jupiter.api.Test class PermissionCheckerTest { - private val permissionChecker = PermissionChecker() + private val permissionChecker = + PermissionChecker() @Test fun `No violations are found if permissions match`() { diff --git a/plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/data/PermissionsTest.kt b/plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/data/PermissionsTest.kt similarity index 69% rename from plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/data/PermissionsTest.kt rename to plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/data/PermissionsTest.kt index b475397..4a2137b 100644 --- a/plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/data/PermissionsTest.kt +++ b/plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/data/PermissionsTest.kt @@ -1,5 +1,7 @@ -package io.github.simonschiller.permissioncheck.internal.data +package com.telefonica.simonschiller.permissioncheck.internal.data +import com.telefonica.manifestcheck.internal.data.Permission +import com.telefonica.manifestcheck.internal.data.Sdk23Permission import org.junit.jupiter.api.Assertions.* import org.junit.jupiter.api.Test @@ -7,42 +9,62 @@ class PermissionsTest { @Test fun `Same types of permissions with same content are equal`() { - val a = Permission("android.permission.INTERNET", 26) - val b = Permission("android.permission.INTERNET", 26) + val a = Permission( + "android.permission.INTERNET", + 26 + ) + val b = Permission( + "android.permission.INTERNET", + 26 + ) assertEquals(a, b) } @Test fun `Different types of permissions with same content are not equal`() { - val a = Permission("android.permission.INTERNET", 26) - val b = Sdk23Permission("android.permission.INTERNET", 26) + val a = Permission( + "android.permission.INTERNET", + 26 + ) + val b = Sdk23Permission( + "android.permission.INTERNET", + 26 + ) assertNotEquals(a, b) } @Test fun `XML representation is correct for normal permissions`() { - val permission = Permission("android.permission.INTERNET") + val permission = + Permission("android.permission.INTERNET") val xml = """""" assertEquals(xml, permission.toString()) } @Test fun `XML representation is correct for normal permissions with max SDK`() { - val permission = Permission("android.permission.INTERNET", 26) + val permission = Permission( + "android.permission.INTERNET", + 26 + ) val xml = """""" assertEquals(xml, permission.toString()) } @Test fun `XML representation is correct for SDK 23 permissions`() { - val permission = Sdk23Permission("android.permission.INTERNET") + val permission = + Sdk23Permission("android.permission.INTERNET") val xml = """""" assertEquals(xml, permission.toString()) } @Test fun `XML representation is correct for SDK 23 permissions with max SDK`() { - val permission = Sdk23Permission("android.permission.INTERNET", 26) + val permission = Sdk23Permission( + "android.permission.INTERNET", + 26 + ) val xml = """""" assertEquals(xml, permission.toString()) } @@ -67,7 +89,10 @@ class PermissionsTest { @Test fun `Copying permissions works`() { - val original = Permission("android.permission.CAMERA", 26) + val original = Permission( + "android.permission.CAMERA", + 26 + ) val exactCopy = original.copy(required = false, glEsVersion = null) assertEquals(original, exactCopy) diff --git a/plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/report/HtmlReporterTest.kt b/plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/report/HtmlReporterTest.kt similarity index 95% rename from plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/report/HtmlReporterTest.kt rename to plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/report/HtmlReporterTest.kt index e24b777..cf4ccd8 100644 --- a/plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/report/HtmlReporterTest.kt +++ b/plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/report/HtmlReporterTest.kt @@ -1,8 +1,9 @@ -package io.github.simonschiller.permissioncheck.internal.report +package com.telefonica.simonschiller.permissioncheck.internal.report -import io.github.simonschiller.permissioncheck.internal.data.Permission -import io.github.simonschiller.permissioncheck.internal.data.Sdk23Permission -import io.github.simonschiller.permissioncheck.internal.data.Violation +import com.telefonica.manifestcheck.internal.report.HtmlReporter +import com.telefonica.manifestcheck.internal.data.Permission +import com.telefonica.manifestcheck.internal.data.Sdk23Permission +import com.telefonica.manifestcheck.internal.data.Violation import org.gradle.kotlin.dsl.support.normaliseLineSeparators import org.junit.jupiter.api.Assertions.assertEquals import org.junit.jupiter.api.Test @@ -18,7 +19,8 @@ class HtmlReporterTest { @Test fun `Empty report is generated when there are no issues`() { val reportFile = tempDir.resolve("report.html") - val reporter = HtmlReporter(reportFile) + val reporter = + HtmlReporter(reportFile) val violations = emptyList() reporter.report(mapOf("debug" to violations, "release" to violations)) @@ -67,7 +69,8 @@ class HtmlReporterTest { @Test fun `Generated report contains all violations when they exist`() { val reportFile = tempDir.resolve("report.html") - val reporter = HtmlReporter(reportFile) + val reporter = + HtmlReporter(reportFile) val debugViolations = listOf( Violation.Added(Permission("android.permission.CAMERA")), @@ -155,7 +158,8 @@ class HtmlReporterTest { @Test fun `Report is generated correctly if some of the variants contain no issues`() { val reportFile = tempDir.resolve("report.html") - val reporter = HtmlReporter(reportFile) + val reporter = + HtmlReporter(reportFile) val debugViolations = listOf( Violation.Added(Permission("android.permission.CAMERA")), @@ -223,7 +227,11 @@ class HtmlReporterTest { @Test fun `Exception is thrown if report file has wrong type`() { val reportFile = tempDir.resolve("report.json") - assertThrows { HtmlReporter(reportFile) } + assertThrows { + HtmlReporter( + reportFile + ) + } } private fun String.removeStyleTags(): String { diff --git a/plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/report/LogReporterTest.kt b/plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/report/LogReporterTest.kt similarity index 88% rename from plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/report/LogReporterTest.kt rename to plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/report/LogReporterTest.kt index fc260b7..ae19577 100644 --- a/plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/report/LogReporterTest.kt +++ b/plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/report/LogReporterTest.kt @@ -1,8 +1,9 @@ -package io.github.simonschiller.permissioncheck.internal.report +package com.telefonica.simonschiller.permissioncheck.internal.report -import io.github.simonschiller.permissioncheck.internal.data.Permission -import io.github.simonschiller.permissioncheck.internal.data.Sdk23Permission -import io.github.simonschiller.permissioncheck.internal.data.Violation +import com.telefonica.manifestcheck.internal.report.LogReporter +import com.telefonica.manifestcheck.internal.data.Permission +import com.telefonica.manifestcheck.internal.data.Sdk23Permission +import com.telefonica.manifestcheck.internal.data.Violation import org.gradle.api.logging.Logger import org.gradle.api.logging.Logging import org.junit.jupiter.api.Assertions.assertEquals @@ -13,7 +14,8 @@ class LogReporterTest { @Test fun `Success message is logged when there are no violations`() { val logger = TestLogger() - val reporter = LogReporter(logger) + val reporter = + LogReporter(logger) val violations = emptyList() reporter.report(mapOf("debug" to violations, "release" to violations)) @@ -27,7 +29,8 @@ class LogReporterTest { @Test fun `Violations are logged if they exist`() { val logger = TestLogger() - val reporter = LogReporter(logger) + val reporter = + LogReporter(logger) val violations = listOf( Violation.Added(Permission("android.permission.CAMERA")), @@ -50,7 +53,8 @@ class LogReporterTest { @Test fun `Violations for multiple variants are logged separately`() { val logger = TestLogger() - val reporter = LogReporter(logger) + val reporter = + LogReporter(logger) val debugViolations = listOf( Violation.Added(Permission("android.permission.CAMERA")), diff --git a/plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/report/XmlReporterTest.kt b/plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/report/XmlReporterTest.kt similarity index 84% rename from plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/report/XmlReporterTest.kt rename to plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/report/XmlReporterTest.kt index 941b192..b971c3b 100644 --- a/plugin-core/src/test/kotlin/io/github/simonschiller/permissioncheck/internal/report/XmlReporterTest.kt +++ b/plugin-core/src/test/kotlin/com/telefonica/simonschiller/permissioncheck/internal/report/XmlReporterTest.kt @@ -1,8 +1,9 @@ -package io.github.simonschiller.permissioncheck.internal.report +package com.telefonica.simonschiller.permissioncheck.internal.report -import io.github.simonschiller.permissioncheck.internal.data.Permission -import io.github.simonschiller.permissioncheck.internal.data.Sdk23Permission -import io.github.simonschiller.permissioncheck.internal.data.Violation +import com.telefonica.manifestcheck.internal.report.XmlReporter +import com.telefonica.manifestcheck.internal.data.Permission +import com.telefonica.manifestcheck.internal.data.Sdk23Permission +import com.telefonica.manifestcheck.internal.data.Violation import org.gradle.kotlin.dsl.support.normaliseLineSeparators import org.junit.jupiter.api.Assertions.assertEquals import org.junit.jupiter.api.Test @@ -18,7 +19,8 @@ class XmlReporterTest { @Test fun `Empty report is generated when there are no issues`() { val reportFile = tempDir.resolve("report.xml") - val reporter = XmlReporter(reportFile) + val reporter = + XmlReporter(reportFile) val violations = emptyList() reporter.report(mapOf("debug" to violations, "release" to violations)) @@ -37,7 +39,8 @@ class XmlReporterTest { @Test fun `Generated report contains all violations when they exist`() { val reportFile = tempDir.resolve("report.xml") - val reporter = XmlReporter(reportFile) + val reporter = + XmlReporter(reportFile) val debugViolations = listOf( Violation.Added(Permission("android.permission.CAMERA")), @@ -77,6 +80,10 @@ class XmlReporterTest { @Test fun `Exception is thrown if report file has wrong type`() { val reportFile = tempDir.resolve("report.json") - assertThrows { XmlReporter(reportFile) } + assertThrows { + XmlReporter( + reportFile + ) + } } }