Enforce a max card quantity

[Ajordat]

Currently, the maximum amount of copies for any given card is 65 as enforced here:

if (this.quantity > 65) {
    throw new EncodingError(`Cannot encode card quantity (${this.quantity}) greater than 65`)
}

I was wondering whether instead of failing we should instead limit the quantity:

this.quantity = Math.min(this.quantity, 65)

For sure this should only be relevant when encoding collections, which could cause confusion on users seeing that they "only" own 65 copies of a card instead of the 85 they see on the official app. However, I still think collections should be encoded on a best-effort basis and the whole encoding shouldn't fail because of this.

While I don't know much about Typescript, this is a simple enough change I could make myself in a PR, but I wanted to first discuss what should be the best approach.

[Taum]

Originally I was intending to leave this of behavior to the application code, but if you feel strongly that the library should support this I don’t mind it.

In general I like to keep the expectation that encoding then decoding is a no-op, but this is enough of a niche case that I don’t mind breaking this expectation here.

[Ajordat]

I just tend to think that it's better to provide a response albeit with limitations rather than no response at all.

Another approach would be to accept an optional parameter to indicate a strict or loose encoding, which could lead to this kind of different behavior. However I think this could be more justified if we had other use-cases were we could expect a different behavior, and I don't think that's the situation.

(prepare for a sidetrack)

---

Although I can think of one, and that'd be encoding new sets: If we encounter an unknown set_code, we could create a link between that code and the next id. This would basically be a guess with the expectation that we use autoincrement ids for new sets.

The usage for this is basically to give more room to our tools to update to the next version of this library:
If the library encounters the set "TROPIC" (made up name), it assigns the set_id = 5 (or whatever is next). When attempting to decode, ignore those cards if the set is unknown.
This way, once the library is updated with the new set, it can decode those cards successfully. The encoding, of course, could fail if the upgrade takes two sets to be made.

The above is just an example for a loose encoding mechanism, if strict, simply raise an exception as we're doing right now.

---

What approach would you prefer? I admit that it's a situation so specific that's there's no need to implement such a complex system for something that might be a bad idea altogether.

1. Keep raising an exception.
2. Take the minimum value.
3. Both solutions depending on a "strict" or "loose" mode, with the expectation that in the future we can expand it.

Options 1 and 2 can still be expanded in the future with option 3. I'd go with option 2 for the time being though.