Use frontend URL instead of API URL in ShortcutAndMountPointRedirect

[Digi92]

Describe the bug
Hi,
i noticed that when ShortcutAndMountPointRedirect is triggered, the API URL is written in the redirect instead of the frontend URL.
I suspect that the function call getFrontendUrlWithSite was missing here.
Or is there a specific reason why this function is used in all other redirect locations, but not in this one?

I created a pull request with a change that works for me: #856

To Reproduce
Steps to reproduce the behavior:
In my case, the Forms RedirectFinisher endsup tobe generated by ShortcutAndMountPointRedirect as API Domain, instead of the FrontendDomain.

Expected behavior
The redirect should be always relativ of have the frontendDomains.

TYPO3 version and TYPO3 Headless version
TYPO3 12.4.39
Headless 4.7.3

Best regards
Digi92

[twoldanski]

Hi @Digi92,

thx for creating issue & PR, but we are dealing here with different case,

First of all in headless mode you should not use core RedirectFinisher (or you have some custom one?), because it messes with handling of request of frontend applications (you are doing backend redirect).

You should use JsonRedirect instead https://docs.typo3.org/p/friendsoftypo3/headless/main/en-us/Configuration/Index.html#configuration-ext-form

BTW redirect is should not be 100% relative (we try to do it for FE app, but in some context when you have multisite instance & you want it cross linking site we shouldn't)

[Digi92]

Hi @twoldanski,
as far as I can see, the JsonRedirectFinisher renders the entire page again and only includes the redirect URL in the actionAfterSuccess.
Shouldn’t it instead directly return a JsonResponse with the redirect information?
Because of this, I don’t understand why we need a custom redirect function in Forms at all.

Regardless of the JsonRedirectFinisher, in which scenario is it actually correct that the API URL itself is returned as the redirect target?

My test setup:

1. Clean TYPO3 13.4 installation with Forms and Headless
2. New mount page + subpage
3. A site with Full Headless and the following base configuration:

base: 'https://api.test.local/'
dependencies:
  - mahou/provider-extension-base
  - friendsoftypo3/headless
frontendBase: 'https://www.test.local/'

4. Create a form with a RedirectFinisher that points to the subpage
5. Place the form on the main page
6. Submit the form on the main page
   Actual result:
   {"redirectUrl":"https://api.test.local/en/subpage","statusCode":303}
   Expected result would be either:
   {"redirectUrl":"/en/subpage","statusCode":303}
   or
   {"redirectUrl":"https://www.test.local/en/subpage","statusCode":303}

[twoldanski]

Hi, @Digi92

Ok, I double checked.

Some background:

First of all JsonRedirectFinisher do not render whole page, TYPO3 is, this is default behavior, as I said, this feature was develop to handle backend redirect (backend redirect messes with frontend application).

Next thing, you assume happy path, and only final thing after form validation, but people make mistakes in forms & you should get backend validation results, so we return form response with feedback, so to avoid different responses for success/unsuccessful we have consistent API ( tip: you can use elementBodyResponse feature to grab only form plugin thing & nothing more in response after sending form).

About RedirectFinisher, right now you can technically use it, because with latest headless changes, shortcutMiddleware has small side-effect, when TYPO3 is trying to do backend redirect in the frontend, this middleware grabs it & fix redirect for frontend app, but issue is in case of source of this redirect is RedirectFinisher do not generate absolute link therefore do no properly generate frontend link by headless, and then use backend URL as prefix for link, so finally you have bad link for redirection, when you use JsonRedirect it generates properly frontend link (when headless is properly configured)

So about bad your redirect, quick question do you have headless: 1 flag defined in site configuration? Because when tested Json RedirectFinisher I have relative/absolute link.

Right now we could try to fix edge cases like this case, to allow using RedirectFinisher like you tried, but in most cases link there arrive already frontend link without issues, but I have to check if this will ok in other cases.

[Digi92]

Hi @twoldanski,

sorry for the late reply, I’ve been a bit busy over the last few weeks.

Thanks a lot for double‑checking and for the detailed explanation, that really helped clarify the background and the intended use of the JsonRedirectFinisher for me.

To answer your question: yes, I did have headless: 1 set in the site configuration.
Here is my complete site configuration:

base: 'https://api.test.local/'
dependencies:
  - mahou/provider-extension-base
  - friendsoftypo3/headless
frontendBase: 'https://www.test.local/'
headless: 1
languages:
  -
    title: English
    enabled: true
    languageId: 0
    base: /en/
    locale: en_GB.UTF-8
    navigationTitle: English
    flag: gb
    hreflang: ''
    websiteTitle: ''
  -
    title: Deutsch
    enabled: true
    languageId: 1
    base: /de/
    locale: de_DE.UTF-8
    navigationTitle: Deutsch
    flag: de
    hreflang: ''
    websiteTitle: ''
    fallbackType: strict
    fallbacks: ''
rootPageId: 1
websiteTitle: 'Clean example TYPO3 site'

The provider extension (provider-extension-base) only has a barebone setup to render a simple page and only adds typo3/fluid-styled-content and typo3/form as dependencies.

Do these details help, or do you need any further information from my side?

Best regards
Digi92

[twoldanski]

@Digi92 thx for feedback, to clarify you have bad url (backend url) when using RedirectFinisher or also when using JsonRedirectFinisher , btw why you need typo3/fluid-styled-content? in full headless mode it not necessary

[Digi92]

Hi, thanks for the follow-up.

Configuration:

Regarding typo3/fluid-styled-content: that was only present because my initial clean test setup wasn’t fully headless. I removed it, but the behavior is still the same.

To clarify what I changed in the form configuration:
I only changed the finisher identifier to use the redirect finisher, everything else in that configuration remained unchanged.
This

finishers:
  -
    options:
      pageUid: '2'
      additionalParameters: ''
      fragment: ''
    identifier: Redirect

to this

finishers:
  -
    options:
      pageUid: '2'
      additionalParameters: ''
      fragment: ''
    identifier: JsonRedirect

Responses:

With RedirectFinisher, the response contains the api domain:

{
  "redirectUrl": "https://api.test.local/en/subpage",
  "statusCode": 303
}

With JsonRedirectFinisher, the response returns the form object and includes the correct redirect link inside it:

{
                "id": 1,
                "type": "form_formframework",
                "colPos": 0,
                "categories": "",
                "appearance": {
                    "layout": "default",
                    "frameClass": "default",
                    "spaceBefore": "",
                    "spaceAfter": ""
                },
                "content": {
                    "link": {
                        "href": "/en/?tx_form_formframework%5Baction%5D=perform&tx_form_formframework%5Bcontroller%5D=FormFrontend&cHash=0df93b595c066968fa2515804bd8c324",
                        "target": null,
                        "class": null,
                        "title": null,
                        "linkText": "1",
                        "additionalAttributes": []
                    },
                    "form": {
                        "id": "contact-1",
                        "api": {
                            "status": "success",
                            "errors": null,
                            "actionAfterSuccess": {
                                "redirectUrl": "/en/subpage",
                                "statusCode": 303,
                                "message": null
                            },
                            "page": {
                                "current": 0,
                                "nextPage": null,
                                "pages": 1
                            }
                        },
                        "i18n": {
                            "submitButtonLabel": "Submit"
                        },
                        "elements": [
						…

Best regards
Digi92