Skip to content

Interactive mode scan asking which file to keep #1016

Description

@iammrfrank
  • [ X] I am running the latest version
  • [ X] I checked the documentation / support forum and found no answer
  • [X ] I checked to make sure that this issue has not already been filed
  • [X ] It is a bug (i.e. something that is going wrong) and not a new feature (These should be raised on Feature Upvote)
  • [X ] It is not a general question( these should be asked on the support forum)

Bug Details

Describe the bug
When the user is in interactive (clicks the scan button or checks a single show) and more than 1 file matches something in the directory, they're always getting a prompt to choose which one to keep. The interactive scan is skipping the settings: "Choose between episodes in library when multiple match" and "update episodes when higher-quality ones found in search folders".

Expected Behaviour
If both choose between episodes and high-quality episodes are DISABLED/FALSE, you should not be asked to select a version as there should be no version check happening. It should see there is an episode in place and not ask the user.

Current Behaviour
Regardless of the settings, If you do a manual/interactive scan, the user is always being asked to choose between files if more than 1 match an episode.

To Reproduce
Disable both settings and manually scan while an episode is in the destination folder and there is a match in the search folder. If it finds 2 matching files, it will prompt to choose.

Context

I'm running the Windows version and this only happens on the interactive scan.

Additional context
No other context. I looked through the code and if you change the initial if statement, it will likely fix the problem if my understanding is correct.

if (unattended || (!TVSettings.Instance.ReplaceWithBetterQuality && !TVSettings.Instance.ChooseWhenMultipleEpisodesMatch))

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions