fix: harden skills market delete flow

Author: SurviveM

tests/e2e/run.js

@@ -40,6 +40,10 @@ async function main() {
         ...process.env,
         HOME: tmpHome,
         USERPROFILE: tmpHome,
+        CODEX_HOME: '',
+        CLAUDE_HOME: '',
+        CLAUDE_CONFIG_DIR: '',
+        XDG_CONFIG_HOME: '',
         CODEXMATE_FORCE_RESET_EXISTING_CONFIG: '1',
         CODEXMATE_NO_BROWSER: '1'
     };

tests/unit/skills-market-runtime.test.mjs

@@ -309,3 +309,47 @@ test('skills import entrypoints return early while scan is in progress', async (
     assert.strictEqual(uploadCalls, 0);
     assert.deepStrictEqual(vm.messageLog, []);
 });
+
+test('deleteSelectedSkills reports busy state while import sources scan is running', async () => {
+    let confirmCalls = 0;
+    let apiCalls = 0;
+    const vm = buildVm(async () => {
+        apiCalls += 1;
+        return {};
+    }, {
+        skillsScanningImports: true,
+        skillsSelectedNames: ['alpha'],
+        requestConfirmDialog: async () => {
+            confirmCalls += 1;
+            return true;
+        }
+    });
+
+    await vm.deleteSelectedSkills();
+
+    assert.strictEqual(confirmCalls, 0);
+    assert.strictEqual(apiCalls, 0);
+    assert.deepStrictEqual(vm.messageLog, [{
+        message: '正在扫描导入源，请稍后再试',
+        type: 'error'
+    }]);
+});
+
+test('deleteSelectedSkills wires confirm dialog disabled state to live scan status', async () => {
+    let confirmOptions = null;
+    const vm = buildVm(async () => ({}), {
+        skillsSelectedNames: ['alpha'],
+        requestConfirmDialog: async (options) => {
+            confirmOptions = options;
+            return false;
+        }
+    });
+
+    await vm.deleteSelectedSkills();
+
+    assert(confirmOptions, 'confirm dialog should be opened');
+    assert.strictEqual(typeof confirmOptions.confirmDisabled, 'function');
+    assert.strictEqual(confirmOptions.confirmDisabled.call(vm), false);
+    vm.skillsScanningImports = true;
+    assert.strictEqual(confirmOptions.confirmDisabled.call(vm), true);
+});

tests/unit/skills-modal-ui.test.mjs

@@ -32,7 +32,10 @@ test('skills modal script is modularized and exposes computed/methods from skill
     assert.match(appScript, /\.\.\.createSkillsComputed\(\)/);
     assert.match(appScript, /\.\.\.createSkillsMethods\(\{ api \}\)/);
     assert.match(appScript, /showConfirmDialog:\s*false/);
+    assert.match(appScript, /confirmDialogConfirmDisabled:\s*false/);
+    assert.match(appScript, /confirmDialogDisableWhen:\s*null/);
     assert.match(appScript, /requestConfirmDialog\(/);
+    assert.match(appScript, /isConfirmDialogDisabled\(\)/);
     assert.match(appScript, /resolveConfirmDialog\(/);
 
     assert.match(skillsComputed, /skillsConfiguredCount\(\)/);
@@ -62,6 +65,7 @@ test('skills modal script is modularized and exposes computed/methods from skill
 
 test('skills modal styles define summary and panel layout hooks', () => {
     const styles = readProjectFile('web-ui/styles.css');
+    const html = readProjectFile('web-ui/index.html');
     assert.match(styles, /\.form-select/);
     assert.match(styles, /\.skills-summary-strip/);
     assert.match(styles, /\.skills-summary-item/);
@@ -75,4 +79,5 @@ test('skills modal styles define summary and panel layout hooks', () => {
     assert.match(styles, /\.market-target-chip/);
     assert.doesNotMatch(styles, /\.market-online-toolbar/);
     assert.doesNotMatch(styles, /\.market-ecosystem-card/);
+    assert.match(html, /:disabled="isConfirmDialogDisabled\(\)"/);
 });

web-ui/app.js

@@ -144,6 +144,8 @@ import { createSkillsMethods } from './modules/skills.methods.mjs';
                     confirmDialogConfirmText: '确认',
                     confirmDialogCancelText: '取消',
                     confirmDialogDanger: false,
+                    confirmDialogConfirmDisabled: false,
+                    confirmDialogDisableWhen: null,
                     confirmDialogResolver: null,
                     configTemplateContent: '',
                     configTemplateApplying: false,
@@ -3554,6 +3556,7 @@ import { createSkillsMethods } from './modules/skills.methods.mjs';
                     if (typeof this.confirmDialogResolver === 'function') {
                         this.confirmDialogResolver(false);
                     }
+                    const confirmDisabled = options.confirmDisabled;
                     this.confirmDialogTitle = typeof options.title === 'string' && options.title.trim()
                         ? options.title.trim()
                         : '请确认操作';
@@ -3565,11 +3568,23 @@ import { createSkillsMethods } from './modules/skills.methods.mjs';
                         ? options.cancelText.trim()
                         : '取消';
                     this.confirmDialogDanger = !!options.danger;
+                    this.confirmDialogConfirmDisabled = typeof confirmDisabled === 'function' ? false : !!confirmDisabled;
+                    this.confirmDialogDisableWhen = typeof confirmDisabled === 'function' ? confirmDisabled : null;
                     this.showConfirmDialog = true;
                     return new Promise((resolve) => {
                         this.confirmDialogResolver = resolve;
                     });
                 },
+                isConfirmDialogDisabled() {
+                    if (typeof this.confirmDialogDisableWhen === 'function') {
+                        try {
+                            return !!this.confirmDialogDisableWhen.call(this);
+                        } catch (_) {
+                            return false;
+                        }
+                    }
+                    return !!this.confirmDialogConfirmDisabled;
+                },
                 resolveConfirmDialog(confirmed) {
                     const resolver = typeof this.confirmDialogResolver === 'function'
                         ? this.confirmDialogResolver
@@ -3580,6 +3595,8 @@ import { createSkillsMethods } from './modules/skills.methods.mjs';
                     this.confirmDialogConfirmText = '确认';
                     this.confirmDialogCancelText = '取消';
                     this.confirmDialogDanger = false;
+                    this.confirmDialogConfirmDisabled = false;
+                    this.confirmDialogDisableWhen = null;
                     this.confirmDialogResolver = null;
                     if (resolver) {
                         resolver(!!confirmed);

web-ui/index.html

@@ -2326,6 +2326,7 @@ <h1 class="main-title">
                     <button class="btn btn-cancel" @click="closeConfirmDialog">{{ confirmDialogCancelText }}</button>
                     <button
                         :class="['btn', 'btn-confirm', confirmDialogDanger ? 'btn-danger' : '']"
+                        :disabled="isConfirmDialogDisabled()"
                         @click="resolveConfirmDialog(true)">
                         {{ confirmDialogConfirmText }}
                     </button>

web-ui/modules/skills.methods.mjs

@@ -413,6 +413,10 @@ export function createSkillsMethods({ api }) {
 
         async deleteSelectedSkills() {
             if (this.skillsDeleting || this.skillsZipImporting || this.skillsExporting || this.skillsImporting) return;
+            if (this.skillsScanningImports) {
+                this.showMessage('正在扫描导入源，请稍后再试', 'error');
+                return;
+            }
             const selected = Array.isArray(this.skillsSelectedNames)
                 ? Array.from(new Set(this.skillsSelectedNames.map((item) => String(item || '').trim()).filter(Boolean)))
                 : [];
@@ -425,6 +429,7 @@ export function createSkillsMethods({ api }) {
                 message: `确认从 ${this.skillsTargetLabel} 删除 ${selected.length} 个 skill 吗？此操作不可撤销。`,
                 confirmText: '删除',
                 cancelText: '取消',
+                confirmDisabled: () => this.skillsDeleting || this.skillsScanningImports,
                 danger: true
             });
             if (!confirmed) {