Update to new Minecraft Versions

[StoneLabs]

Current minecraft versions:

• MC 1.21.1 Updating to minecraft 1.21.1 #29
• MC 1.21.2 1.21.2 1.21.3 #30
• MC 1.21.3 1.21.2 1.21.3 #30
• MC 1.21.4 1.21.4 #31
• MC 1.21.5
• MC 1.21.6
• MC 1.21.7
• MC 1.21.8

[StoneLabs]

-> #29 #30 #31

[StoneLabs]

From MC 1.22 onwards i'm thinking about changing the version format to be something like this:

2.0.0-mc1.22.0

That way we would increase the MC version without changing the mod version (e.g. 2.0.0-mc1.22.1). Then when there are actual functional changes to the mod, we would change the minor version e.g. 2.1.0-mc1.22.1. This might make it easier to see if something actually changed, idk.

Thoughts are welcome. @Yuutsuna

[Yuutsuna]

I think you're right. Because of me updating to new minecraft version, the version count jumped a lot while no new things were added. If you only look at the version number you cannot know if it was a feature or an update. Plus it could get confusing if we were to add a new feature for older versions of the mod which makes your approach at naming better.

But I recently found out the following in my logs when I was debugging one of my servers:

[ForkJoinPool-1-worker-2/WARN]: Mod footprintparticle uses the version 0.5.3-mc1.21(.1) which isn't compatible with Loader's extended semantic version format (Invalid prerelease string 'mc1.21(.1)'!), SemVer is recommended for reliably evaluating dependencies and prioritizing newer version

which implies some services need us to use SemVer to provide notification when a new version is available...

I tried to look a bit in other mod repositories to see how they handle it. They either do SemVer + Minecraft version or simply SemVer.
Those who use SemVer configured their build so the jar is named with the minecraft version in the build.graldle which helps a bit the user who manually download the mod. They also seem to have one branch for each minecraft version they maintain. That way when a new feature is added they increment the version in the branch it was added in. If there's a new minecraft version they just have to create a new branch and don't increment the version.
Honnestly it seems to be the best but harder to maintain... Not sure if this is necessary for us

I personally prefer SemVer + mc version

[StoneLabs]

Plus it could get confusing if we were to add a new feature for older versions of the mod

I think this is probably out of scope for the mod anyways (unless it suddently gets hundrets of thousands of downloads lol

I recently found out the following in my logs when I was debugging one of my servers:

I'm not a 100% on this, but in my opinion thats an upstream issue with the loader not the naming format. Plus, it may still work since it looks like in your example just ignores the "prerelease" string at the end.

They either do SemVer + Minecraft version or simply SemVer.

You mean like like this 2.3.0+mc1.2.3? Thats also nice.

Honnestly it seems to be the best but harder to maintain... Not sure if this is necessary for us

Agree, not worth the trouble.

I personally prefer SemVer + mc version

I'm in agreement. 2.3.0+mc1.2.3 Perhaps might be best. Lets upversion to 2.0.0+mc1.22 once the new major mc versions drops.

Thanks for taking the time and giving your feedback. Much appreciated.