Skip to content

Possible mistake in "bool setTypematicRateAndDelay" #4

Description

@kaskalis

Many thanks for this well-coded library.

If I understood the PS/2 keyboard protocol correctly, the number of bits that parameter "startDelay" should be left-shifted is 5 instead of 4 in line 630 of "ps2_Keyboard.h" :

bool setTypematicRateAndDelay(TypematicRate rate, TypematicStartDelay startDelay) {
    byte combined = (byte)rate | (((byte)startDelay) << 4);
    return this->sendCommand(ps2CommandCode::setTypematicRate, combined);
}

Please forgive me if I got it wrong...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions