feat: first use the third-party API for resolving usernames to UUID

The official API is just very unreliable it seems

Author: SpraxDev

src/minecraft/profile/MinecraftProfileService.ts

@@ -132,22 +132,22 @@ export default class MinecraftProfileService {
   }
 
   private async executeUsernameToUuidLookup(username: string): Promise<UsernameToUuidResponse | null> {
-    let firstPartyApiFetchError: Error;
+    let thirdPartyApiFetchError: Error;
 
     try {
-      return await this.minecraftApiClient.fetchUuidForUsername(username);
+      return await this.thirdPartyMinecraftApiClient.fetchUuidForUsername(username);
     } catch (err: any) {
       if (!(err instanceof Error)) {
         throw err;
       }
 
-      firstPartyApiFetchError = err;
+      thirdPartyApiFetchError = err;
     }
 
     try {
-      return await this.thirdPartyMinecraftApiClient.fetchUuidForUsername(username);
-    } catch (thirdPartyApiFetchError: any) {
-      throw new Error('Resolving Username to UUID failed', { cause: [firstPartyApiFetchError, thirdPartyApiFetchError] });
+      return await this.minecraftApiClient.fetchUuidForUsername(username);
+    } catch (firstPartyApiFetchError: any) {
+      throw new Error('Resolving Username to UUID failed', { cause: [thirdPartyApiFetchError, firstPartyApiFetchError] });
     }
   }
 }

src/task_queue/tasks/ProxyPoolHttpClientHealthcheckTask.ts

@@ -90,6 +90,9 @@ export default class ProxyPoolHttpClientHealthcheckTask extends Task {
       };
     } catch (err: any) {
       SentrySdk.logAndCaptureWarning(`[ProxyHealthcheck] Proxy '${proxy.displayName}' is unhealthy: ${err.message}`, { err });
+      if (err.message === 'SocksClient internal error (this should not happen)') {
+        console.error(err);
+      }
 
       proxy.health = {
         unhealthy: true,

tests/unit/minecraft/profile/MinecraftProfileService.test.ts

@@ -253,7 +253,7 @@ describe('#provideProfileByUsername', () => {
     expect(minecraftApiClient.fetchUuidForUsername).toHaveBeenCalledTimes(0);
   });
 
-  test('On Mojang API troubles (username->profile) the third-party API is used to determine the UUID', async () => {
+  test('On API troubles (username->profile) the first-party API is used to determine the UUID', async () => {
     const expectedProfile = {
       profile: EXISTING_MC_PROFILE_RESPONSE,
       ageInSeconds: 0,
@@ -273,14 +273,14 @@ describe('#provideProfileByUsername', () => {
     expect(profileCache.findByUsername).toHaveBeenCalledTimes(1);
     expect(profileCache.findByUsername).toHaveBeenCalledWith(EXISTING_MC_NAME);
 
-    expect(minecraftApiClient.fetchUuidForUsername).toHaveBeenCalledTimes(1);
+    expect(minecraftApiClient.fetchUuidForUsername).toHaveBeenCalledTimes(0);
     expect(minecraftApiClient.fetchProfileForUuid).toHaveBeenCalledTimes(1);
     expect(thirdPartyMinecraftApiClient.fetchUuidForUsername).toHaveBeenCalledTimes(1);
   });
 
-  test('On Mojang API troubles (username->profile) an error is thrown', async () => {
+  test('On API troubles (username->profile) an error is thrown', async () => {
     profileCache.findByUsername.mockResolvedValue(null);
-    minecraftApiClient.fetchUuidForUsername.mockImplementation(() => {
+    thirdPartyMinecraftApiClient.fetchUuidForUsername.mockImplementation(() => {
       throw new Error('Connection timed out or something');
     });