[Bug] UserPFP not working

[cutekita]

Describe the bug
It looks like UserPFP images aren't loading in Dorion

To Reproduce
I installed a clean version of Dorion, installed UserPFP, turned it on and restarted the client

Expected behavior
I should be seeing custom profile pictures from UserPFP, but I only see the default one

Screenshots
First screenshot is the profile picture I see, the second screenshot is what they should have

System Info (please complete the following information):

• OS: Windows 11
• Discord version: Stable
• Any other relevant info: I didn't test it in shelter on its own

[SpikeHD]

Please test on web (not Dorion) and if it only happens on Dorion, I'll transfer this issue to that repo (otherwise pls edit this issue)

[cutekita]

Hey, sorry I forgot about this, it doesn't work for me in the browser either, not that the image is missing, but the link in the avatar element isn't even replaced and I didn't see anything about the link to it being blocked by CSP or whatever it could be

[ilyeshdz]

I've been looking into this and found that the original webpack interception method (getUserAvatarURL) is pretty much dead since that function doesn't exist in modern Discord/Dorion anymore. I tried hunting for a replacement in the webpack modules, but couldn't find a clean way to hook into the avatar functions directly.

Since that wasn't working, I put together a fix using a MutationObserver instead. Basically, instead of trying to catch the URL at the source, the plugin now:

• Watches the DOM for any new images popping up.
• Filters for ones using the Discord avatar CDN (cdn.discordapp.com/avatars).
• Grabs the user ID from the URL, checks the UserPFP database, and swaps the src with the custom image.

It's working perfectly on my machine and custom PFPs are showing up again. However, I’ll admit this approach feels a bit heavy-handed, but I honestly don't know a better way to do it right now.

If this sounds good to you, I'm happy to open a pull request!

[cutekita]

I can't confirm this is relevant due to my lack of talent ^-^ however this may be a useful as a reference, perhaps the Equicord plugin has a better way to do this. https://github.com/Equicord/Equicord/blob/main/src/equicordplugins/userpfp/index.tsx