diff --git a/Directory.Packages.props b/Directory.Packages.props index 69000ce26..783781d15 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -12,6 +12,8 @@ + + diff --git a/Resources/EngineCredits/Libraries.yml b/Resources/EngineCredits/Libraries.yml index eb9348c45..ae4e4f54e 100644 --- a/Resources/EngineCredits/Libraries.yml +++ b/Resources/EngineCredits/Libraries.yml @@ -81,6 +81,76 @@ See the License for the specific language governing permissions and limitations under the License. +- name: DiffPlex + license: | + Apache License + Version 2.0, January 2004 + http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all other entities that control, are controlled by, or are under common control with that entity. For the purposes of this definition, "control" means (i) the power, direct or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, including but not limited to software source code, documentation source, and configuration files. + + "Object" form shall mean any form resulting from mechanical transformation or translation of a Source form, including but not limited to compiled object code, generated documentation, and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object form, that is based on (or derived from) the Work and for which the editorial revisions, annotations, elaborations, or other modifications represent, as a whole, an original work of authorship. For the purposes of this License, Derivative Works shall not include works that remain separable from, or merely link (or bind by name) to the interfaces of, the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including the original version of the Work and any modifications or additions to that Work or Derivative Works thereof, that is intentionally submitted to Licensor for inclusion in the Work by the copyright owner or by an individual or Legal Entity authorized to submit on behalf of the copyright owner. For the purposes of this definition, "submitted" means any form of electronic, verbal, or written communication sent to the Licensor or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Licensor for the purpose of discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity on behalf of whom a Contribution has been received by Licensor and subsequently incorporated within the Work. + + 2. Grant of Copyright License. + + Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. + + Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by such Contributor that are necessarily infringed by their Contribution(s) alone or by combination of their Contribution(s) with the Work to which such Contribution(s) was submitted. If You institute patent litigation against any entity (including a cross-claim or counterclaim in a lawsuit) alleging that the Work or a Contribution incorporated within the Work constitutes direct or contributory patent infringement, then any patent licenses granted to You under this License for that Work shall terminate as of the date such litigation is filed. + + 4. Redistribution. + + You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or without modifications, and in Source or Object form, provided that You meet the following conditions: + + You must give any other recipients of the Work or Derivative Works a copy of this License; and + You must cause any modified files to carry prominent notices stating that You changed the files; and + You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and + If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License. + You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License. + + 5. Submission of Contributions. + + Unless You explicitly state otherwise, any Contribution intentionally submitted for inclusion in the Work by You to the Licensor shall be under the terms and conditions of this License, without any additional terms or conditions. Notwithstanding the above, nothing herein shall supersede or modify the terms of any separate license agreement you may have executed with Licensor regarding such Contributions. + + 6. Trademarks. + + This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor, except as required for reasonable and customary use in describing the origin of the Work and reproducing the content of the NOTICE file. + + 7. Disclaimer of Warranty. + + Unless required by applicable law or agreed to in writing, Licensor provides the Work (and each Contributor provides its Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are solely responsible for determining the appropriateness of using or redistributing the Work and assume any risks associated with Your exercise of permissions under this License. + + 8. Limitation of Liability. + + In no event and under no legal theory, whether in tort (including negligence), contract, or otherwise, unless required by applicable law (such as deliberate and grossly negligent acts) or agreed to in writing, shall any Contributor be liable to You for damages, including any direct, indirect, special, incidental, or consequential damages of any character arising as a result of this License or out of the use or inability to use the Work (including but not limited to damages for loss of goodwill, work stoppage, computer failure or malfunction, or any and all other commercial damages or losses), even if such Contributor has been advised of the possibility of such damages. + + 9. Accepting Warranty or Additional Liability. + + While redistributing the Work or Derivative Works thereof, You may choose to offer, and charge a fee for, acceptance of support, warranty, indemnity, or other liability obligations and/or rights consistent with this License. However, in accepting such obligations, You may act only on Your own behalf and on Your sole responsibility, not on behalf of any other Contributor, and only if You agree to indemnify, defend, and hold each Contributor harmless for any liability incurred by, or claims asserted against, such Contributor by reason of your accepting any such warranty or additional liability. + + END OF TERMS AND CONDITIONS + - name: Discord Rich Presence license: | MIT License diff --git a/Robust.Shared/Prototypes/IPrototypeManager.cs b/Robust.Shared/Prototypes/IPrototypeManager.cs index fcb5cedb1..678115eaf 100644 --- a/Robust.Shared/Prototypes/IPrototypeManager.cs +++ b/Robust.Shared/Prototypes/IPrototypeManager.cs @@ -510,6 +510,15 @@ Dictionary> ValidateDirectory(ResPath path, /// empty, everything was successfully validated. Dictionary>> ValidateAllPrototypesSerializable(ISerializationContext? ctx); + /// + /// This method will serialize, validate, and then export all EntityPrototypes as a single .yml file. + /// Used for generating YAML diffs that include inherited components. + /// + /// Path to get EntityPrototypes from. + /// Whether or not to include abstract prototypes. + /// If false, will return output without saving a file. + void SaveEntityPrototypes(ResPath searchPath, out string output, bool includeAbstract = false, bool saveFile = false); + void LoadFromStream(TextReader stream, bool overwrite = false, Dictionary>? changed = null); void LoadString(string str, bool overwrite = false, Dictionary>? changed = null); diff --git a/Robust.Shared/Prototypes/PrototypeManager.YamlDiff.cs b/Robust.Shared/Prototypes/PrototypeManager.YamlDiff.cs new file mode 100644 index 000000000..c7e65ac45 --- /dev/null +++ b/Robust.Shared/Prototypes/PrototypeManager.YamlDiff.cs @@ -0,0 +1,98 @@ +using System.Collections.Generic; +using System.IO; +using System.Linq; +using Robust.Shared.Serialization.Markdown; +using Robust.Shared.Serialization.Markdown.Mapping; +using Robust.Shared.Serialization.Markdown.Sequence; +using Robust.Shared.Serialization.Markdown.Value; +using Robust.Shared.Utility; + +namespace Robust.Shared.Prototypes; + +public partial class PrototypeManager +{ + private static readonly List FieldOrder = + ["type", "id", "parent", "categories", "name", "suffix", "description"]; + + private static readonly ResPath DefaultPath = new("/Prototypes"); + + /// + /// AKA yaml dumper 9000. + /// Scans through a provided directory for EntityPrototypes and outputs them all as a single file. + /// Includes information on inherited components through parent entities. + /// + /// The directory to save prototypes from. + public void SaveEntityPrototypes(ResPath searchPath, out string output, bool includeAbstract = false, bool saveFile = false) + { + Dictionary entityProtos = []; + var streams = GetYamlStreams(DefaultPath); + foreach (var data in ValidateStreams(streams) + .Where(x => x.Item1 == typeof(EntityPrototype))) + { + data.Item2.Mapping.Remove("type"); + entityProtos[data.Item2.Id] = data.Item2; + } + + // if using a custom path, we also need to load parents to validate these correctly. + // TODO this can probably all be done more optimally + bool usingDefaultPath = searchPath == DefaultPath; + + List outProtos = []; + if (!usingDefaultPath) + { + var outStreams = GetYamlStreams(searchPath); + foreach (var data in ValidateStreams(outStreams) + .Where(x => x.Item1 == typeof(EntityPrototype))) + { + outProtos.Add(data.Item2.Id); + } + } + + Dictionary normalizedPrototypes = []; + foreach (var (id, data) in entityProtos.OrderBy(x => x.Key)) + { + EnsurePushed(data, entityProtos, typeof(EntityPrototype)); + + if (!outProtos.Contains(data.Id) + || usingDefaultPath) + continue; + + if (data.Mapping.TryGet("abstract", out ValueDataNode? abstractNode) + && bool.Parse(abstractNode.Value) + && !includeAbstract) + continue; + + normalizedPrototypes[id] = NormalizeDataNode(data.Mapping); + } + + // we save the file if this is being run with the --save command + // otherwise, we output results to the out + if (saveFile) + { + using var writer = new StreamWriter(new ResPath("entity-prototypes.yml").CanonPath, false); + normalizedPrototypes.Values.ToSequenceDataNode().Write(writer); + } + + output = normalizedPrototypes.Values.ToSequenceDataNode().ToString(); + } + + private DataNode NormalizeDataNode(DataNode node) + { + return node switch + { + MappingDataNode map => map + .Select(x => KeyValuePair.Create(x.Key, NormalizeDataNode(x.Value))) + // Yes this will sort non-component registry mappings. + .OrderBy(x => FieldOrder.IndexOf(x.Key) is var index && index >= 0 ? index : 100) + .ThenBy(x => x.Key) + .ToMappingDataNode(), + SequenceDataNode sequence => sequence + .Select(NormalizeDataNode) + // Put - type: at the top for components + .OrderByDescending(x => + x is MappingDataNode map && map.TryGet("type", out ValueDataNode? value) ? value.Value : null) + .ToSequenceDataNode(), + _ => node + }; + } +} diff --git a/Robust.Shared/Prototypes/PrototypeManager.YamlValidate.cs b/Robust.Shared/Prototypes/PrototypeManager.YamlValidate.cs index 65035b428..f68f585ff 100644 --- a/Robust.Shared/Prototypes/PrototypeManager.YamlValidate.cs +++ b/Robust.Shared/Prototypes/PrototypeManager.YamlValidate.cs @@ -1,9 +1,11 @@ using System; using System.Collections.Generic; +using System.IO; using System.Linq; using Robust.Shared.Serialization.Manager; using Robust.Shared.Serialization.Markdown; using Robust.Shared.Serialization.Markdown.Mapping; +using Robust.Shared.Serialization.Markdown.Sequence; using Robust.Shared.Serialization.Markdown.Validation; using Robust.Shared.Serialization.Markdown.Value; using Robust.Shared.Utility; @@ -18,25 +20,31 @@ public partial class PrototypeManager // disallow them for all prototypes. private static readonly char[] DisallowedIdChars = [' ', '.']; - public Dictionary> ValidateDirectory(ResPath path) => ValidateDirectory(path, out _); - - public Dictionary> ValidateDirectory(ResPath path, - out Dictionary> protos) + /// + /// Returns an IEnum list of .yml files from a given ResPath. + /// + /// ResPath to search for .yml files. + private IEnumerable GetYamlStreams(ResPath path) { - var streams = Resources.ContentFindFiles(path).ToList().AsParallel() - .Where(filePath => filePath.Extension == "yml" && !filePath.Filename.StartsWith(".")); - - var dict = new Dictionary>(); - var prototypes = new Dictionary>(); + return Resources.ContentFindFiles(path) + .ToList() + .AsParallel() + .Where(filePath => filePath.Extension == "yml" && !filePath.Filename.StartsWith('.')); + } - foreach (var resourcePath in streams) + /// + /// Validate all prototypes in given .yml files. + /// + /// List of .yml files to validate contents of. + /// Entity prototype and validation data. + /// + private IEnumerable<(Type, PrototypeValidationData)> ValidateStreams(IEnumerable streams) + { + foreach (var resPath in streams) { - using var reader = ReadFile(resourcePath); - + using var reader = ReadFile(resPath); if (reader == null) - { continue; - } var yamlStream = new YamlStream(); try @@ -51,9 +59,10 @@ public Dictionary> ValidateDirectory(ResPath path, foreach (var doc in yamlStream.Documents) { var rootNode = (YamlSequenceNode)doc.RootNode; - foreach (YamlMappingNode node in rootNode.Cast()) + foreach (var node in rootNode.Cast()) { var typeId = node.GetNode("type").AsString(); + // TODO maybe bool flag for this check if (_ignoredPrototypeTypes.Contains(typeId)) continue; @@ -65,29 +74,47 @@ public Dictionary> ValidateDirectory(ResPath path, var mapping = node.ToDataNodeCast(); var id = mapping.Get("id").Value; - var data = new PrototypeValidationData(id, mapping, resourcePath.ToString()); - mapping.Remove("type"); + yield return (type, new(id, mapping, resPath.ToString())); + } + } + } + } - if (DisallowedIdChars.TryFirstOrNull(c => id.Contains(c), out var letter)) - { - dict.GetOrNew(data.File) - .Add(new ErrorNode(mapping, $"Prototype '{id}' ({type}) contains disallowed " - + $"character '{letter}'.")); - } + public Dictionary> ValidateDirectory(ResPath path) => ValidateDirectory(path, out _); - if (prototypes.GetOrNew(type).TryAdd(id, data)) - continue; + public Dictionary> ValidateDirectory(ResPath path, + out Dictionary> protos) + { + var streams = GetYamlStreams(path); - var error = new ErrorNode(mapping, $"Found dupe prototype ID of {id} for {type}"); - dict.GetOrNew(data.File).Add(error); - } + var dict = new Dictionary>(); + var prototypes = new Dictionary>(); + + foreach (var (type, data) in ValidateStreams(streams)) + { + data.Mapping.Remove("type"); + + if (DisallowedIdChars.TryFirstOrNull(c => data.Id.Contains(c), out var letter)) + { + dict.GetOrNew(data.File) + .Add(new ErrorNode(data.Mapping, + $"Prototype '{data.Id}' ({type}) contains disallowed character '{letter}'.")); } + + if (prototypes.GetOrNew(type).TryAdd(data.Id, data)) + continue; + + var error = new ErrorNode(data.Mapping, $"Found dupe prototype ID of {data.Id} for {type}"); + dict.GetOrNew(data.File).Add(error); } var ctx = new YamlValidationContext(); var errors = new List(); + var saveProto = !path.FilenameWithoutExtension.Contains("Engine") && _net.IsServer; + var dir = Directory.CreateDirectory("prototypes"); foreach (var (type, instances) in prototypes) { + Dictionary allThings = []; foreach (var (id, data) in instances) { errors.Clear(); @@ -103,6 +130,30 @@ public Dictionary> ValidateDirectory(ResPath path, if (errors.Count > 0) dict.GetOrNew(data.File).UnionWith(errors); + if (saveProto) + { + var mapSorted = data.Mapping.OrderByDescending(x => x.Key == "id") + .ThenBy(x => x.Key) + .ToDictionary(); + + if (mapSorted.TryGetValue("components", out var compNode) + && compNode is SequenceDataNode comps) + { + mapSorted["components"] = new SequenceDataNode(comps + .Where(x => x is MappingDataNode) + .Cast() + .Select(x => new MappingDataNode(x + .OrderByDescending(y => y.Key == "type") + .ThenBy(y => y.Key) + .ToDictionary())) + .OrderBy(x => x["type"].ToString()) + .Cast() + .ToList()); + } + + allThings.Add(id, new MappingDataNode(mapSorted)); + } + // Create instance & re-serialize it, to validate the default values of data-fields. We still validate // the yaml directly just in case reading & writing the fields somehow modifies their values. try @@ -118,6 +169,16 @@ public Dictionary> ValidateDirectory(ResPath path, errors.Add(new ErrorNode(new ValueDataNode(), $"Caught Exception while validating {type} prototype {id}. Exception: {ex}")); } } + + if (allThings.Count <= 0) + continue; + + var nodes = new SequenceDataNode(allThings + .OrderBy(x => x.Key) + .Select(x => x.Value) + .ToList()); + using var writer = new StreamWriter($"{dir.Name}/{type.Name}.yml", true); + nodes.Write(writer); } protos = new(prototypes.Count); @@ -188,6 +249,7 @@ private HashSet ValidateProto(Type type, IPrototype instance, ISerial } } + // TODO rename private sealed class PrototypeValidationData { public readonly string Id; diff --git a/Robust.Shared/Prototypes/PrototypeManager.cs b/Robust.Shared/Prototypes/PrototypeManager.cs index 527ae7ea2..e6c5b9563 100644 --- a/Robust.Shared/Prototypes/PrototypeManager.cs +++ b/Robust.Shared/Prototypes/PrototypeManager.cs @@ -15,6 +15,7 @@ using Robust.Shared.IoC.Exceptions; using Robust.Shared.Localization; using Robust.Shared.Log; +using Robust.Shared.Network; using Robust.Shared.Random; using Robust.Shared.Reflection; using Robust.Shared.Serialization; @@ -37,6 +38,7 @@ public abstract partial class PrototypeManager : IPrototypeManagerInternal [Dependency] private IComponentFactory _factory = default!; [Dependency] private IEntityManager _entMan = default!; [Dependency] private IRobustRandom _random = default!; + [Dependency] private INetManager _net = default!; private readonly Dictionary> _prototypeDataCache = new(); private EntityDiffContext _context = new(); diff --git a/Robust.Shared/Robust.Shared.csproj b/Robust.Shared/Robust.Shared.csproj index cdd7bf974..b15c7e8de 100644 --- a/Robust.Shared/Robust.Shared.csproj +++ b/Robust.Shared/Robust.Shared.csproj @@ -7,6 +7,7 @@ CA1416 + diff --git a/Robust.Shared/Serialization/Markdown/DataNodeHelpers.cs b/Robust.Shared/Serialization/Markdown/DataNodeHelpers.cs index 706db5397..64ab8b7db 100644 --- a/Robust.Shared/Serialization/Markdown/DataNodeHelpers.cs +++ b/Robust.Shared/Serialization/Markdown/DataNodeHelpers.cs @@ -1,5 +1,6 @@ using System; using System.Collections.Generic; +using System.Linq; using Robust.Shared.Serialization.Markdown.Mapping; using Robust.Shared.Serialization.Markdown.Sequence; using Robust.Shared.Serialization.Markdown.Value; @@ -51,4 +52,16 @@ private static IEnumerable GetAllNodes(ValueDataNode node) { yield return node; } + + /// + /// Converts provided DataNodes to an unordered MappingDataNode dictionary. + /// + public static MappingDataNode ToMappingDataNode(this IEnumerable> entries) + => new(entries.ToDictionary()); + + /// + /// Converts provided DataNodes to an ordered SequenceDataNode list. + /// + public static SequenceDataNode ToSequenceDataNode(this IEnumerable entries) + => new(entries.ToList()); } diff --git a/Robust.Shared/Serialization/Markdown/Mapping/MappingDataNodeExtensions.cs b/Robust.Shared/Serialization/Markdown/Mapping/MappingDataNodeExtensions.cs index a10701c14..d09d326f3 100644 --- a/Robust.Shared/Serialization/Markdown/Mapping/MappingDataNodeExtensions.cs +++ b/Robust.Shared/Serialization/Markdown/Mapping/MappingDataNodeExtensions.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.Linq; using Robust.Shared.Serialization.Markdown.Sequence; using Robust.Shared.Serialization.Markdown.Value;