Resolve RuboCop TODOs

[willnet]

ref: #395

Currently, the .rubocop_todo.yml file lists many cops as TODOs. There are still quite a few that can be fixed relatively safely with rubocop -a. I’d like to start clearing these.

https://github.com/Sorcery/sorcery/blob/939b7dc34f9a103327e464098268fc2494ce7568/.rubocop_todo.yml

To keep reviews simple, please avoid fixing multiple cop violations in a single commit. Aim to fix one cop per commit whenever possible.

I haven’t thoroughly reviewed the TODO list, so some items may be better disabled than resolved. If you find a cop that should be disabled, please update .rubocop.yml with the change and include the reason.

[beengine]

Hi @willnet, can I work on this issue?

[willnet]

Thanks, @beengine ! Yes, please go ahead.

[beengine]

@willnet could you please take a look at my PR? At least to check if I'm on the right track?

[oiahoon]

Hi! I would like to handle only the remaining Gemspec/DevelopmentDependencies TODO as a small follow-up. Current main reports six offenses even though the generated TODO comment says five. My proposed scope is to move those six development-only gems from sorcery.gemspec to Gemfile while preserving their version constraints, remove only that cop entry from .rubocop_todo.yml, and run the full RuboCop and RSpec suites. I checked that there is no open PR covering this cop. Is this scope OK?

[oiahoon]

I opened #441 for the Gemspec/DevelopmentDependencies scope. It moves the six existing development-only gems to Gemfile with the same version constraints and removes only that cop entry from .rubocop_todo.yml. The PR contains one commit; full RuboCop (123 files), full RSpec (559 examples), dependency resolution, and gem build all pass. The broader #396 issue remains open for the other cops.