From 9cbc979f51535008b4cc5495c361daf114c5efa7 Mon Sep 17 00:00:00 2001 From: Corey Faulconbridge Date: Thu, 17 Jul 2025 13:11:12 +0100 Subject: [PATCH 1/2] remove manual link and change content --- .../Cohort/SelectLearnerRecordViewModel.cs | 2 +- .../Views/Learner/SelectLearnerRecord.cshtml | 32 ++++++++----------- 2 files changed, 14 insertions(+), 20 deletions(-) diff --git a/src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web/Models/Cohort/SelectLearnerRecordViewModel.cs b/src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web/Models/Cohort/SelectLearnerRecordViewModel.cs index 561ce9630..f9ed8d5ca 100644 --- a/src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web/Models/Cohort/SelectLearnerRecordViewModel.cs +++ b/src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web/Models/Cohort/SelectLearnerRecordViewModel.cs @@ -17,7 +17,7 @@ public class SelectLearnerRecordViewModel : IAuthorizationContextModel public Guid? ReservationId { get; set; } public List Learners { get; set; } = new(); - public string PageTitle => $"Select apprentices from ILR for {EmployerAccountName}"; + public string PageTitle => "Select learner from ILR"; public string SortedByHeaderClassName { get; set; } public const string HeaderClassName = "das-table__sort"; diff --git a/src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web/Views/Learner/SelectLearnerRecord.cshtml b/src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web/Views/Learner/SelectLearnerRecord.cshtml index 8a9401919..60c9eed22 100644 --- a/src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web/Views/Learner/SelectLearnerRecord.cshtml +++ b/src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web/Views/Learner/SelectLearnerRecord.cshtml @@ -18,27 +18,21 @@

@Model.PageTitle

- If you cannot find the apprentice you're looking for, try: + These are the learners you've submitted an ILR for that are linked to @Model.EmployerAccountName. It also includes any learners who are not linked to an employer in the ILR.

- +
+ + + I can't find the learner I need + + +
+

+ It can take up to 15 minutes for these records to update after an ILR file is submitted. Try refreshing this page after 15 minutes. +

+
+
From a4ff5c3bc15c599b0d61e6627216e3c225ba4162 Mon Sep 17 00:00:00 2001 From: Corey Faulconbridge Date: Mon, 21 Jul 2025 19:24:25 +0100 Subject: [PATCH 2/2] fix unit test --- .../Models/Cohort/SelectLearnerRecordViewModelTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Models/Cohort/SelectLearnerRecordViewModelTests.cs b/src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Models/Cohort/SelectLearnerRecordViewModelTests.cs index fbcbdd202..fed1b0cb2 100644 --- a/src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Models/Cohort/SelectLearnerRecordViewModelTests.cs +++ b/src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Models/Cohort/SelectLearnerRecordViewModelTests.cs @@ -21,7 +21,7 @@ public void PageTitleIsCorrect(string employerName) { _viewModel.EmployerAccountName = employerName; //Assert - _viewModel.PageTitle.Should().EndWith(employerName); + _viewModel.PageTitle.Should().Be("Select learner from ILR"); } [TestCase(true, "das-table__sort--desc")]