In python/shipStrawTracking.py (~line 805), the reconstructibility denominator drops every MC track whose mother isn't index 2:
motherId = atrack.GetMotherId()
if motherId != 2: #!!!!
itemstoremove.append(item)This hardcodes the assumption that signal tracks descend from an HNL stored at MCTrack index 2. For any other topology (or an HNL not at index 2), the efficiency denominator is wrong. The #!!!! marker suggests the author knew this was a hack.
This needs a design decision (make the signal-mother selection configurable / detect it robustly) rather than a mechanical fix. Found during a code review.
In
python/shipStrawTracking.py(~line 805), the reconstructibility denominator drops every MC track whose mother isn't index 2:This hardcodes the assumption that signal tracks descend from an HNL stored at MCTrack index 2. For any other topology (or an HNL not at index 2), the efficiency denominator is wrong. The
#!!!!marker suggests the author knew this was a hack.This needs a design decision (make the signal-mother selection configurable / detect it robustly) rather than a mechanical fix. Found during a code review.