ProximityShielding and target length

[amagnan]

@olantwin @THanae
This will be a problem for the updated target, which is now 162.8cm long, but actually I do not understand why you want to hardcode this ?

FairShip/passive/ShipTargetStation.cxx

Lines 218 to 219 in 44b4ab5

	fTargetLength =
	1586.4 * mm; // Make shielding independent of actual target length

If anything we would set it to the "max" between target vessel and shield length , what do you think ?

[olantwin]

To avoid the rest of the experiment moving. If we define z0 as the start of the target, making the shielding depend on target length means everything shifts.

[amagnan]

Shifts relative to the target z0, but if then this is adjusted in global coordinate to absorb a longer target, then nothing shifts...?????

[amagnan]

Let me rephrase: it shifts in local coordinates, but not in global, and in any case I thought that every other detector is using the target length from the target yaml, they are not placed wrt shielding, so why does this matter ? Sorry if I misunderstand something here...

[olantwin]

Shifts relative to the target z0, but if then this is adjusted in global coordinate to absorb a longer target, then nothing shifts...?????

The target z0 is the global z0.