Skip to content

Commit 5691517

Browse files
ShinobiFPVclaude
andcommitted
ci: pin release runner to windows-2022, not windows-latest
windows-latest just moved to a VS2026 (18.x) image; node-gyp doesn't recognize that version yet (nodejs/node-gyp#3282), which is the actual cause of "Could not find any Visual Studio installation" rebuilding node-pty — bumping the Node version in the runner didn't touch this, since the gap is in the image's VS version, not npm's bundled node-gyp. windows-2022 keeps the VS2022 toolchain node-gyp already understands. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 180e8db commit 5691517

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

.github/workflows/release.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,16 @@ permissions:
1212

1313
jobs:
1414
release:
15-
runs-on: windows-latest
15+
# Pinned, not windows-latest: that alias moved to a VS2026 (18.x) image
16+
# and node-gyp doesn't recognize that version yet ("Could not find any
17+
# Visual Studio installation" rebuilding node-pty — nodejs/node-gyp#3282).
18+
# windows-2022 keeps the VS2022 toolchain node-gyp actually understands.
19+
runs-on: windows-2022
1620
steps:
1721
- uses: actions/checkout@v4
1822

1923
- uses: actions/setup-node@v4
2024
with:
21-
# Node 20's bundled npm ships a node-gyp too old to find VS2022 on
22-
# the windows-latest runner ("Could not find any Visual Studio
23-
# installation" rebuilding node-pty) — 22 carries a node-gyp that
24-
# detects it fine. Matches what's proven working on the dev
25-
# machine (Node 24, same fix, one major newer).
2625
node-version: 22
2726

2827
- run: npm ci

0 commit comments

Comments
 (0)