DEV-651 #time 10m addressing PR comments

Author: marknolan

ShimmerDriver/src/main/java/com/shimmerresearch/bluetooth/ShimmerBluetooth.java

@@ -2309,6 +2309,9 @@ else if(currentCommand==SET_CRC_COMMAND){
 				else if(currentCommand==SET_TEST){
 					InShimmerTest = true;
 				}
+				else if (currentCommand == SET_FEATURE) {
+					// TODO: do something?
+				}
 				else {
 					//unhandled set command
 					printLogDataForDebugging("Unhandled set command: " + btCommandToString(currentCommand));
@@ -2644,8 +2647,8 @@ private void initializeShimmer3or3R(int hardwareVersion){
 			writeBtCommsCrcMode(DEFAULT_BT_CRC_MODE_IF_SUPPORTED);
 		}
 
-		if (RN4678_ERROR_DETECTION_ENABLED && isSupportedRn4678ErrorTest()) {
-			wristSetFeatureCommand(SHIMMER_FEATURE.RN4678_ERROR_DETECTION.ordinal(), 1);
+		if (RN4678_ERROR_DETECTION_ENABLED && isSupportedRn4678ErrorDetection()) {
+			writeSetFeatureCommand(SHIMMER_FEATURE.RN4678_ERROR_DETECTION.ordinal(), 1);
 		}
 
 		if (isSetupDeviceWhileConnecting()){
@@ -4643,7 +4646,12 @@ public void writeMemCommand(int command, int address, byte[] infoMemBytes) {
 		}
 	}
 
-	public void wristSetFeatureCommand(int feature, int setting){
+	/**
+	 * writeSetFeatureCommand(feature, setting) sets a particular feature on the Shimmer device to the desired setting.
+	 * @param feature is a numeric value defining the feature to be set. 
+	 * @param setting is a numeric value defining the desired setting for the feature. Example valid settings values are 0 (Disable feature) and 1 (Enable feature)
+	 */
+	public void writeSetFeatureCommand(int feature, int setting){
 		writeInstruction(new byte[]{SET_FEATURE, (byte)feature, (byte)setting});
 	}
 

ShimmerDriver/src/main/java/com/shimmerresearch/driver/ShimmerDevice.java

@@ -2166,7 +2166,7 @@ public static boolean isSupportedNoImuSensors(ShimmerVerObject svo, ExpansionBoa
 		}
 	}
 
-	public boolean isSupportedRn4678ErrorTest() {
+	public boolean isSupportedRn4678ErrorDetection() {
 		if((isShimmerGen3() && getFirmwareIdentifier()==ShimmerVerDetails.FW_ID.LOGANDSTREAM
 				&& mShimmerVerObject.compareVersions(HW_ID.SHIMMER_3, FW_ID.LOGANDSTREAM, 1, 0, 17))){
 			return true;

ShimmerDriver/src/main/java/com/shimmerresearch/sensors/bmpX80/SensorBMP390.java

@@ -104,24 +104,18 @@ public static final class ObjectClusterSensorName{
 		public static final byte PRESSURE_CALIBRATION_COEFFICIENTS_RESPONSE 		= (byte) 0xA6;
 		public static final byte GET_PRESSURE_CALIBRATION_COEFFICIENTS_COMMAND 		= (byte) 0xA7;
 
-		public static final byte SET_PRESSURE_SAMPLING_RATE_COMMAND 	= (byte) 0xB5;
-		public static final byte PRESSURE_SAMPLING_RATE_RESPONSE 		= (byte) 0xB6;
-		public static final byte GET_PRESSURE_SAMPLING_RATE_COMMAND 	= (byte) 0xB7;
-		
 	    public static final Map<Byte, BtCommandDetails> mBtGetCommandMap;
 	    static {
 	        Map<Byte, BtCommandDetails> aMap = new LinkedHashMap<Byte, BtCommandDetails>();
 	        aMap.put(GET_PRESSURE_OVERSAMPLING_RATIO_COMMAND, new BtCommandDetails(GET_PRESSURE_OVERSAMPLING_RATIO_COMMAND, "GET_PRESSURE_OVERSAMPLING_RATIO_COMMAND", PRESSURE_OVERSAMPLING_RATIO_RESPONSE));
 	        aMap.put(GET_PRESSURE_CALIBRATION_COEFFICIENTS_COMMAND, new BtCommandDetails(GET_PRESSURE_CALIBRATION_COEFFICIENTS_COMMAND, "GET_PRESSURE_CALIBRATION_COEFFICIENTS_COMMAND", PRESSURE_CALIBRATION_COEFFICIENTS_RESPONSE));
-	        aMap.put(GET_PRESSURE_SAMPLING_RATE_COMMAND, new BtCommandDetails(GET_PRESSURE_SAMPLING_RATE_COMMAND, "GET_PRESSURE_SAMPLING_RATE_COMMAND", PRESSURE_SAMPLING_RATE_RESPONSE));
 	        mBtGetCommandMap = Collections.unmodifiableMap(aMap);
 	    }
 
 	    public static final Map<Byte, BtCommandDetails> mBtSetCommandMap;
 	    static {
 	        Map<Byte, BtCommandDetails> aMap = new LinkedHashMap<Byte, BtCommandDetails>();
 	        aMap.put(SET_PRESSURE_OVERSAMPLING_RATIO_COMMAND, new BtCommandDetails(SET_PRESSURE_OVERSAMPLING_RATIO_COMMAND, "SET_PRESSURE_OVERSAMPLING_RATIO_COMMAND"));
-	        aMap.put(SET_PRESSURE_SAMPLING_RATE_COMMAND, new BtCommandDetails(SET_PRESSURE_SAMPLING_RATE_COMMAND, "SET_PRESSURE_SAMPLING_RATE_COMMAND"));
 	        mBtSetCommandMap = Collections.unmodifiableMap(aMap);
 	    }
 	    //--------- Bluetooth commands end --------------