Skip to content

Add package of sapmachine-21#604

Open
Merlin-Xu-G wants to merge 2 commits into
ScoopInstaller:masterfrom
Merlin-Xu-G:feature/add-sapmachine-jdk-21
Open

Add package of sapmachine-21#604
Merlin-Xu-G wants to merge 2 commits into
ScoopInstaller:masterfrom
Merlin-Xu-G:feature/add-sapmachine-jdk-21

Conversation

@Merlin-Xu-G

Copy link
Copy Markdown

Closes #603

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

Summary by CodeRabbit

Release Notes

  • New Features
    • SapMachine LTS JDK and JRE updated to version 21.0.11
    • SapMachine 21 JDK and JRE distributions now available for installation

Walkthrough

The PR bumps the existing sapmachine-lts-jdk and sapmachine-lts-jre manifests from version 17.0.19 to 21.0.11, updating download URLs, SHA-256 hashes, extract directories, and checkver JSONPath selectors. It also adds two new version-pinned manifests, sapmachine21-jdk and sapmachine21-jre, for SapMachine 21.0.11 on Windows x64.

Changes

SapMachine 21 Manifests

Layer / File(s) Summary
LTS JDK and JRE version bump to 21.0.11
bucket/sapmachine-lts-jdk.json, bucket/sapmachine-lts-jre.json
Version, Windows x64 download URL, SHA-256 hash, extract_dir, and checkver jsonpath updated from 17.0.19 to 21.0.11 in both LTS manifests.
New sapmachine21 JDK and JRE manifests
bucket/sapmachine21-jdk .json, bucket/sapmachine21-jre.json
New version-pinned manifests for SapMachine 21.0.11 defining metadata, Windows x64 artifact URL and hash, extract_dir, env_add_path, JAVA_HOME via env_set, and checkver/autoupdate rules with JSONPath, regex capture groups, URL templating, and SHA file retrieval.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding a package for SAP Machine 21.
Description check ✅ Passed The description includes the required components: a reference to the linked issue (#603) and confirmation of reading the contributing guide.
Linked Issues check ✅ Passed All coding changes meet the objectives from issue #603: new sapmachine21 JDK and JRE packages are added, LTS versions updated, meeting all acceptance criteria.
Out of Scope Changes check ✅ Passed All changes are directly related to issue #603 requirements: adding sapmachine21 JDK/JRE packages and updating LTS version pointers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f5a798b9-e4fd-48ff-9907-2e2e25843fc3

📥 Commits

Reviewing files that changed from the base of the PR and between ca38e0d and 6c3ce48.

📒 Files selected for processing (4)
  • bucket/sapmachine-lts-jdk.json
  • bucket/sapmachine-lts-jre.json
  • bucket/sapmachine21-jdk .json
  • bucket/sapmachine21-jre.json

@@ -0,0 +1,35 @@
{

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Rename manifest file to remove trailing whitespace in package name.

The file path bucket/sapmachine21-jdk .json contains a trailing space before .json. This can break the expected package identifier (sapmachine21-jdk) and cause lookup/install inconsistencies. Please rename it to bucket/sapmachine21-jdk.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request] Need a sapmachine-jdk21 package

1 participant