run_qa(LinearSolve) with SciMLTesting 2.4 strict defaults fails Aqua piracy for LinearSolve's intended interface methods: CommonSolve.init/solve specialized on SciMLBase.LinearProblem and SciMLBase.EigenvalueProblem. Both the generic functions and argument types are owned by dependencies, so Aqua reports them as piracy even though these are the package's primary documented extension points.
Reproduced from clean SciML/LinearSolve.jl upstream main at ebb23fe0 with Julia 1.12 and SciMLTesting 2.4.0:
using Pkg
Pkg.activate(".baseline-qa")
Pkg.add(Pkg.PackageSpec(name = "SciMLTesting", version = "2.4"))
Pkg.develop(Pkg.PackageSpec(path = "."))
using LinearSolve, SciMLTesting
run_qa(LinearSolve)The strict run also correctly reports LinearSolve's blanket SciMLBase reexport and direct non-public accesses. Those are package issues. The Aqua piracy failure is structurally unavoidable without either removing the LinearSolve solver interface or passing piracies = (; treat_as_own = [LinearProblem, EigenvalueProblem]), which is a QA relaxation.
SciMLTesting should provide a strict default mechanism that recognizes documented SciMLBase/CommonSolve extension interfaces, so a solver package can retain strict QA without a repository-specific Aqua exception.
run_qa(LinearSolve)with SciMLTesting 2.4 strict defaults fails Aqua piracy for LinearSolve's intended interface methods:CommonSolve.init/solvespecialized onSciMLBase.LinearProblemandSciMLBase.EigenvalueProblem. Both the generic functions and argument types are owned by dependencies, so Aqua reports them as piracy even though these are the package's primary documented extension points.Reproduced from clean
SciML/LinearSolve.jlupstreammainatebb23fe0with Julia 1.12 and SciMLTesting 2.4.0:The strict run also correctly reports LinearSolve's blanket SciMLBase reexport and direct non-public accesses. Those are package issues. The Aqua piracy failure is structurally unavoidable without either removing the LinearSolve solver interface or passing
piracies = (; treat_as_own = [LinearProblem, EigenvalueProblem]), which is a QA relaxation.SciMLTesting should provide a strict default mechanism that recognizes documented SciMLBase/CommonSolve extension interfaces, so a solver package can retain strict QA without a repository-specific Aqua exception.