Consolidated bats tests

Author: Aklakan

cli-tests/integrate/README.md

@@ -6,12 +6,29 @@ This directory contains CLI tests for the RDF Processing Toolkit's `rpt integrat
 
 ```
 cli-tests/integrate/
-├── test01-mem/           # Tests for in-memory engine (Jena mem)
-├── test02-tdb2/          # Tests for TDB2 disk-based engine
-├── test03-read-only/     # Tests for read-only server mode
-└── test04-server/        # Tests for server HTTP endpoints
+├── resources/               # Centralized test data (shared across all tests)
+│   ├── input-triples.ttl
+│   ├── input-triples-small.ttl
+│   ├── query-construct-triples.sparql
+│   ├── expected-turtle.ttl
+│   ├── expected-ntriples.nt
+│   ├── expected-nquads.nq
+│   └── expected-trig.trig
+├── test01-mem/              # Tests for in-memory engine (Jena mem)
+├── test02-tdb2/             # Tests for TDB2 disk-based engine
+├── test03-read-only/        # Tests for read-only server mode
+├── test04-server/           # Tests for server HTTP endpoints
+└── test05-qlever/           # Tests for QLever engine
 ```
 
+### Test Directories
+
+- **test01-mem/** - 4 tests: turtle, nt, nq, trig output formats
+- **test02-tdb2/** - 2 tests: turtle, nt output formats
+- **test03-read-only/** - 2 tests: server start, UPDATE rejection
+- **test04-server/** - 1 test: server startup verification
+- **test05-qlever/** - 2 tests: turtle, nt output formats (no quads/trig support)
+
 ## JUnit Tests
 
 Located in `rdf-processing-toolkit-cli/src/test/java/org/aksw/sparql_integrate/integrate/`
@@ -46,15 +63,11 @@ bats cli-tests/integrate/test02-tdb2/
 bats cli-tests/integrate/test01-mem/test-engine-mem.bats
 ```
 
-## Test Data
+### Test Data Location
 
-Each test directory contains:
-- `input-triples.ttl` - Simple triple data
-- `input-triples-small.ttl` - Minimal test data (1 triple)
-- `input-quads.trig` - Data with named graphs
-- `query-construct-triples.sparql` - CONSTRUCT query for triples
-- `query-construct-quads.sparql` - CONSTRUCT query for quads
-- `expected-*` - Expected output files
+All test data is centralized in the `resources/` directory. Tests reference input files and expected outputs via relative paths to `resources/`. All output files are written to temporary directories (created per-test) and cleaned up after test completion.
+
+**Note:** The QLever engine doesn't support CONSTRUCT quads, so test05-qlever only tests turtle and ntriples output formats.
 
 ## Supported Output Formats
 
@@ -73,34 +86,51 @@ Tested with:
 - Fast, no disk I/O
 - Default engine
 - Ideal for CI/CD
+- Supports all output formats (turtle, nt, nq, trig)
 
 ### tdb2 (TDB2 Disk-Based)
 - Persists data to disk
 - Supports larger datasets
 - Test verifies database file creation
+- Supports turtle and nt output formats
+
+### qlever (QLever Engine)
+- SPARQL 1.1 compliant query engine
+- Supports turtle and nt output formats
+- Does NOT support CONSTRUCT quads (no nq/trig)
 
 ## Test Coverage
 
 ### JUnit Tests (4 tests)
 - `TestIntegrateMem`: mem engine with Turtle and N-Triples output
 - `TestIntegrateTdb2`: tdb2 engine with Turtle and N-Triples output
 
-### BATS Tests (9 tests)
+### BATS Tests (11 tests)
 - **mem engine**: Turtle, N-Triples, N-Quads, TriG output formats
 - **tdb2 engine**: Turtle, N-Triples output formats
 - **read-only server**: HTTP endpoint access, UPDATE query rejection
 - **server mode**: Server startup verification
+- **qlever engine**: Turtle, N-Triples output formats (no quads)
 
 ## Adding New Tests
 
-1. Create test data files in appropriate directory
-2. Write JUnit test in `TestIntegrate*.java`
-3. Write BATS test in `*.bats`
-4. Run tests to verify
-
-## Adding New Tests
-
-1. Create test data files in appropriate directory
-2. Write JUnit test in `TestIntegrate*.java`
-3. Write BATS test in `*.bats`
-4. Run tests to verify
+1. Add test data files to `resources/` directory
+2. Write BATS test in appropriate `test-*/` directory
+3. Reference files via `$RESOURCES_DIR` (see existing tests for examples)
+4. Write all outputs to `$TEMP_DIR` (created in `setup()`)
+5. Clean up temp directory in `teardown()`
+6. Run tests to verify
+
+## Adding New Engine Tests
+
+When adding a new engine test directory:
+
+1. Create new directory: `testXX-engine/`
+2. Copy relevant test data from `resources/` (if needed for engine-specific data)
+3. Create `.bats` file with appropriate tests
+4. Follow these conventions:
+   - Use `SCRIPT_DIR` and `RESOURCES_DIR` for paths
+   - Use `TEMP_DIR=$(mktemp -d)` for outputs
+   - Clean up in `teardown()`
+   - Skip unsupported formats (e.g., qlever doesn't support nq/trig)
+5. Update this README.md to document the new test directory

…/integrate/test01-mem/expected-nquads.nq …s/integrate/resources/expected-nquads.nqcli-tests/integrate/test01-mem/expected-nquads.nq renamed to cli-tests/integrate/resources/expected-nquads.nq cli-tests/integrate/test01-mem/expected-nquads.nq renamed to cli-tests/integrate/resources/expected-nquads.nq

@@ -1,49 +1,51 @@
 #!/usr/bin/env bats
 
 setup() {
-    TEST_DIR="$BATS_TEST_DIRNAME"
+    SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_DIRNAME")" && pwd)"
+    RESOURCES_DIR="$SCRIPT_DIR/resources"
+    TEMP_DIR=$(mktemp -d)
 }
 
 @test "mem: load turtle data and output turtle" {
-    run rpt integrate -e mem "$TEST_DIR/input-triples.ttl" "$TEST_DIR/query-construct-triples.sparql" -o "$TEST_DIR/output.ttl"
+    run rpt integrate -e mem "$RESOURCES_DIR/input-triples.ttl" "$RESOURCES_DIR/query-construct-triples.sparql" -o "$TEMP_DIR/output.ttl"
     [ "$status" -eq 0 ]
-    [ -f "$TEST_DIR/output.ttl" ]
+    [ -f "$TEMP_DIR/output.ttl" ]
 
-    expected=$(cat "$TEST_DIR/expected-turtle.ttl")
-    actual=$(cat "$TEST_DIR/output.ttl")
+    expected=$(cat "$RESOURCES_DIR/expected-turtle.ttl")
+    actual=$(cat "$TEMP_DIR/output.ttl")
     [ "$expected" = "$actual" ]
 }
 
 @test "mem: load turtle data and output ntriples" {
-    run rpt integrate -e mem "$TEST_DIR/input-triples.ttl" "$TEST_DIR/query-construct-triples.sparql" -o "$TEST_DIR/output.nt"
+    run rpt integrate -e mem "$RESOURCES_DIR/input-triples.ttl" "$RESOURCES_DIR/query-construct-triples.sparql" -o "$TEMP_DIR/output.nt"
     [ "$status" -eq 0 ]
-    [ -f "$TEST_DIR/output.nt" ]
+    [ -f "$TEMP_DIR/output.nt" ]
 
-    expected=$(cat "$TEST_DIR/expected-ntriples.nt")
-    actual=$(cat "$TEST_DIR/output.nt")
+    expected=$(cat "$RESOURCES_DIR/expected-ntriples.nt")
+    actual=$(cat "$TEMP_DIR/output.nt")
     [ "$expected" = "$actual" ]
 }
 
 @test "mem: load turtle data and output nquads" {
-    run rpt integrate -e mem "$TEST_DIR/input-triples.ttl" "$TEST_DIR/query-construct-triples.sparql" -o "$TEST_DIR/output.nq"
+    run rpt integrate -e mem "$RESOURCES_DIR/input-triples.ttl" "$RESOURCES_DIR/query-construct-triples.sparql" -o "$TEMP_DIR/output.nq"
     [ "$status" -eq 0 ]
-    [ -f "$TEST_DIR/output.nq" ]
+    [ -f "$TEMP_DIR/output.nq" ]
 
-    expected=$(cat "$TEST_DIR/expected-nquads.nq")
-    actual=$(cat "$TEST_DIR/output.nq")
+    expected=$(cat "$RESOURCES_DIR/expected-nquads.nq")
+    actual=$(cat "$TEMP_DIR/output.nq")
     [ "$expected" = "$actual" ]
 }
 
 @test "mem: load turtle data and output trig" {
-    run rpt integrate -e mem "$TEST_DIR/input-triples.ttl" "$TEST_DIR/query-construct-triples.sparql" -o "$TEST_DIR/output.trig"
+    run rpt integrate -e mem "$RESOURCES_DIR/input-triples.ttl" "$RESOURCES_DIR/query-construct-triples.sparql" -o "$TEMP_DIR/output.trig"
     [ "$status" -eq 0 ]
-    [ -f "$TEST_DIR/output.trig" ]
+    [ -f "$TEMP_DIR/output.trig" ]
 
-    expected=$(cat "$TEST_DIR/expected-trig.trig")
-    actual=$(cat "$TEST_DIR/output.trig")
+    expected=$(cat "$RESOURCES_DIR/expected-trig.trig")
+    actual=$(cat "$TEMP_DIR/output.trig")
     [ "$expected" = "$actual" ]
 }
 
 teardown() {
-    rm -f "$TEST_DIR/output.ttl" "$TEST_DIR/output.nt" "$TEST_DIR/output.nq" "$TEST_DIR/output.trig"
+    rm -rf "$TEMP_DIR"
 }