Skip to content

Remove the need to set max_room_ir_length #3

Description

@Pvjesper

When max_room_ir_length is set, there is a need to monitor the truncation length when simulation parameters are changed, to ensure that you are not incurring large errors there compared to the expected result. It should not be a difficult fix to instead calculate the impulse responses for their full length, and internally set the max_room_ir_length to whatever the smallest number it can be set to without incurring any additional error.

In that case, the corresponding value for max_room_ir_length shoud be None, and it should be the default.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions