From 54ddeccf5c4afaeca0865691d20cc711deac46ec Mon Sep 17 00:00:00 2001 From: "jing8.li" Date: Tue, 11 Nov 2025 17:59:04 +0800 Subject: [PATCH] feat: metrics_path add password; connected_slave_lag is the delay count of writebatch, remove seconds --- exporter/exporter.go | 2 +- exporter/http.go | 4 ++++ exporter/info.go | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/exporter/exporter.go b/exporter/exporter.go index 1e1d93a4..f72dc20f 100644 --- a/exporter/exporter.go +++ b/exporter/exporter.go @@ -193,7 +193,7 @@ func NewKvrocksExporter(kvrocksURI string, opts Options) (*Exporter, error) { "commands_duration_seconds_bucket": {txt: `Histogram of the amount of time in seconds spent per command`, lbls: []string{"cmd"}}, "commands_duration_seconds_total": {txt: `Total amount of time in seconds spent per command`, lbls: []string{"cmd"}}, "commands_total": {txt: `Total number of calls per command`, lbls: []string{"cmd"}}, - "connected_slave_lag_seconds": {txt: "Lag of connected slave", lbls: []string{"slave_ip", "slave_port", "slave_state"}}, + "connected_slave_lag": {txt: "Lag of connected slave", lbls: []string{"slave_ip", "slave_port", "slave_state"}}, "connected_slave_offset_bytes": {txt: "Offset of connected slave", lbls: []string{"slave_ip", "slave_port", "slave_state"}}, "db_avg_ttl_seconds": {txt: "Avg TTL in seconds", lbls: []string{"db"}}, "db_keys": {txt: "Total number of keys by DB", lbls: []string{"db"}}, diff --git a/exporter/http.go b/exporter/http.go index 5889880c..322f07b3 100644 --- a/exporter/http.go +++ b/exporter/http.go @@ -54,6 +54,10 @@ func (e *Exporter) scrapeHandler(w http.ResponseWriter, r *http.Request) { opts := e.options + if password := r.URL.Query().Get("password"); password != "" { + opts.Password = password + } + registry := prometheus.NewRegistry() opts.Registry = registry diff --git a/exporter/info.go b/exporter/info.go index 3e6e5d63..ec7a8d67 100644 --- a/exporter/info.go +++ b/exporter/info.go @@ -267,7 +267,7 @@ func (e *Exporter) handleMetricsReplication(ch chan<- prometheus.Metric, masterH if slaveLag > -1 { e.registerConstMetricGauge(ch, - "connected_slave_lag_seconds", + "connected_slave_lag", slaveLag, slaveIP, slavePort, slaveState, )