refactor: replace M_PI with C++20 std::numbers::pi_v<float>

Author: JohnieWalkerCZ

include/Collider.hpp

@@ -2,12 +2,9 @@
 #include <algorithm>
 #include <cmath>
 #include <cstring>
+#include <numbers>
 #include <vector>
 
-#ifndef M_PI
-#define M_PI 3.14159265358979323846
-#endif
-
 class CircleCollider;
 class RectangleCollider;
 class PolygonCollider;
@@ -69,7 +66,7 @@ class Collider : public Collidable {
 };
 
 namespace CollisionMath {
-constexpr float DEG_TO_RAD = M_PI / 180.0f;
+constexpr float DEG_TO_RAD = std::numbers::pi_v<float> / 180.0f;
 
 inline int distanceSquared(int x1, int y1, int x2, int y2) {
     int dx = x1 - x2;

src/Collider.cpp

@@ -1,6 +1,7 @@
 #include "Collider.hpp"
 #include <algorithm>
 #include <cmath>
+#include <numbers>
 #include <vector>
 
 static std::vector<std::pair<int, int>>
@@ -12,9 +13,9 @@ getRegularPolyVertices(const RegularPolygonCollider *rp) {
 
     float c = std::cos(rotationRad);
     float s = std::sin(rotationRad);
-    float angleStep = 2.0f * M_PI / sides;
+    float angleStep = 2.0f * std::numbers::pi_v<float> / sides;
 
-    float startAngle = -M_PI / 2.0f;
+    float startAngle = -std::numbers::pi_v<float> / 2.0f;
 
     for (int i = 0; i < sides; i++) {
         float angle = i * angleStep + startAngle;

src/Shapes/RegularPolygon.cpp

@@ -3,6 +3,7 @@
 #include <algorithm>
 #include <cmath>
 #include <memory>
+#include <numbers>
 
 RegularPolygon::RegularPolygon(const RegularPolygonSideParams &params)
     : Shape(params), useSideLength(true), sideLength(params.sideLength),
@@ -30,7 +31,8 @@ void RegularPolygon::updateLocalVertices() {
     localVertices.reserve(sides);
 
     for (int i = 0; i < sides; i++) {
-        float angle = 2.0f * M_PI / sides * i - M_PI / 2.0f;
+        float angle = 2.0f * std::numbers::pi_v<float> / sides * i -
+                      std::numbers::pi_v<float> / 2.0f;
         localVertices.push_back({effectiveRadius * std::cos(angle),
                                  effectiveRadius * std::sin(angle)});
     }
@@ -49,7 +51,7 @@ void RegularPolygon::setRadius(int radius) {
 }
 
 int RegularPolygon::calculateRadiusFromSideLength(int sideLength) {
-    return sideLength / (2 * std::sin(M_PI / sides));
+    return sideLength / (2 * std::sin(std::numbers::pi_v<float> / sides));
 }
 
 std::unique_ptr<Collider> RegularPolygon::defaultCollider() {

src/Shapes/Shape.cpp

@@ -4,6 +4,7 @@
 #include <cmath>
 #include <cstdint>
 #include <memory>
+#include <numbers>
 
 Matrix2D multiplyMatrices(const Matrix2D &m1, const Matrix2D &m2) {
     Matrix2D out;
@@ -64,7 +65,7 @@ Shape::~Shape() = default;
 
 void Shape::updateTrigCache() {
     if (!_trigCacheValid) {
-        float angleRad = _rotationAngle * M_PI / 180.0f;
+        float angleRad = _rotationAngle * std::numbers::pi_v<float> / 180.0f;
         _cosAngle = std::cos(angleRad);
         _sinAngle = std::sin(angleRad);
         _trigCacheValid = true;
@@ -73,7 +74,8 @@ void Shape::updateTrigCache() {
 
 void Shape::updateTextureTrigCache() {
     if (!_texTrigCacheValid) {
-        float angleRad = _uvTransform.rotation * M_PI / 180.0f;
+        float angleRad =
+            _uvTransform.rotation * std::numbers::pi_v<float> / 180.0f;
         _texCos = std::cos(angleRad);
         _texSin = std::sin(angleRad);
         _texTrigCacheValid = true;