DGO Picker or Rivers Need Space including "touching" DGOs

[philipbaileynar]

Jordan is reporting that rivers need space report is including adjacent DGOs. Can you investigate please?

[weblorin]

Yes, this is a real issue, the intersects query includes touching polygons. I'll try to filter down results to only include where the area of intersection > 0.

[weblorin]

Besides the intersection logic, there is something strange about what the DGO picker provides.
I select two DGOs as shown, but the geojson returned has 3 rows. @MattReimer do you know what's going on here? Looks like we are getting both simplified and original polygons for one of the DGOs. And only one of the 3 records has full set of attributes.

[weblorin]

If the geometry of the layer we're using to select DGOs for input is different from the one we're querying (as seems to be the case) we're going to end up with problems at the edges.

[MattReimer]

So @weblorin the issue is that I was including the selected object as part of the input object sent to the cybercastor/python. The selected object is simplified so that's why that one was always there and always different-looking.

This was a weird and sloppy mistake. I'm changing the inputs so this duplication no longer exists. Patch shortly

UPDATE: That's fixed on staging now. Might need some careful testing but initial pass seems promising