RVD conversion type calculations very inefficient

[mhallerud]

The calculations for RVD's conv_code field seems very inefficient, primarily because it creates a bunch of rasters and calculates zonal statistics on those rasters individually. In the future, restructuring this process (perhaps by using "select" to create temporary layers with each value instead of reclassifying a bunch of rasters?) would be an easy way to make the code much more efficient. Currently the outputs are correct, but the process to create this single field seems very clunky and indirect.

[wally-mac]

@mhallerud thank you for this assessment. Can you please provide a rough time estimate on what you think it would take to restructure this process using selections rather than reclassifications?

[mhallerud]

@wally-mac I think this would take 10-15 hours. Another needed improvement is the XMLs. My guess is this would take closer to a full week to get these updated and running well. Currently I have every tool returning the following message before starting the XML write function:

""Writing XML file. NOTE: This is the final step and non-critical to the outputs"

[wally-mac]

@tyler1218hatch and @DylanBaum we need to check and see if Maggie dealt with this, I doubt that she did so we'll need to make these performance improvements.